The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.
TypeScript 3d-modelingagent-frameworkagent-harnessai-agentscadclaude-codecodexcoding-agentsdeveloper-toolsesp32game-developmentmcp-servermulti-agentopen-hardwareopencodeopenharnesspcbroboticsterminaltmux
ci(desktop): authenticate the internal build by federation, not a service-account key
Autonomous Devopsa1eea60e7a62
diff --git a/.github/workflows/desktop-internal-build.yml b/.github/workflows/desktop-internal-build.ymlindex c3bc8659a..82e558c41 100644--- a/.github/workflows/desktop-internal-build.yml+++ b/.github/workflows/desktop-internal-build.yml@@ -42,6 +42,10 @@ on:permissions:contents: read+ # Mints the OIDC token the auth step below exchanges for a short-lived GCP credential. It is a+ # capability, not a secret: what it can reach is decided by the pool's attribute-condition and the+ # service account's IAM bindings, not by this line.+ id-token: writeconcurrency:# A newer push to the same internal branch supersedes the build still notarizing — nobody is@@ -121,6 +125,9 @@ jobs:DEBUG_SURFACE: ${{ needs.prepare.outputs.debug_surface }}# The file a tester downloads names the build it is: version AND commit.ARTIFACT: ${{ matrix.artifact }}-${{ needs.prepare.outputs.version }}-${{ needs.prepare.outputs.short_sha }}+ # The `secrets` context cannot be read from a step-level `if:`, so reduce it to a boolean here+ # — job-level `env:` can see it. Holds "true"/"false", never the value itself.+ HAS_WIF: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER != '' }}defaults:run:working-directory: desktop@@ -148,10 +155,26 @@ jobs:apple-team-id: ${{ secrets.APPLE_TEAM_ID }}apple-app-password: ${{ secrets.APPLE_APP_PASSWORD }}- - uses: google-github-actions/auth@v2+ # GCP auth, WITHOUT a long-lived key wherever possible. The credential is used for exactly one+ # thing in this workflow: writing this build's .zip/.dmg to the release bucket under its+ # unlisted prefix, and resetting their cache headers afterwards.+ #+ # Same pool and provider as release.yml, and the SAME service account — this writes to+ # s3-autonomous-upgrade-3, the bucket that one already publishes to, so there was no new GCP+ # setup to do. Two steps only for the duration of the cutover; DELETE the key step (and the+ # GCP_SA_KEY secret) once an internal build has gone green on the first.+ - name: Authenticate to GCP (workload identity federation)+ if: env.HAS_WIF == 'true'+ uses: google-github-actions/auth@c200f3691d83b41bf9bbd8638997a462592937ed # v2+ with:+ workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}+ service_account: ${{ secrets.GCP_SERVICE_ACCOUNT }}+ - name: Authenticate to GCP (service-account key — legacy fallback)+ if: env.HAS_WIF != 'true'+ uses: google-github-actions/auth@c200f3691d83b41bf9bbd8638997a462592937ed # v2with:credentials_json: ${{ secrets.GCP_SA_KEY }}- - uses: google-github-actions/setup-gcloud@v2+ - uses: google-github-actions/setup-gcloud@e427ad8a34f8676edf47cf7d7925499adf3eb74f # v2- name: Build ${{ matrix.variant }} and pin its rendererenv:@@ -181,8 +204,11 @@ jobs:bash scripts/upload-desktop.sh --no-build "$VERSION"# upload-desktop.sh uploads with a year-long immutable cache: right for a release path# nobody ever changes, wrong for a build that may have to be taken back.- gsutil -m setmeta -h "Cache-Control:private, max-age=0, no-store" \- "gs://${GCS_BUCKET}/${GCS_PATH}" "gs://${GCS_BUCKET}/${DMG_GCS_PATH}"+ # `gcloud storage`, not gsutil: gsutil cannot use the external-account credential+ # federation issues, and parallelises by default so `-m` has no equivalent.+ gcloud storage objects update \+ "gs://${GCS_BUCKET}/${GCS_PATH}" "gs://${GCS_BUCKET}/${DMG_GCS_PATH}" \+ --cache-control="private, max-age=0, no-store"- name: Hand out the linkenv:@@ -203,7 +229,7 @@ jobs:echo "dmg sha256 \`${sha}\`"echoecho "Unlisted, not private: this repository is public, so anyone who opens this page can"- echo "download the build. Take it back with \`gsutil -m rm -r gs://${GCS_BUCKET}/${PREFIX}\`"+ echo "download the build. Take it back with \`gcloud storage rm -r gs://${GCS_BUCKET}/${PREFIX}\`"echo "(both builds of this run)."} >> "$GITHUB_STEP_SUMMARY"