Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

Settings leftovers: Appearance everywhere, Agents stays current, Add machine says what to do (#1205)

Deefb1df9d3565c
diff --git a/desktop/CLAUDE.md b/desktop/CLAUDE.md
index faaaf7b8c..0546b481f 100644
--- a/desktop/CLAUDE.md
+++ b/desktop/CLAUDE.md
@@ -460,7 +460,7 @@ add a kind there, not at the call site.
percentages. Automatic names use the strongest shared harness type,
project, or machine, preferring traits that distinguish tabs and excluding dependent viewers.
The context follows a viewer's owner and uses the compact project label, never a worktree path
- or marker. User-renamed tabs always retain their saved name. Customize Harness → Status
+ or marker. User-renamed tabs always retain their saved name. Appearance → Status
selects shell-inspired text or Powerline themes; the focused PR label uses that same theme.
The single focused PR reader is `state/workspace_pull_request.dart`.
- `lib/theme/app_theme.dart` (`AppColors`, `AppTheme.terminalLight/terminalDark`) is a set of
@@ -665,7 +665,7 @@ add a kind there, not at the call site.
Controls come from `shared/widgets/` too (`AppSelectField`, `AppIconButton`) — raw Material
`DropdownButton`/`IconButton` do not match anything else in the app.
**Settings holds settings only** (owner, 2026-10-11): Account alone at the top, then General
- (Appearance — the `customize` row, which opens Customize Harness over the workspace —
+ (Appearance — the `customize` row, which opens the Appearance panel over the workspace —
Notifications, Keyboard shortcuts), Agents (Agents, Connectors, Usage), Labs (Experimental) and
Help (About, Debug in dev builds). A thing is managed where it lives: the Autonomous robots —
Wi-Fi code pairing, Revoke, Still companion — in the Devices tab (`devices/wifi_robots.dart`);
@@ -675,7 +675,9 @@ add a kind there, not at the call site.
workspace asks for Machines with `AppNotifier.requestMachines` (`openMachines` in
`widgets/new_device_notice.dart`). Settings ▸ Agents reads and writes this computer's daemon
(`/api/agent-settings`, bare JSON, not `{success, data}`); a setting the daemon's answer does
- not name is not shown.
+ not name is not shown. `harness settings` changes the same file and the daemon sends no event,
+ so the open page reads again every 5 s while the window can be seen and once when it comes back
+ to the front (`AgentSettingsStore.recheck`): quiet, and never across a change being saved.
- **The log is written to files, and Settings ▸ Debug reads them back** (`lib/logging/`,
`settings/sections/debug_*.dart`). `appLog` (`app-YYYYMMDD.log`) is the narrative — `app`, `ws`,
`api`, `flutter` — and `cliLog` (`cli-YYYYMMDD.log`) is a transcript of every child process, both
diff --git a/desktop/design/terminal-prompt-styling.md b/desktop/design/terminal-prompt-styling.md
index 788c6a775..0fa76e744 100644
--- a/desktop/design/terminal-prompt-styling.md
+++ b/desktop/design/terminal-prompt-styling.md
@@ -1,6 +1,6 @@
# Prompt themes and workspace styling
-For the current top bar and Customize Harness → Status, follow
+For the current top bar and Appearance → Status, follow
[Workspace status bar](workspace-status-bar.md). It replaces the pane-header
choices described below with Standard, Robbyrussell, Pure, and Starship text
formats. The notes below describe the older `PromptContextView` surfaces;
diff --git a/desktop/design/terminal-workspace.md b/desktop/design/terminal-workspace.md
index aaf1c075b..76be7cbb9 100644
--- a/desktop/design/terminal-workspace.md
+++ b/desktop/design/terminal-workspace.md
@@ -84,7 +84,7 @@ All panes stay at full contrast by default. **Cmd+Shift+F** toggles shading on
and off while working (**Ctrl+Alt+F** on Linux; **Alt+Shift+F** in the browser).
When enabled, panes outside the current focus receive the approved 30%
neutral-gray veil; Graphite's inactive background is RGB 64,64,64.
-Customize Harness → Appearance → **Shade inactive panes** toggles this veil
+Appearance → Workspace → **Shade inactive panes** toggles this veil
through the same saved preference and shows the current shortcut, including
remaps. **Toggle pane shading** is also available in the command search and
keyboard shortcuts. Turning it off leaves
diff --git a/desktop/design/wallpapers.md b/desktop/design/wallpapers.md
index a7c872f6e..9e98f27e1 100644
--- a/desktop/design/wallpapers.md
+++ b/desktop/design/wallpapers.md
@@ -1,6 +1,6 @@
# Backgrounds
-Blank remains the default and uses the selected tab's workspace color. Choose artwork under Customize Harness → Background. Any background but Blank shows behind the panes of a running harness tab, seen through them; there is no separate switch. **Pane opacity** (0–100%, default 50%) sets how solid the panes stay over it. Settings shows the slider only while a background other than Blank is chosen. Older builds saved a Behind harnesses on/off flag beside the opacity; it is ignored. Empty welcome and new-tab pages are plain.
+Blank remains the default and uses the selected tab's workspace color. Choose artwork under Appearance → Wallpaper. Any background but Blank shows behind the panes of a running harness tab, seen through them; there is no separate switch. **Pane opacity** (0–100%, default 50%) sets how solid the panes stay over it. Settings shows the slider only while a background other than Blank is chosen. Older builds saved a Behind harnesses on/off flag beside the opacity; it is ignored. Empty welcome and new-tab pages are plain.
The four images below were created with the built-in image generation tool. The PNG outputs were copied into the app without retouching. They are bundled locally; changing wallpaper does not make a network request. The center is deliberately quiet so the terminal-font welcome message remains readable.
@@ -47,7 +47,7 @@ While the custom background is selected, **Dim** (0–80%, default 40%) darkens
Rendered app previews: [welcome with terminal wallpaper](review/welcome-terminal-wallpaper.png) and [keyboard shortcut popup](review/keyboard-shortcuts-browser.png).
-`test/welcome_wallpaper_shortcuts_test.dart` loads the actual bundled images and renders the welcome content with the terminal font. It checks selection persistence, the blank default, font changes and compact layouts. `test/workspace_start_guide_test.dart` checks that opening and closing both command panels preserves the welcome text and wallpaper bounds, and that Customize Harness opens the wallpaper picker.
+`test/welcome_wallpaper_shortcuts_test.dart` loads the actual bundled images and renders the welcome content with the terminal font. It checks selection persistence, the blank default, font changes and compact layouts. `test/workspace_start_guide_test.dart` checks that opening and closing both command panels preserves the welcome text and wallpaper bounds, and that Appearance opens the wallpaper picker.
To capture review images outside the repository:
diff --git a/desktop/design/workspace-status-bar.md b/desktop/design/workspace-status-bar.md
index aba55066a..96b63fcf7 100644
--- a/desktop/design/workspace-status-bar.md
+++ b/desktop/design/workspace-status-bar.md
@@ -25,7 +25,7 @@ tooltip, and the row's last control is the account's. While this computer
holds no account that is **Sign in**, the only control in the row with a word
and a fill; it opens the sign-in over the workspace. Signed in, the same place
is the account's initial in a circle, and a click opens a short menu: who is
-signed in, then Add Phone (until the account has a phone), Customize Harness,
+signed in, then Add Phone (until the account has a phone), Appearance,
Notifications, Settings and Sign out, each opening what the app already has.
Nothing is drawn between the icons and the account control; `controlGap`
separates them. A narrow window drops Devices first; the account control
@@ -481,7 +481,7 @@ system SF Mono face at 18 pt; the dialog itself follows the selected terminal
font, size and palette. The same suite checks narrow windows, enlarged text,
alternate palettes, and retained keyboard focus when appearance changes.
-Customize Harness → Status offers twelve saved themes, grouped into Minimal
+Appearance → Status offers twelve saved themes, grouped into Minimal
and Powerline, with a preview of the same sample pane beneath each choice.
Selection covers only the name row. Tab and Shift-Tab move between choices;
Enter or Space selects, scrolls the choice into view, and saves it. The selected
diff --git a/desktop/integration_test/sign_in_native_test.dart b/desktop/integration_test/sign_in_native_test.dart
index 35e89b77b..0b63e2a93 100644
--- a/desktop/integration_test/sign_in_native_test.dart
+++ b/desktop/integration_test/sign_in_native_test.dart
@@ -533,7 +533,7 @@ void main() {
);
for (final row in const [
'Add Phone',
- 'Customize Harness',
+ 'Appearance',
'Notifications',
'Settings',
'Sign out',
diff --git a/desktop/lib/screens/swarm_screen.dart b/desktop/lib/screens/swarm_screen.dart
index ad130d9a1..0969f5767 100644
--- a/desktop/lib/screens/swarm_screen.dart
+++ b/desktop/lib/screens/swarm_screen.dart
@@ -7076,7 +7076,11 @@ class _SwarmScreenState extends State<SwarmScreen> {
?mode('keyboard.quick_start', 'Quick start', 'Four steps into real work'),
?mode('keyboard.practice', 'Keyboard practice', 'Try every shortcut'),
?mode('keyboard.open_config', 'Edit keybindings', 'keybindings.jsonc'),
- ?mode('app.customize', 'Customize Harness', 'Prompt · colors · fonts'),
+ ?mode(
+ 'app.customize',
+ 'Appearance',
+ 'Status · colors · wallpaper · fonts',
+ ),
?mode('app.settings', 'Settings', ''),
];
}
@@ -7121,7 +7125,12 @@ class _SwarmScreenState extends State<SwarmScreen> {
swarmId: null,
current: false,
commandId: '$_settingsCommand${section.name}',
- searchFields: ['settings', 'preferences', section.name],
+ searchFields: [
+ 'settings',
+ 'preferences',
+ section.name,
+ ...section.keywords,
+ ],
),
];
diff --git a/desktop/lib/settings/agent_settings.dart b/desktop/lib/settings/agent_settings.dart
index 48c4ebe6f..9a7e9844f 100644
--- a/desktop/lib/settings/agent_settings.dart
+++ b/desktop/lib/settings/agent_settings.dart
@@ -56,8 +56,14 @@ class AgentSettingsStore extends ChangeNotifier {
final _values = <AgentSetting, bool>{};
bool loaded = false, saving = false, _disposed = false;
+
+ /// Bumped by every read and write: an answer is taken only while its own is the latest, so a
+ /// change the person starts wins over any read already under way.
int _generation = 0;
+ /// The generation of the read under way, while it is the latest.
+ int? _reading;
+
/// Why the last read or write failed, or why there is nothing to read.
String? error;
@@ -92,11 +98,13 @@ class AgentSettingsStore extends ChangeNotifier {
? failure.message
: 'Couldn’t reach Harness on this computer. Check that it is running, then refresh.';
+ static const _predates = 'Update Harness on this computer to change this.';
+
Future<void> refresh() async {
final read = this.read;
// A read under way while a change is saved would drop the change's answer.
if (_disposed || saving || unavailable != null || read == null) return;
- final generation = ++_generation;
+ final generation = _reading = ++_generation;
error = null;
errorSetting = null;
_changed();
@@ -106,7 +114,7 @@ class AgentSettingsStore extends ChangeNotifier {
if (answer == null) {
loaded = false;
_values.clear();
- error = 'Update Harness on this computer to change this.';
+ error = _predates;
} else {
_take(answer);
loaded = true;
@@ -114,10 +122,58 @@ class AgentSettingsStore extends ChangeNotifier {
} catch (failure) {
if (_disposed || generation != _generation) return;
error = _message(failure);
+ } finally {
+ if (_reading == generation) _reading = null;
}
_changed();
}
+ /// Reads the settings again without a word, for a page left open while something else changes
+ /// them: `harness settings` in a terminal, an agent, another window. Nothing shows until the
+ /// daemon answers, and then only a difference — a value, or a page that could not read them
+ /// and now can. A read that fails leaves the page as it was: Refresh and the switches say why.
+ ///
+ /// It never fights the person: not while a change is saved or another read is under way, and a
+ /// change started while it waits wins ([_generation]).
+ Future<void> recheck() async {
+ final read = this.read;
+ if (_disposed ||
+ saving ||
+ _reading == _generation ||
+ unavailable != null ||
+ read == null) {
+ return;
+ }
+ final generation = _reading = ++_generation;
+ try {
+ final answer = await read();
+ if (_disposed || generation != _generation) return;
+ if (answer == null) {
+ // The daemon went back to one that predates these: say so, as a refresh would.
+ if (!loaded && error == _predates) return;
+ loaded = false;
+ _values.clear();
+ error = _predates;
+ errorSetting = null;
+ } else {
+ final before = Map.of(_values);
+ final wasLoaded = loaded;
+ // A failed read said so under the first row; this one answered. A failed CHANGE keeps its
+ // line under its own row until the person acts.
+ final readFailed = error != null && errorSetting == null;
+ _take(answer);
+ loaded = true;
+ if (readFailed) error = null;
+ if (wasLoaded && !readFailed && mapEquals(before, _values)) return;
+ }
+ _changed();
+ } catch (_) {
+ // Quiet: the last answer stands.
+ } finally {
+ if (_reading == generation) _reading = null;
+ }
+ }
+
Future<void> set(AgentSetting setting, bool on) async {
final write = this.write;
if (_disposed || saving || blocked || write == null || !loaded) return;
diff --git a/desktop/lib/settings/sections/agents_section.dart b/desktop/lib/settings/sections/agents_section.dart
index d0a802b87..604e66199 100644
--- a/desktop/lib/settings/sections/agents_section.dart
+++ b/desktop/lib/settings/sections/agents_section.dart
@@ -7,20 +7,65 @@ import '../../shared/widgets/setting_row.dart';
import '../agent_settings.dart';
/// Settings ▸ Agents: what the agents on this computer may do with Harness itself.
+///
+/// The daemon keeps these, and `harness settings` changes them from a terminal without telling
+/// anyone, so the page reads them again while it can be seen: every [recheckEvery], and as soon as
+/// the window comes back to the front. A hidden or minimised window asks nothing.
class AgentsSection extends StatefulWidget {
- const AgentsSection({super.key, required this.store});
+ const AgentsSection({
+ super.key,
+ required this.store,
+ this.recheckEvery = const Duration(seconds: 5),
+ });
final AgentSettingsStore store;
+ /// How often the open page reads the settings again while the window can be seen.
+ final Duration recheckEvery;
+
@override
State<AgentsSection> createState() => _AgentsSectionState();
}
class _AgentsSectionState extends State<AgentsSection> {
+ late final AppLifecycleListener _lifecycle;
+ Timer? _recheck;
+
@override
void initState() {
super.initState();
unawaited(widget.store.refresh());
+ _lifecycle = AppLifecycleListener(
+ // Back in front: whatever changed meanwhile, at once.
+ onResume: () => unawaited(widget.store.recheck()),
+ onStateChange: _watch,
+ );
+ _watch(WidgetsBinding.instance.lifecycleState);
+ }
+
+ /// Rechecks on a timer while the window can be seen — in front, or beside the terminal
+ /// the change is typed in (inactive) — and not while it is hidden. An unknown state is seen.
+ void _watch(AppLifecycleState? state) {
+ final seen =
+ state == null ||
+ state == AppLifecycleState.resumed ||
+ state == AppLifecycleState.inactive;
+ if (!seen || widget.store.unavailable != null) {
+ _recheck?.cancel();
+ _recheck = null;
+ } else {
+ _recheck ??= Timer.periodic(
+ widget.recheckEvery,
+ (_) => unawaited(widget.store.recheck()),
+ );
+ }
+ }
+
+ @override
+ void dispose() {
+ _recheck?.cancel();
+ _lifecycle.dispose();
+ super.dispose();
}
@override
diff --git a/desktop/lib/settings/sections/appearance_section.dart b/desktop/lib/settings/sections/appearance_section.dart
index c5470167a..ccf74e871 100644
--- a/desktop/lib/settings/sections/appearance_section.dart
+++ b/desktop/lib/settings/sections/appearance_section.dart
@@ -9,10 +9,11 @@ import '../../shared/widgets/setting_row.dart';
import '../../shortcuts/app_keymap.dart';
import '../../widgets/key_hints.dart';
-/// Customize Harness ▸ Appearance: how the app looks on this Mac.
+/// Appearance ▸ Workspace: inactive pane shading, automatic tab names and the
+/// colour palette. (The class keeps its old name; the tab was Appearance.)
///
/// Palettes coordinate the workspace and terminal defaults. The shared font
-/// and size are configured once in Customize Harness ▸ Terminal.
+/// and size are configured once in Appearance ▸ Terminal.
class AppearanceSection extends StatelessWidget {
const AppearanceSection({super.key, this.store});
final AppearancePrefsStore? store;
diff --git a/desktop/lib/settings/sections/terminal_section.dart b/desktop/lib/settings/sections/terminal_section.dart
index a3852175c..033223e25 100644
--- a/desktop/lib/settings/sections/terminal_section.dart
+++ b/desktop/lib/settings/sections/terminal_section.dart
@@ -14,10 +14,10 @@ import '../../terminal/terminal_font_store.dart';
import '../../terminal/terminal_theme.dart';
import '../../terminal/terminal_theme_store.dart';
-/// Customize Harness ▸ Terminal: the colours and the face the agent's output is drawn in.
+/// Appearance ▸ Terminal: the colours and the face the agent's output is drawn in.
///
/// Laid out in the app's own [SettingRow]s rather than in bare Material, for
-/// the same reason Appearance is: a preference reads as a preference here or it
+/// the same reason Workspace is: a preference reads as a preference here or it
/// reads as a different app one pane over. What this screen adds on top of that
/// shape is the [_Preview] — the terminal is the one setting whose value can
/// only really be judged by looking at it, so the sample is given the room a
diff --git a/desktop/lib/settings/settings_nav.dart b/desktop/lib/settings/settings_nav.dart
index ae2d01942..4b9719ae9 100644
--- a/desktop/lib/settings/settings_nav.dart
+++ b/desktop/lib/settings/settings_nav.dart
@@ -89,9 +89,10 @@ class _SettingsNavState extends State<SettingsNav> {
}
/// The groups, narrowed to the query. Matching is a plain case-insensitive
- /// substring of the label — this list is short, so anything cleverer
- /// would be machinery no one can feel. A group's own title matches too, so
- /// typing "help" surfaces the whole run rather than nothing.
+ /// substring of the label or a row's keywords ([SettingsSection.matches]) —
+ /// this list is short, so anything cleverer would be machinery no one can
+ /// feel. A group's own title matches too, so typing "help" surfaces the
+ /// whole run rather than nothing.
List<SettingsGroup> get _visible {
final query = _query.trim().toLowerCase();
// The list this build actually has: [settingsGroups] drops the developer
@@ -106,7 +107,7 @@ class _SettingsNavState extends State<SettingsNav> {
}
final rows = [
for (final target in group.sections)
- if (target.label.toLowerCase().contains(query)) target,
+ if (target.matches(query)) target,
];
if (rows.isNotEmpty) groups.add(SettingsGroup(group.title, rows));
}
diff --git a/desktop/lib/settings/settings_section.dart b/desktop/lib/settings/settings_section.dart
index ca27fc61c..219457a91 100644
--- a/desktop/lib/settings/settings_section.dart
+++ b/desktop/lib/settings/settings_section.dart
@@ -5,7 +5,7 @@ import 'package:flutter/foundation.dart' show kIsWeb;
import '../logging/debug_surface.dart';
/// A Settings navigation entry. Appearance ([customize]) returns to the workspace and opens its
-/// side panel, Customize Harness; the other entries select a Settings page.
+/// side panel, also called Appearance; the other entries select a Settings page.
///
/// Settings holds settings only. What is a thing rather than a setting lives where the thing is:
/// the Autonomous robots in the Devices tab, the account's computers, phones and apps — and which
@@ -16,8 +16,23 @@ import '../logging/debug_surface.dart';
/// be listed without a screen behind it or reachable without a row.
enum SettingsSection {
account(AppIcons.user, 'Account'),
- // Named `customize` still: the command palette remembers `settings:customize`.
- customize(AppIcons.palette, 'Appearance'),
+ // Named `customize` still: the command palette remembers `settings:customize`. Its panel's
+ // tabs and its old name find it too.
+ customize(
+ AppIcons.palette,
+ 'Appearance',
+ keywords: [
+ 'customize',
+ 'status',
+ 'workspace',
+ 'wallpaper',
+ 'terminal',
+ 'theme',
+ 'colors',
+ 'palette',
+ 'font',
+ ],
+ ),
notifications(AppIcons.bell, 'Notifications'),
shortcuts(AppIcons.keyboard, 'Keyboard shortcuts'),
agents(AppIcons.bot, 'Agents'),
@@ -27,12 +42,21 @@ enum SettingsSection {
about(AppIcons.info, 'About'),
debug(AppIcons.bug, 'Debug');
- const SettingsSection(this.icon, this.label);
+ const SettingsSection(this.icon, this.label, {this.keywords = const []});
/// The rail glyph — Lucide's 300 weight, the one the machine rail's rows use,
/// so the app's two nav columns draw at the same line weight.
final IconData icon;
final String label;
+
+ /// Other words the rail's filter and ⌘P find this row by, lowercase: what is inside a row
+ /// whose label does not say it, and a name it had before.
+ final List<String> keywords;
+
+ /// Whether [query] (trimmed, lowercase) finds this row: in its label or one of its [keywords].
+ bool matches(String query) =>
+ label.toLowerCase().contains(query) ||
+ keywords.any((keyword) => keyword.contains(query));
}
/// One labelled run of rows in the settings rail.
diff --git a/desktop/lib/shortcuts/keymap_commands.dart b/desktop/lib/shortcuts/keymap_commands.dart
index d3bd59944..aa73edc17 100644
--- a/desktop/lib/shortcuts/keymap_commands.dart
+++ b/desktop/lib/shortcuts/keymap_commands.dart
@@ -512,9 +512,19 @@ final harnessCommands = <HarnessCommand>[
),
const HarnessCommand(
'app.customize',
- 'Customize Harness',
+ 'Appearance',
ShortcutGroup.actions,
nativeAction: 'customize',
+ // It was Customize Harness; its panel's tabs are Status, Workspace, Wallpaper and Terminal.
+ keywords: [
+ 'customize',
+ 'theme',
+ 'colors',
+ 'palette',
+ 'wallpaper',
+ 'status',
+ 'font',
+ ],
),
const HarnessCommand(
'pane.toggle_shading',
diff --git a/desktop/lib/state/swarm_search.dart b/desktop/lib/state/swarm_search.dart
index b0b834c53..457b3a5f9 100644
--- a/desktop/lib/state/swarm_search.dart
+++ b/desktop/lib/state/swarm_search.dart
@@ -1081,6 +1081,8 @@ class SwarmSearchController extends ChangeNotifier {
: isModelMode
? '[ Add ]'
: 'New Harness';
+
+ /// What the create row's preview says, in full: the steps, for Add machine.
String get createDescription => isMachineMode
? 'On the other computer:\n\n1. Install the app or CLI.\n2. Sign in to the same account.\n\nIt appears here and connects on its own.'
: isModelMode
@@ -1089,6 +1091,13 @@ class SwarmSearchController extends ChangeNotifier {
'fal.ai or Replicate: harness agents can call it as a tool.\n\n'
'The key stays on this computer.'
: 'Choose a harness, machine, and project.';
+
+ /// The create row's own subtitle, one line that says something by itself: a row shows only its
+ /// first line, and Add machine's first line of [createDescription] is only "On the other
+ /// computer:". The steps stay in the preview beside it.
+ String get createDetail => isMachineMode
+ ? 'Install Harness there and sign in to the same account'
+ : createDescription;
SwarmGroupScope? _groupScope;
bool get canGoBack => _groupScope != null;
String? get scopedBranch => _groupScope?.branch;
@@ -1348,8 +1357,8 @@ class SwarmSearchController extends ChangeNotifier {
? 'create:$scopePrefix'
: kSwarmCreateRowId,
title: title,
- detail: name ?? createDescription,
- terminalDetail: createDescription,
+ detail: name ?? createDetail,
+ terminalDetail: createDetail,
swarmId: null,
current: false,
isCreate: true,
diff --git a/desktop/lib/terminal/terminal_theme_store.dart b/desktop/lib/terminal/terminal_theme_store.dart
index 785358578..beab166e4 100644
--- a/desktop/lib/terminal/terminal_theme_store.dart
+++ b/desktop/lib/terminal/terminal_theme_store.dart
@@ -20,7 +20,7 @@ import '../core/local_key_value_store.dart';
/// scheme later is one value here and one `const` in `terminal_theme.dart`.
enum TerminalThemeChoice {
/// Today's behaviour, and still the default: ground and cursor follow the
- /// palette chosen in Customize Harness ▸ Appearance, and the ANSI ramp its
+ /// palette chosen in Appearance ▸ Workspace, and the ANSI ramp its
/// brightness (`darkTerminalTheme`'s or `lightTerminalTheme`'s).
matchApp('Match app appearance', 'Matches your app palette'),
diff --git a/desktop/lib/web/shell/web_menu_items.dart b/desktop/lib/web/shell/web_menu_items.dart
index afc6ddb25..bbd2067b7 100644
--- a/desktop/lib/web/shell/web_menu_items.dart
+++ b/desktop/lib/web/shell/web_menu_items.dart
@@ -81,7 +81,7 @@ const List<List<WebMenuItem>> kWebMenuGroups = [
),
(
command: 'app.customize',
- label: 'Customize',
+ label: 'Appearance',
icon: Icon(AppIcons.palette),
width: WebMenuWidth.any,
),
diff --git a/desktop/lib/widgets/account_menu.dart b/desktop/lib/widgets/account_menu.dart
index 4e07b9036..2bc4d6249 100644
--- a/desktop/lib/widgets/account_menu.dart
+++ b/desktop/lib/widgets/account_menu.dart
@@ -13,8 +13,8 @@ import 'workspace_account_button.dart';
/// What the account menu was asked for.
enum AccountMenuChoice { addPhone, customize, notifications, settings, signOut }
-/// The menu under the avatar: who is signed in, then Add Phone, Customize
-/// Harness, Notifications, Settings and Sign out. Each opens something the app
+/// The menu under the avatar: who is signed in, then Add Phone, Appearance,
+/// Notifications, Settings and Sign out. Each opens something the app
/// already has; the caller does that once this has closed, so the two never
/// stand on screen together. Kept to these five (owner, 2026-10-11).
///
@@ -68,7 +68,7 @@ class _AccountMenuState extends State<AccountMenu> {
late final _rows = [
if (widget.showAddPhone)
(AccountMenuChoice.addPhone, AppIcons.smartphone, 'Add Phone'),
- (AccountMenuChoice.customize, AppIcons.palette, 'Customize Harness'),
+ (AccountMenuChoice.customize, AppIcons.palette, 'Appearance'),
(AccountMenuChoice.notifications, AppIcons.bell, 'Notifications'),
(AccountMenuChoice.settings, AppIcons.settings, 'Settings'),
(AccountMenuChoice.signOut, AppIcons.logOut, 'Sign out'),
diff --git a/desktop/lib/widgets/harness_customize_pane.dart b/desktop/lib/widgets/harness_customize_pane.dart
index c9c0c7056..101743f36 100644
--- a/desktop/lib/widgets/harness_customize_pane.dart
+++ b/desktop/lib/widgets/harness_customize_pane.dart
@@ -11,8 +11,8 @@ import '../shared/widgets/app_dialog.dart';
import 'desktop_chrome.dart';
import 'prompt_customize.dart';
-/// Opens customization over the workspace so appearance changes remain visible
-/// on the terminals. All global entry points use this same right-side panel.
+/// Opens Appearance over the workspace so its changes remain visible on the
+/// terminals. All global entry points use this same right-side panel.
Future<void> showHarnessCustomizePane(
BuildContext context, {
ValueChanged<bool>? onCurrentChanged,
@@ -39,7 +39,9 @@ Future<void> showHarnessCustomizePane(
),
);
-/// Customization tabs share the app's existing preference stores.
+/// Appearance: Status, Workspace, Wallpaper and Terminal, sharing the app's
+/// existing preference stores. Settings' rail, the Harness menu, the account
+/// menu and ⌘P all call it Appearance.
class HarnessCustomizePane extends StatelessWidget {
const HarnessCustomizePane({super.key, required this.onClose, this.store});
final VoidCallback onClose;
@@ -74,14 +76,14 @@ class HarnessCustomizePane extends StatelessWidget {
children: [
Expanded(
child: Text(
- 'Customize Harness',
+ 'Appearance',
style: DesktopChrome.heading(),
),
),
IconButton(
key: const ValueKey('harness-customize-close'),
autofocus: true,
- tooltip: 'Close customization',
+ tooltip: 'Close Appearance',
onPressed: onClose,
style:
IconButton.styleFrom(
@@ -128,10 +130,12 @@ class HarnessCustomizePane extends StatelessWidget {
height: tabHeight,
child: const _CustomizeTabLabel('Status'),
),
+ // Keyed `customize-appearance` still; it holds the workspace's
+ // pane shading, tab naming and colour palette.
Tab(
key: const ValueKey('customize-appearance'),
height: tabHeight,
- child: const _CustomizeTabLabel('Appearance'),
+ child: const _CustomizeTabLabel('Workspace'),
),
Tab(
key: const ValueKey('customize-wallpaper'),
diff --git a/desktop/lib/widgets/harness_start_page.dart b/desktop/lib/widgets/harness_start_page.dart
index 315d2569a..a5af6cec8 100644
--- a/desktop/lib/widgets/harness_start_page.dart
+++ b/desktop/lib/widgets/harness_start_page.dart
@@ -58,7 +58,7 @@ class _HarnessStartPageState extends State<HarnessStartPage> {
canRequestFocus: false,
);
final _searchGroup = Object();
- final _customizeButtonFocus = FocusNode(debugLabel: 'Customize Harness');
+ final _customizeButtonFocus = FocusNode(debugLabel: 'Appearance');
bool _customizing = false;
SwarmSearchController? _search;
SwarmSearchDraft? _draft;
@@ -395,7 +395,7 @@ class _HarnessStartPageState extends State<HarnessStartPage> {
key: const ValueKey('harness-customize-button'),
focusNode: _customizeButtonFocus,
onPressed: onPressed,
- label: 'Customize Harness',
+ label: 'Appearance',
overArtwork:
prefs.background != HarnessBackground.plain,
);
diff --git a/desktop/lib/widgets/linux_menu_bar.dart b/desktop/lib/widgets/linux_menu_bar.dart
index 95c45c975..b32de8594 100644
--- a/desktop/lib/widgets/linux_menu_bar.dart
+++ b/desktop/lib/widgets/linux_menu_bar.dart
@@ -245,7 +245,7 @@ class _LinuxMenuBarState extends State<LinuxMenuBar> {
_swarmRow(
key: 'menu-bar-customize',
icon: AppIcons.palette,
- label: 'Customize Harness',
+ label: 'Appearance…',
action: 'customize',
),
_swarmRow(
diff --git a/desktop/lib/widgets/workspace_welcome.dart b/desktop/lib/widgets/workspace_welcome.dart
index 26885c4d0..0d999290d 100644
--- a/desktop/lib/widgets/workspace_welcome.dart
+++ b/desktop/lib/widgets/workspace_welcome.dart
@@ -364,7 +364,7 @@ class _WorkspaceWelcomeState extends State<WorkspaceWelcome> {
child: TerminalTextAction(
key: const ValueKey('welcome-customize'),
onPressed: () => onCommand('app.customize'),
- label: 'Customize Harness',
+ label: 'Appearance',
overArtwork: hasArtwork,
),
),
diff --git a/desktop/macos/Runner/MainFlutterWindow.swift b/desktop/macos/Runner/MainFlutterWindow.swift
index 4cc38ab2b..0c48655c8 100644
--- a/desktop/macos/Runner/MainFlutterWindow.swift
+++ b/desktop/macos/Runner/MainFlutterWindow.swift
@@ -465,7 +465,7 @@ class MainFlutterWindow: NSWindow {
///
/// ```
/// Add Phone…
-/// Customize Harness
+/// Appearance…
/// Settings… ⌘,
/// ──────────
/// Check for Updates…
@@ -481,7 +481,7 @@ class MainFlutterWindow: NSWindow {
/// ```
///
/// Two places add to this menu — this window (Check for Updates) and the title
-/// bar (Settings, Customize, Add Phone) — in an order AppKit decides, so each
+/// bar (Settings, Appearance, Add Phone) — in an order AppKit decides, so each
/// calls this once it is done, and it rebuilds the whole menu from what is
/// there. Rows are found by what they do, not where they are; anything it does
/// not know keeps a place above Quit.
diff --git a/desktop/macos/Runner/SwarmTitlebar.swift b/desktop/macos/Runner/SwarmTitlebar.swift
index ee853a549..16a526abb 100644
--- a/desktop/macos/Runner/SwarmTitlebar.swift
+++ b/desktop/macos/Runner/SwarmTitlebar.swift
@@ -287,7 +287,7 @@ final class SwarmTitlebar: NSObject, NSMenuItemValidation, NSMenuDelegate {
addPhone.identifier = NSUserInterfaceItemIdentifier(HarnessKeymapMenu.actionPrefix + "addPhone")
addPhone.image = HarnessControlSymbols.image("iphone")
appMenu.insertItem(addPhone, at: appMenu.index(of: settings) + 1)
- let customize = NSMenuItem(title: "Customize Harness", action: #selector(menuAction(_:)), keyEquivalent: "")
+ let customize = NSMenuItem(title: "Appearance…", action: #selector(menuAction(_:)), keyEquivalent: "")
customize.target = self
customize.representedObject = "customize"
customize.identifier = NSUserInterfaceItemIdentifier(HarnessKeymapMenu.actionPrefix + "customize")
diff --git a/desktop/test/agents_section_test.dart b/desktop/test/agents_section_test.dart
index f09169d8c..6abbb81aa 100644
--- a/desktop/test/agents_section_test.dart
+++ b/desktop/test/agents_section_test.dart
@@ -24,14 +24,17 @@ class _Daemon {
Map<String, dynamic>? settings;
Object? readError;
Object? writeError;
- Completer<void>? writeGate;
+ Completer<void>? readGate, writeGate;
int reads = 0;
final writes = <(String, bool)>[];
+ /// What the file said when the read reached it, answered once [readGate] opens.
Future<Map<String, dynamic>?> read() async {
reads++;
+ final answer = settings == null ? null : Map.of(settings!);
+ await readGate?.future;
if (readError case final error?) throw error;
- return settings == null ? null : Map.of(settings!);
+ return answer;
}
Future<Map<String, dynamic>> write(String key, bool value) async {
@@ -48,15 +51,18 @@ class _Daemon {
void main() {
Future<AgentSettingsStore> open(
WidgetTester tester,
- AgentSettingsStore store,
- ) async {
+ AgentSettingsStore store, {
+ Duration recheckEvery = const Duration(seconds: 5),
+ }) async {
addTearDown(store.dispose);
tester.view.physicalSize = const Size(1000, 800);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.reset);
await tester.pumpWidget(
MaterialApp(
- home: Scaffold(body: AgentsSection(store: store)),
+ home: Scaffold(
+ body: AgentsSection(store: store, recheckEvery: recheckEvery),
+ ),
),
);
await tester.pumpAndSettle();
@@ -200,6 +206,160 @@ void main() {
);
});
+ group('while the page is open', () {
+ const every = Duration(seconds: 5);
+
+ /// Lets [time] pass, then the frames an answer arriving in it needs.
+ Future<void> wait(
+ WidgetTester tester, [
+ Duration time = Duration.zero,
+ ]) async {
+ await tester.pump(time);
+ await tester.pump();
+ await tester.pump();
+ }
+
+ testWidgets('a change made elsewhere shows by the next read', (
+ tester,
+ ) async {
+ final daemon = _Daemon();
+ await open(tester, daemon.store(), recheckEvery: every);
+ expect(daemon.reads, 1);
+ // `harness settings pull-request-line off`, in a terminal.
+ daemon.settings!['pullRequestLine'] = false;
+ await wait(tester, every ~/ 2);
+ expect(daemon.reads, 1);
+ expect(switchFor(tester, AgentSetting.pullRequestLine).value, isTrue);
+ await wait(tester, every ~/ 2);
+ expect(daemon.reads, 2);
+ expect(switchFor(tester, AgentSetting.pullRequestLine).value, isFalse);
+ // Quietly: no Loading… between, and the switches stay live.
+ expect(find.text('Loading…'), findsNothing);
+ expect(
+ switchFor(tester, AgentSetting.pullRequestLine).onChanged,
+ isNotNull,
+ );
+ daemon.settings!['agentsStartAgents'] = false;
+ await wait(tester, every);
+ expect(daemon.reads, 3);
+ expect(switchFor(tester, AgentSetting.agentsStartAgents).value, isFalse);
+ });
+
+ testWidgets('coming back to the front reads again at once; hidden asks '
+ 'nothing', (tester) async {
+ final daemon = _Daemon();
+ await open(tester, daemon.store(), recheckEvery: every);
+ final binding = tester.binding;
+ addTearDown(
+ () => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed),
+ );
+ binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
+ binding.handleAppLifecycleStateChanged(AppLifecycleState.hidden);
+ await wait(tester, every * 3);
+ expect(daemon.reads, 1, reason: 'a hidden window asks nothing');
+ daemon.settings!['agentsStartAgents'] = false;
+ binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
+ binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
+ await wait(tester);
+ expect(daemon.reads, 2, reason: 'once, as it comes back');
+ expect(switchFor(tester, AgentSetting.agentsStartAgents).value, isFalse);
+ // Beside the terminal, not in front: still read on the timer.
+ binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
+ daemon.settings!['agentsStartAgents'] = true;
+ await wait(tester, every);
+ expect(daemon.reads, 3);
+ expect(switchFor(tester, AgentSetting.agentsStartAgents).value, isTrue);
+ });
+
+ testWidgets('never fights a toggle', (tester) async {
+ final daemon = _Daemon();
+ await open(tester, daemon.store(), recheckEvery: every);
+ // Saving: no read starts, however long the daemon takes.
+ daemon.writeGate = Completer<void>();
+ await tester.tap(
+ find.byKey(const ValueKey('agent-setting-switch-agentsStartAgents')),
+ );
+ await wait(tester, every * 3);
+ expect(daemon.reads, 1);
+ expect(daemon.writes, [('agentsStartAgents', false)]);
+ expect(find.text('Saving…'), findsOneWidget);
+ daemon.writeGate!.complete();
+ daemon.writeGate = null;
+ await wait(tester);
+ expect(find.text('Saving…'), findsNothing);
+ expect(switchFor(tester, AgentSetting.agentsStartAgents).value, isFalse);
+
+ // A read under way when the person flips a switch: its older answer is dropped.
+ daemon.readGate = Completer<void>();
+ final before = daemon.reads;
+ await wait(tester, every);
+ expect(daemon.reads, before + 1);
+ await tester.tap(
+ find.byKey(const ValueKey('agent-setting-switch-pullRequestLine')),
+ );
+ await wait(tester);
+ expect(daemon.writes.last, ('pullRequestLine', false));
+ expect(switchFor(tester, AgentSetting.pullRequestLine).value, isFalse);
+ daemon.readGate!.complete();
+ daemon.readGate = null;
+ await wait(tester);
+ expect(
+ switchFor(tester, AgentSetting.pullRequestLine).value,
+ isFalse,
+ reason:
+ 'the read began before the change and says pullRequestLine is on',
+ );
+ expect(switchFor(tester, AgentSetting.agentsStartAgents).value, isFalse);
+ // And the next read sees the change.
+ await wait(tester, every);
+ expect(switchFor(tester, AgentSetting.pullRequestLine).value, isFalse);
+ });
+
+ testWidgets('a read that fails leaves the page as it was', (tester) async {
+ final daemon = _Daemon();
+ await open(tester, daemon.store(), recheckEvery: every);
+ daemon.readError = StateError('daemon restarting');
+ await wait(tester, every);
+ expect(daemon.reads, 2);
+ expect(find.byKey(const Key('agent-settings-reason')), findsNothing);
+ expect(switchFor(tester, AgentSetting.agentsStartAgents).value, isTrue);
+ expect(
+ switchFor(tester, AgentSetting.agentsStartAgents).onChanged,
+ isNotNull,
+ );
+ });
+
+ testWidgets('opened while the daemon was down, the next answer puts the '
+ 'page right', (tester) async {
+ final daemon = _Daemon()..readError = StateError('no daemon');
+ await open(tester, daemon.store(), recheckEvery: every);
+ expect(find.byKey(const Key('agent-settings-reason')), findsOneWidget);
+ expect(
+ find.text('Mark pull requests from agent-started harnesses'),
+ findsNothing,
+ );
+ daemon.readError = null;
+ await wait(tester, every);
+ expect(find.byKey(const Key('agent-settings-reason')), findsNothing);
+ expect(
+ switchFor(tester, AgentSetting.agentsStartAgents).onChanged,
+ isNotNull,
+ );
+ expect(
+ find.text('Mark pull requests from agent-started harnesses'),
+ findsOneWidget,
+ );
+ });
+
+ testWidgets('a page that is closed reads no more', (tester) async {
+ final daemon = _Daemon();
+ await open(tester, daemon.store(), recheckEvery: every);
+ await tester.pumpWidget(const SizedBox());
+ await wait(tester, every * 3);
+ expect(daemon.reads, 1);
+ });
+ });
+
testWidgets('in a browser: disabled, saying where it is changed', (
tester,
) async {
diff --git a/desktop/test/harness_customize_test.dart b/desktop/test/harness_customize_test.dart
index ed36c2e37..319d5f7cd 100644
--- a/desktop/test/harness_customize_test.dart
+++ b/desktop/test/harness_customize_test.dart
@@ -135,6 +135,54 @@ void main() {
expect(reopened.value, const AppearancePrefs());
});
+ testWidgets(
+ 'the panel is Appearance, as every way in calls it, and its tabs say what they hold',
+ (tester) async {
+ final store = AppearancePrefsStore(storage: _Storage());
+ addTearDown(store.dispose);
+ tester.view.physicalSize = const Size(440, 800);
+ tester.view.devicePixelRatio = 1;
+ addTearDown(tester.view.reset);
+ await tester.pumpWidget(
+ MaterialApp(
+ theme: grid.buildAppTheme(brightness: Brightness.light),
+ home: Scaffold(
+ body: HarnessCustomizePane(store: store, onClose: () {}),
+ ),
+ ),
+ );
+ await tester.pumpAndSettle();
+ // Not Appearance › Appearance: the title once, and no tab under it of the same name.
+ expect(find.text('Appearance'), findsOneWidget);
+ expect(find.text('Customize Harness'), findsNothing);
+ expect(find.byTooltip('Close Appearance'), findsOneWidget);
+ final tabs = [
+ for (final key in [
+ 'customize-prompt',
+ 'customize-appearance',
+ 'customize-wallpaper',
+ 'customize-terminal',
+ ])
+ tester
+ .widget<Text>(
+ find.descendant(
+ of: find.byKey(ValueKey(key)),
+ matching: find.byType(Text),
+ ),
+ )
+ .data,
+ ];
+ expect(tabs, ['Status', 'Workspace', 'Wallpaper', 'Terminal']);
+ // Workspace: the panes' shading, the tabs' names and the colour palette.
+ await tester.tap(find.byKey(const ValueKey('customize-appearance')));
+ await tester.pumpAndSettle();
+ expect(find.text('Shade inactive panes'), findsOneWidget);
+ expect(find.text('Auto rename'), findsOneWidget);
+ expect(find.text('Color palette'), findsOneWidget);
+ expect(tester.takeException(), isNull);
+ },
+ );
+
testWidgets(
'prompt choices preview, accept keyboard input and survive reopening',
(tester) async {
@@ -314,7 +362,7 @@ void main() {
matching: find.text('Robbyrussell'),
);
final beforeStyle = tester.widget<Text>(otherLabel).style!;
- final beforeHeader = tester.getSize(find.text('Customize Harness'));
+ final beforeHeader = tester.getSize(find.text('Appearance'));
expect(beforeStyle.fontFamily, grid.AppType.sansFamily);
expect(
beforeStyle.color,
@@ -327,7 +375,7 @@ void main() {
terminalFontStore.value = terminalFontStore.value.copyWith(fontSize: 24);
await tester.pumpAndSettle();
expect(tester.widget<Text>(otherLabel).style, beforeStyle);
- expect(tester.getSize(find.text('Customize Harness')), beforeHeader);
+ expect(tester.getSize(find.text('Appearance')), beforeHeader);
final sample = find.byKey(const ValueKey('prompt-example-standard'));
final sampleText = tester.widget<Text>(
find.descendant(of: sample, matching: find.byType(Text)),
diff --git a/desktop/test/harness_start_page_test.dart b/desktop/test/harness_start_page_test.dart
index f6ea4a986..ebf42a279 100644
--- a/desktop/test/harness_start_page_test.dart
+++ b/desktop/test/harness_start_page_test.dart
@@ -203,7 +203,7 @@ void main() {
});
testWidgets(
- 'over a picture, Customize keeps its shared capsule action and restores focus',
+ 'over a picture, Appearance keeps its shared capsule action and restores focus',
(tester) async {
tester.view.devicePixelRatio = 1;
tester.view.physicalSize = const Size(1280, 800);
@@ -232,10 +232,7 @@ void main() {
await tester.pump();
final button = find.byKey(const ValueKey('harness-customize-button'));
expect(tester.widget(button), isA<TerminalTextAction>());
- expect(
- find.widgetWithText(TextButton, 'Customize Harness'),
- findsOneWidget,
- );
+ expect(find.widgetWithText(TextButton, 'Appearance'), findsOneWidget);
expect(
find.descendant(of: button, matching: find.byType(Icon)),
findsNothing,
diff --git a/desktop/test/linux_menu_bar_test.dart b/desktop/test/linux_menu_bar_test.dart
index 725dfa938..8eed96c80 100644
--- a/desktop/test/linux_menu_bar_test.dart
+++ b/desktop/test/linux_menu_bar_test.dart
@@ -112,6 +112,9 @@ void main() {
expect(appActions.last, 'showAbout');
await tap(tester, 'menu-bar-harness');
+ // The panel it opens is Appearance, as Settings' rail calls it; "…" like Settings… beside it.
+ expect(find.text('Appearance…'), findsOneWidget);
+ expect(find.text('Customize Harness'), findsNothing);
await tap(tester, 'menu-bar-customize');
expect(swarmCalls.last.method, 'customize');
diff --git a/desktop/test/machine_devices_picker_test.dart b/desktop/test/machine_devices_picker_test.dart
index f9be65b60..b9e565180 100644
--- a/desktop/test/machine_devices_picker_test.dart
+++ b/desktop/test/machine_devices_picker_test.dart
@@ -233,6 +233,38 @@ void main() {
},
);
+ testWidgets(
+ 'Add machine says what to do in its one line; the preview keeps the steps',
+ (tester) async {
+ const line = 'Install Harness there and sign in to the same account';
+ await mount(tester);
+ await openPicker(tester);
+ final add = resourceSearch(tester).rows
+ .singleWhere((row) => row.isCreate);
+ expect(add.title, 'Add machine');
+ // Not "On the other computer:", the first line of the steps, cut off there.
+ expect(add.detail, line);
+ expect(add.terminalDetail, line);
+ expect(
+ find.descendant(
+ of: find.byKey(ValueKey(add.id)),
+ matching: find.text(line, findRichText: true),
+ ),
+ findsWidgets,
+ );
+ await selectResource(tester, add.id);
+ await tester.pumpAndSettle();
+ for (final step in [
+ 'On the other computer:',
+ '1. Install the app or CLI.',
+ '2. Sign in to the same account.',
+ 'It appears here and connects on its own.',
+ ]) {
+ expect(find.text(step), findsOneWidget, reason: step);
+ }
+ },
+ );
+
testWidgets('a sign-out that fails leaves the machine record alone', (
tester,
) async {
diff --git a/desktop/test/new_harness_box_test.dart b/desktop/test/new_harness_box_test.dart
index df9f4df75..6106a469f 100644
--- a/desktop/test/new_harness_box_test.dart
+++ b/desktop/test/new_harness_box_test.dart
@@ -779,7 +779,7 @@ void main() {
commandsOnly: true,
commands: () => [
command('agent.new', 'New Harness'),
- command('app.settings', 'Customize Harness'),
+ command('app.settings', 'Settings'),
command('pane.zoom', 'Zoom pane'),
],
recentCommands: () => history.recentCommands,
diff --git a/desktop/test/settings_screen_test.dart b/desktop/test/settings_screen_test.dart
index 8ae7c93f4..d89f37c88 100644
--- a/desktop/test/settings_screen_test.dart
+++ b/desktop/test/settings_screen_test.dart
@@ -133,13 +133,22 @@ void main() {
find.byKey(const Key('terminal-font-family-dropdown')),
findsNothing,
);
- // Appearance (was Customize) still opens the workspace's Customize Harness panel.
+ // Appearance (was Customize) opens the workspace's panel, which is called Appearance too.
await tester.tap(find.text('Appearance'));
await tester.pumpAndSettle();
expect(find.byType(SettingsScreen), findsNothing);
expect(find.byType(Placeholder), findsOneWidget);
expect(find.byType(HarnessCustomizePane), findsOneWidget);
- for (final label in ['Status', 'Appearance', 'Terminal']) {
+ expect(
+ find.descendant(
+ of: find.byType(HarnessCustomizePane),
+ matching: find.text('Appearance'),
+ ),
+ findsOneWidget,
+ reason: 'its title, and no tab of the same name under it',
+ );
+ expect(find.text('Customize Harness'), findsNothing);
+ for (final label in ['Status', 'Workspace', 'Terminal']) {
expect(find.text(label), findsOneWidget);
}
await tester.tap(find.byKey(const ValueKey('customize-appearance')));
@@ -386,6 +395,24 @@ void main() {
expect(find.text('GENERAL'), findsOneWidget);
expect(find.text('AGENTS'), findsNothing);
+ // Appearance by what its panel holds, and by its old name.
+ for (final query in ['wallpaper', 'customize']) {
+ await tester.enterText(
+ find.byKey(const Key('settings-search-field')),
+ query,
+ );
+ await tester.pumpAndSettle();
+ expect(
+ find.descendant(
+ of: find.byType(SettingsNav),
+ matching: find.text('Appearance'),
+ ),
+ findsOneWidget,
+ reason: query,
+ );
+ expect(find.text('Keyboard shortcuts'), findsNothing, reason: query);
+ }
+
await tester.enterText(
find.byKey(const Key('settings-search-field')),
'zzz',
diff --git a/desktop/test/settings_section_test.dart b/desktop/test/settings_section_test.dart
index 68ff6d8c9..321acec2b 100644
--- a/desktop/test/settings_section_test.dart
+++ b/desktop/test/settings_section_test.dart
@@ -70,6 +70,24 @@ void main() {
expect(SettingsSection.customize.label, 'Appearance');
});
+ test('Appearance is found by its old name and by what its panel holds', () {
+ for (final query in [
+ 'appear',
+ 'customize',
+ 'workspace',
+ 'wallpaper',
+ 'theme',
+ 'palette',
+ 'font',
+ ]) {
+ expect(SettingsSection.customize.matches(query), isTrue, reason: query);
+ }
+ expect(SettingsSection.customize.matches('notif'), isFalse);
+ // A row with no keywords is found by its label alone.
+ expect(SettingsSection.notifications.matches('notif'), isTrue);
+ expect(SettingsSection.notifications.matches('customize'), isFalse);
+ });
+
test('nothing in Settings is a thing that lives elsewhere', () {
expect(
SettingsSection.values.map((s) => s.name),
diff --git a/desktop/test/workspace_account_test.dart b/desktop/test/workspace_account_test.dart
index b8f7cc040..4b1d43dcf 100644
--- a/desktop/test/workspace_account_test.dart
+++ b/desktop/test/workspace_account_test.dart
@@ -360,7 +360,7 @@ void main() {
expect(find.text('[email protected]'), findsOneWidget);
final rows = [
'Add Phone',
- 'Customize Harness',
+ 'Appearance',
'Notifications',
'Settings',
'Sign out',
@@ -452,7 +452,7 @@ void main() {
'no name says its email once', (tester) async {
await _mountMenu(tester, name: '', showAddPhone: false);
expect(find.text('Add Phone'), findsNothing);
- expect(find.text('Customize Harness'), findsOneWidget);
+ expect(find.text('Appearance'), findsOneWidget);
expect(find.text('[email protected]'), findsOneWidget);
await tester.sendKeyEvent(LogicalKeyboardKey.escape);
await tester.pump();
diff --git a/docs/keyboard.md b/docs/keyboard.md
index fd0dfa8c6..43201baf9 100644
--- a/docs/keyboard.md
+++ b/docs/keyboard.md
@@ -31,7 +31,7 @@ The defaults, in the workspace:
| ⌘I | Models — subscriptions, local models, shared models, and APIs |
| ⇧⌘L | Layout palette |
| ⌘F · ⌘G · ⇧⌘G | Find in terminal · next · previous match |
-| ⇧⌘F / Ctrl+Alt+F (Linux) / Alt+Shift+F (browser) | Toggle inactive pane shading. Off by default; also available in Customize Harness → Appearance |
+| ⇧⌘F / Ctrl+Alt+F (Linux) / Alt+Shift+F (browser) | Toggle inactive pane shading. Off by default; also available in Appearance → Workspace |
| ⇧⌘I | Harnesses needing input |
| ⌘, · ⌘/ | Settings · keyboard shortcuts |
@@ -64,7 +64,7 @@ JSONC: `{ "version": 1, "bindings": [{ "keys": "cmd+k cmd+l", "command": "pane.f
whole prefix; `when` is `workspace`, `terminal` or `picker`. The file is watched and reloaded on save;
a bad edit keeps the last good keymap and says what was wrong. **Keyboard shortcuts (⌘/)** lists the
effective bindings in searchable groups. Select a row and press Return to practice it without
-executing the action. The popup follows Customize Harness ▸ Terminal for its font and size.
+executing the action. The popup follows Appearance ▸ Terminal for its font and size.
**Edit keyboard shortcuts** opens a commented config template with every command id.
In both modes of the box the line is a readline: ⌃A ⌃E ⌃F ⌃B and ⌥←/→ move, ⌃W kills a word (stopping at `/`), ⌃U kills to the start, ⌃H and ⌃D delete a character each way, ⌃Y puts the last kill back. ⌃N/⌃J and ⌃P/⌃K move the highlight — ⌃K is "previous", as in fzf, not kill-line — ⌃M is Return and ⌃[ or ⌃G is Escape. Every entry of the box's bottom line is also a button.