Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

fix(provider): reject startup on listen errors (#2171)

0xken15fb4203cedc8b
diff --git a/provider/example-provider/src/server.spec.ts b/provider/example-provider/src/server.spec.ts
index ad5b76291..ec36b04bf 100644
--- a/provider/example-provider/src/server.spec.ts
+++ b/provider/example-provider/src/server.spec.ts
@@ -15,7 +15,7 @@ import { chmodSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import type { AddressInfo } from 'node:net'
-import { createProviderServer } from './server.js'
+import { createProviderServer, start } from './server.js'
import { projectDir } from './jsonl.js'
import type { Config } from './config.js'
import type { ProviderEvent } from './types.js'
@@ -163,6 +163,24 @@ beforeAll(() => {
})
afterAll(() => rmSync(ROOT, { recursive: true, force: true }))
+describe('startup', () => {
+ let running: Awaited<ReturnType<typeof start>>
+ beforeAll(async () => {
+ running = await start(config(fakeClaude('claude-startup.sh', [resultLine()])))
+ })
+ afterAll(async () => { await running.close() })
+
+ it('resolves with a reachable server on an available port', async () => {
+ const { agents } = await rpc<{ agents: Array<{ id: string }> }>(Number(new URL(running.url).port), 'agent.list', {})
+ expect(agents.map((agent) => agent.id)).toEqual(['scratch', 'agent-2'])
+ })
+
+ it('rejects when the requested port is already in use', async () => {
+ await expect(start(config('unused-claude'), Number(new URL(running.url).port)))
+ .rejects.toMatchObject({ code: 'EADDRINUSE' })
+ }, 1_000)
+})
+
describe('agents', () => {
it('serves no descriptor — there is nothing to discover', async () => {
await withServer(fakeClaude('claude-desc.sh', [resultLine()]), async (port) => {
diff --git a/provider/example-provider/src/server.ts b/provider/example-provider/src/server.ts
index f5a9ab010..1beb3aa8d 100644
--- a/provider/example-provider/src/server.ts
+++ b/provider/example-provider/src/server.ts
@@ -471,8 +471,11 @@ function readBody(req: IncomingMessage): Promise<string> {
export function start(config = loadConfig(), port = config.port): Promise<{ url: string; close: () => Promise<void> }> {
const { server } = createProviderServer(config)
- return new Promise((resolve) => {
+ return new Promise((resolve, reject) => {
+ // An occupied port must reject startup rather than escape as an uncaught server error.
+ server.once('error', reject)
server.listen(port, '127.0.0.1', () => {
+ server.off('error', reject)
const addr = server.address()
const url = `http://127.0.0.1:${typeof addr === 'object' && addr ? addr.port : port}`
resolve({ url, close: () => new Promise<void>((r) => server.close(() => r())) })
diff --git a/provider/reference-provider/src/server.spec.ts b/provider/reference-provider/src/server.spec.ts
index 7b645f39c..869d87bf4 100644
--- a/provider/reference-provider/src/server.spec.ts
+++ b/provider/reference-provider/src/server.spec.ts
@@ -63,6 +63,12 @@ const send = async (text: string, extra: Record<string, unknown> = {}): Promise<
const kinds = (events: Event[]): string[] => events.map((e) => e.kind ?? '(none)')
const TERMINAL = ['turn_completed', 'turn_failed', 'turn_cancelled', 'turn_input_required']
+describe('startup', () => {
+ it('rejects when the requested port is already in use', async () => {
+ await expect(start(Number(new URL(base).port))).rejects.toMatchObject({ code: 'EADDRINUSE' })
+ }, 1_000)
+})
+
describe('there is nothing to discover', () => {
it('serves no descriptor — one URL, one credential header, eight methods', async () => {
// The endpoint that used to exist is gone rather than deprecated: a client that still fetches it
diff --git a/provider/reference-provider/src/server.ts b/provider/reference-provider/src/server.ts
index e156940da..409ee82d9 100644
--- a/provider/reference-provider/src/server.ts
+++ b/provider/reference-provider/src/server.ts
@@ -313,7 +313,14 @@ function sendError(res: ServerResponse, id: RpcRequest['id'], code: ErrorCode, m
export async function start(port = 0): Promise<ProviderServer> {
const store = new Store()
const server = createProviderServer(store)
- await new Promise<void>((r) => server.listen(port, '127.0.0.1', r))
+ await new Promise<void>((resolve, reject) => {
+ // An occupied port must reject startup rather than escape as an uncaught server error.
+ server.once('error', reject)
+ server.listen(port, '127.0.0.1', () => {
+ server.off('error', reject)
+ resolve()
+ })
+ })
const addr = server.address()
const url = `http://127.0.0.1:${typeof addr === 'object' && addr ? addr.port : port}`
return { server, store, url, close: () => new Promise<void>((r) => server.close(() => r())) }