Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

Desktop: Add Phone stays in the avatar's menu (#1209)

Deefca7da060019
diff --git a/desktop/design/workspace-status-bar.md b/desktop/design/workspace-status-bar.md
index 96b63fcf7..147fb9c62 100644
--- a/desktop/design/workspace-status-bar.md
+++ b/desktop/design/workspace-status-bar.md
@@ -25,7 +25,7 @@ tooltip, and the row's last control is the account's. While this computer
holds no account that is **Sign in**, the only control in the row with a word
and a fill; it opens the sign-in over the workspace. Signed in, the same place
is the account's initial in a circle, and a click opens a short menu: who is
-signed in, then Add Phone (until the account has a phone), Appearance,
+signed in, then Add Phone, Appearance,
Notifications, Settings and Sign out, each opening what the app already has.
Nothing is drawn between the icons and the account control; `controlGap`
separates them. A narrow window drops Devices first; the account control
diff --git a/desktop/lib/screens/swarm_screen.dart b/desktop/lib/screens/swarm_screen.dart
index 0969f5767..4651f29a3 100644
--- a/desktop/lib/screens/swarm_screen.dart
+++ b/desktop/lib/screens/swarm_screen.dart
@@ -2963,43 +2963,17 @@ class _SwarmScreenState extends State<SwarmScreen> {
/// Sign in: the sign-in screen, over the desk (`showSignInSheet`).
Future<void> _signIn() => _dialog(() => showSignInSheet(context, app));
- /// Whether the account has a phone already, as last read: Add Phone leaves
- /// the menu then. Unknown shows it.
- bool? _accountHasPhone;
- String? _accountPhoneOwner;
-
- Future<void> _readAccountPhone() async {
- // No daemon to ask under test, and a request that never ends.
- if (kUnderTest || app.isGuest) return;
- final owner = app.currentUser?.email;
- try {
- final devices = await app.loadDevices();
- if (!mounted || devices == null) return;
- _accountHasPhone = devices.devices.any(
- (device) => !device.isMachine && !device.self,
- );
- _accountPhoneOwner = owner;
- } catch (_) {
- // Unread, the row stays: it costs nothing to offer.
- }
- }
-
/// The avatar's menu (`widgets/account_menu.dart`). Its rows open what the
/// app already has, once the menu itself has closed: a [_dialog] made from
/// inside one is refused.
Future<void> _showAccountMenu() async {
final user = app.currentUser;
- final hasPhone =
- _accountPhoneOwner == user?.email && _accountHasPhone == true;
- // For the next opening: this one must not change under the pointer.
- unawaited(_readAccountPhone());
AccountMenuChoice? choice;
await _dialog(() async {
choice = await showAccountMenu(
context,
name: user?.name ?? '',
email: user?.email ?? '',
- showAddPhone: !hasPhone,
topInset: _native ? 0 : _tabBarHeight,
);
});
@@ -3007,7 +2981,6 @@ class _SwarmScreenState extends State<SwarmScreen> {
switch (choice) {
case AccountMenuChoice.addPhone:
await _addPhone();
- unawaited(_readAccountPhone());
case AccountMenuChoice.customize:
await _customize();
case AccountMenuChoice.notifications:
diff --git a/desktop/lib/widgets/account_menu.dart b/desktop/lib/widgets/account_menu.dart
index 2bc4d6249..ef16967c6 100644
--- a/desktop/lib/widgets/account_menu.dart
+++ b/desktop/lib/widgets/account_menu.dart
@@ -26,17 +26,11 @@ Future<AccountMenuChoice?> showAccountMenu(
BuildContext context, {
required String name,
required String email,
- bool showAddPhone = true,
double topInset = 0,
}) => showAppDialog<AccountMenuChoice>(
context: context,
veilTint: Colors.transparent,
- builder: (_) => AccountMenu(
- name: name,
- email: email,
- showAddPhone: showAddPhone,
- topInset: topInset,
- ),
+ builder: (_) => AccountMenu(name: name, email: email, topInset: topInset),
);
class AccountMenu extends StatefulWidget {
@@ -44,16 +38,12 @@ class AccountMenu extends StatefulWidget {
super.key,
required this.name,
required this.email,
- this.showAddPhone = true,
this.topInset = 0,
});
/// As the account gives it; empty when it has only an email.
final String name;
final String email;
-
- /// Whether Add Phone is offered: not once the account has a phone.
- final bool showAddPhone;
final double topInset;
static const width = 264.0;
@@ -65,9 +55,11 @@ class AccountMenu extends StatefulWidget {
class _AccountMenuState extends State<AccountMenu> {
final _focus = FocusNode(debugLabel: 'Account menu');
- late final _rows = [
- if (widget.showAddPhone)
- (AccountMenuChoice.addPhone, AppIcons.smartphone, 'Add Phone'),
+ // Add Phone stays once the account has a phone: a second one is added the
+ // same way, and a row that was there at the first opening and gone at the
+ // next read as a fault (1.2.64 learned of the phone only when the menu opened).
+ static const _rows = [
+ (AccountMenuChoice.addPhone, AppIcons.smartphone, 'Add Phone'),
(AccountMenuChoice.customize, AppIcons.palette, 'Appearance'),
(AccountMenuChoice.notifications, AppIcons.bell, 'Notifications'),
(AccountMenuChoice.settings, AppIcons.settings, 'Settings'),
diff --git a/desktop/test/workspace_account_test.dart b/desktop/test/workspace_account_test.dart
index 4b1d43dcf..5c7296a44 100644
--- a/desktop/test/workspace_account_test.dart
+++ b/desktop/test/workspace_account_test.dart
@@ -45,7 +45,6 @@ Future<void> _mountMenu(
WidgetTester tester, {
String name = 'Dee Example',
String email = '[email protected]',
- bool showAddPhone = true,
void Function(AccountMenuChoice?)? onChoice,
}) async {
tester.view.devicePixelRatio = 1;
@@ -63,7 +62,6 @@ Future<void> _mountMenu(
context,
name: name,
email: email,
- showAddPhone: showAddPhone,
);
onChoice?.call(choice);
},
@@ -448,29 +446,25 @@ void main() {
expect(_menu, findsNothing);
});
- testWidgets('an account with a phone is not offered one; an account with '
- 'no name says its email once', (tester) async {
- await _mountMenu(tester, name: '', showAddPhone: false);
- expect(find.text('Add Phone'), findsNothing);
- expect(find.text('Appearance'), findsOneWidget);
+ testWidgets('an account with no name says its email once; Add Phone is '
+ 'the first row whatever the account has', (tester) async {
+ await _mountMenu(tester, name: '');
expect(find.text('[email protected]'), findsOneWidget);
+ // It was hidden once the account had a phone, which the menu learned only
+ // by being opened: there at the first click and gone at the second.
+ expect(find.text('Add Phone'), findsOneWidget);
await tester.sendKeyEvent(LogicalKeyboardKey.escape);
await tester.pump();
await tester.pump();
expect(_menu, findsNothing);
- // Down now lands on what is first.
AccountMenuChoice? chosen;
- await _mountMenu(
- tester,
- showAddPhone: false,
- onChoice: (value) => chosen = value,
- );
+ await _mountMenu(tester, onChoice: (value) => chosen = value);
await tester.sendKeyEvent(LogicalKeyboardKey.arrowDown);
await tester.pump();
await tester.sendKeyEvent(LogicalKeyboardKey.enter);
await tester.pump();
await tester.pump();
- expect(chosen, AccountMenuChoice.customize);
+ expect(chosen, AccountMenuChoice.addPhone);
});
test('the one letter an account wears', () {
diff --git a/docs/research/2026-10-08-onboarding-redesign/index.html b/docs/research/2026-10-08-onboarding-redesign/index.html
index 485b730bc..bf6c1d140 100644
--- a/docs/research/2026-10-08-onboarding-redesign/index.html
+++ b/docs/research/2026-10-08-onboarding-redesign/index.html
@@ -663,7 +663,7 @@
<b>Avatar:</b> the first letter of your name, or of your email. Its tooltip is your name and email. Not your Google or Apple photo yet: the Mac title bar is native and does not load pictures from the web.<br>
<b>Where:</b> Mac and Linux, same order. Linux keeps its bell between Search and Devices. The browser app is not changed.<br>
<b>Narrow window:</b> tabs give way first, as today; Devices is the first icon to drop; Sign in or the avatar always stays.<br>
- <b>The menu:</b> Add Phone opens Add Phone, and goes away once a phone is linked. Customize Harness opens what the app menu's Customize Harness opens. Notifications opens Settings ▸ Notifications. Settings opens Settings. Sign out signs out. Kept to these five; no machine list, no numbers.</p>
+ <b>The menu:</b> Add Phone opens Add Phone. It stays once a phone is linked (changed 2026-10-12: as built it showed at the first click and was gone at the second). Customize Harness opens what the app menu's Customize Harness opens. Notifications opens Settings ▸ Notifications. Settings opens Settings. Sign out signs out. Kept to these five; no machine list, no numbers.</p>
<h2>Checked: can it be built (2026-10-08)</h2>
<p class="note" style="font-size:15px;line-height:1.7">