Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

21.2 KB
Raw Blame
import { act, fireEvent, render, screen, waitFor, within } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import en from '../../../lib/i18n/en';
import ConnectAuthModal, { authHintMessageKey, reconnectErrorMessage } from './ConnectAuthModal';

const mockConnect = vi.fn();
const mockUpdateEnv = vi.fn();
const mockDetectAuth = vi.fn();
const mockRegistryGet = vi.fn();
const mockOauthBegin = vi.fn();
const mockStatus = vi.fn();
const mockOpenUrl = vi.fn();

vi.mock('../../../services/api/mcpClientsApi', () => ({
  mcpClientsApi: {
    connect: (...args: unknown[]) => mockConnect(...args),
    updateEnv: (...args: unknown[]) => mockUpdateEnv(...args),
    detectAuth: (...args: unknown[]) => mockDetectAuth(...args),
    registryGet: (...args: unknown[]) => mockRegistryGet(...args),
    oauthBegin: (...args: unknown[]) => mockOauthBegin(...args),
    status: (...args: unknown[]) => mockStatus(...args),
  },
}));

vi.mock('../../../utils/openUrl', () => ({
  openUrl: (...args: unknown[]) => mockOpenUrl(...args),
}));

const BASE_SERVER = {
  server_id: 'srv-1',
  qualified_name: 'acme/test-server',
  display_name: 'Test Server',
  description: 'A test MCP server',
  // HTTP-remote installs still carry a CommandKind ('node'|'python'|'binary');
  // the transport, not command_kind, is what marks them remote. Use 'node' to
  // match the type (there is no 'http' CommandKind) and the sibling mocks.
  command_kind: 'node' as const,
  command: '',
  args: [],
  env_keys: ['Authorization'],
  installed_at: 1_700_000_000,
  enabled: true,
};

// A server with no declared env keys exercises the auto-seeded custom-header row.
const NO_KEYS_SERVER = { ...BASE_SERVER, env_keys: [] as string[] };

describe('ConnectAuthModal', () => {
  beforeEach(() => {
    mockConnect.mockReset();
    mockUpdateEnv.mockReset();
    mockDetectAuth.mockReset();
    mockRegistryGet.mockReset();
    mockOauthBegin.mockReset();
    mockStatus.mockReset();
    mockOpenUrl.mockReset();
    // Benign defaults: no special auth, no extra declared keys.
    mockDetectAuth.mockResolvedValue({ kind: 'token', grant_types: [] });
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [],
      required_env_keys: [],
    });
  });

  it('renders the dialog title and an input for each declared key', async () => {
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    expect(await screen.findByRole('dialog')).toBeInTheDocument();
    expect(screen.getByText('Connect Test Server')).toBeInTheDocument();
    // Declared key from env_keys gets a labelled secret input.
    expect(screen.getByLabelText('Authorization')).toBeInTheDocument();
  });

  it('merges registry-declared required keys into the field list', async () => {
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [],
      required_env_keys: ['X-API-Key'],
    });
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    // Field appears once the best-effort registry_get resolves.
    expect(await screen.findByLabelText('X-API-Key')).toBeInTheDocument();
    // Original install key is still present.
    expect(screen.getByLabelText('Authorization')).toBeInTheDocument();
  });

  it('toggles secret visibility on Show/Hide', async () => {
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    const input = (await screen.findByLabelText('Authorization')) as HTMLInputElement;
    expect(input.type).toBe('password');
    fireEvent.click(screen.getAllByRole('button', { name: 'Show' })[0]);
    expect(input.type).toBe('text');
  });

  it('renders a Bearer/None scheme select for declared keys', async () => {
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByLabelText('Authorization');
    // Authorization defaults to the Bearer scheme.
    const selects = screen.getAllByRole('combobox');
    expect(selects.length).toBeGreaterThan(0);
    expect((selects[0] as HTMLSelectElement).value).toBe('bearer');
    fireEvent.change(selects[0], { target: { value: 'raw' } });
    expect((selects[0] as HTMLSelectElement).value).toBe('raw');
  });

  it('seeds a custom-header row when the server declares no keys', async () => {
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByRole('dialog');
    // Auto-seeded row pre-fills the header name "Authorization".
    await waitFor(() => {
      expect(screen.getByDisplayValue('Authorization')).toBeInTheDocument();
    });
  });

  it('adds and removes custom header rows', async () => {
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByRole('dialog');
    fireEvent.click(screen.getByRole('button', { name: '+ Add header' }));
    expect(screen.getByPlaceholderText('Header name')).toBeInTheDocument();
    fireEvent.click(screen.getByRole('button', { name: 'Remove header' }));
    await waitFor(() => {
      expect(screen.queryByPlaceholderText('Header name')).not.toBeInTheDocument();
    });
  });

  it('connects with no auth supplied (plain connect path) and fires onConnected', async () => {
    const tools = [{ name: 'read_file', description: 'reads', input_schema: {} }];
    mockConnect.mockResolvedValue({ server_id: 'srv-1', status: 'connected', tools });
    const onConnected = vi.fn();
    const onClose = vi.fn();
    render(<ConnectAuthModal server={BASE_SERVER} onClose={onClose} onConnected={onConnected} />);
    const dialog = await screen.findByRole('dialog');
    await act(async () => {
      fireEvent.click(within(dialog).getByRole('button', { name: 'Connect' }));
    });
    await waitFor(() => {
      expect(mockConnect).toHaveBeenCalledWith('srv-1');
      expect(onConnected).toHaveBeenCalledWith(tools);
      expect(onClose).toHaveBeenCalled();
    });
    expect(mockUpdateEnv).not.toHaveBeenCalled();
  });

  it('persists supplied credentials via update_env (with Bearer scheme applied)', async () => {
    const tools = [{ name: 't', input_schema: {} }];
    mockUpdateEnv.mockResolvedValue({
      server_id: 'srv-1',
      status: 'connected',
      env_keys: ['Authorization'],
      tools,
    });
    const onConnected = vi.fn();
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={onConnected} />);
    const input = await screen.findByLabelText('Authorization');
    fireEvent.change(input, { target: { value: 'tok-123' } });
    await act(async () => {
      fireEvent.click(screen.getByRole('button', { name: 'Connect' }));
    });
    await waitFor(() => {
      expect(mockUpdateEnv).toHaveBeenCalledWith({
        server_id: 'srv-1',
        // Bearer scheme prepends "Bearer " to the Authorization value.
        env: { Authorization: 'Bearer tok-123' },
      });
      expect(onConnected).toHaveBeenCalledWith(tools);
    });
    expect(mockConnect).not.toHaveBeenCalled();
  });

  it('shows an error when update_env reconnect does not reach connected', async () => {
    mockUpdateEnv.mockResolvedValue({
      server_id: 'srv-1',
      status: 'disconnected',
      env_keys: ['Authorization'],
      error: 'bad token',
    });
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    const input = await screen.findByLabelText('Authorization');
    fireEvent.change(input, { target: { value: 'tok' } });
    await act(async () => {
      fireEvent.click(screen.getByRole('button', { name: 'Connect' }));
    });
    await waitFor(() => {
      expect(screen.getByText('bad token')).toBeInTheDocument();
    });
  });

  it('shows an error when connect rejects', async () => {
    mockConnect.mockRejectedValue(new Error('Connection refused'));
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    const dialog = await screen.findByRole('dialog');
    await act(async () => {
      fireEvent.click(within(dialog).getByRole('button', { name: 'Connect' }));
    });
    await waitFor(() => {
      expect(screen.getByText('Connection refused')).toBeInTheDocument();
    });
  });

  it('shows the OAuth sign-in section when detectAuth reports oauth', async () => {
    mockDetectAuth.mockResolvedValue({
      kind: 'oauth',
      authorization_endpoint: 'https://auth.example/authorize',
      grant_types: ['authorization_code'],
    });
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    expect(await screen.findByRole('button', { name: 'Sign in with browser' })).toBeInTheDocument();
  });

  it('OAuth sign-in opens the authorize URL and connects once status flips', async () => {
    mockDetectAuth.mockResolvedValue({ kind: 'oauth', grant_types: ['authorization_code'] });
    mockOauthBegin.mockResolvedValue('https://auth.example/authorize?x=1');
    mockOpenUrl.mockResolvedValue(undefined);
    // First status poll already reports connected, so we skip the timer path.
    mockStatus.mockResolvedValue([{ server_id: 'srv-1', status: 'connected', tool_count: 1 }]);
    const tools = [{ name: 'read_file', input_schema: {} }];
    mockConnect.mockResolvedValue({ server_id: 'srv-1', status: 'connected', tools });
    const onConnected = vi.fn();
    const onClose = vi.fn();
    render(<ConnectAuthModal server={BASE_SERVER} onClose={onClose} onConnected={onConnected} />);
    const signIn = await screen.findByRole('button', { name: 'Sign in with browser' });
    await act(async () => {
      fireEvent.click(signIn);
    });
    await waitFor(() => {
      expect(mockOauthBegin).toHaveBeenCalledWith('srv-1');
      expect(mockOpenUrl).toHaveBeenCalledWith('https://auth.example/authorize?x=1');
      expect(mockConnect).toHaveBeenCalledWith('srv-1');
      expect(onConnected).toHaveBeenCalledWith(tools);
      expect(onClose).toHaveBeenCalled();
    });
  });

  it('surfaces an OAuth begin failure as an error', async () => {
    mockDetectAuth.mockResolvedValue({ kind: 'oauth', grant_types: ['authorization_code'] });
    mockOauthBegin.mockRejectedValue(new Error('discovery failed'));
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    const signIn = await screen.findByRole('button', { name: 'Sign in with browser' });
    await act(async () => {
      fireEvent.click(signIn);
    });
    await waitFor(() => {
      expect(screen.getByText('discovery failed')).toBeInTheDocument();
    });
  });

  it('closes via the Cancel button', async () => {
    const onClose = vi.fn();
    render(<ConnectAuthModal server={BASE_SERVER} onClose={onClose} onConnected={() => {}} />);
    await screen.findByRole('dialog');
    fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
    expect(onClose).toHaveBeenCalled();
  });

  it('closes on Escape', async () => {
    const onClose = vi.fn();
    render(<ConnectAuthModal server={BASE_SERVER} onClose={onClose} onConnected={() => {}} />);
    const dialog = await screen.findByRole('dialog');
    // Migrated onto the shared `ModalShell` / Radix `Dialog` (#radix-ui-foundation):
    // dismissal is now Escape or backdrop pointerdown-outside rather than a
    // manual mousedown-on-self handler, so this exercises the Radix
    // escape-key path instead of firing mousedown directly on the dialog role
    // element (which is now the Content, not the old full-screen backdrop div).
    fireEvent.keyDown(dialog, { key: 'Escape' });
    expect(onClose).toHaveBeenCalled();
  });

  it('falls back to token fields when detectAuth throws', async () => {
    mockDetectAuth.mockRejectedValue(new Error('probe failed'));
    render(<ConnectAuthModal server={BASE_SERVER} onClose={() => {}} onConnected={() => {}} />);
    // Non-fatal: the modal still renders and shows the declared key field.
    expect(await screen.findByLabelText('Authorization')).toBeInTheDocument();
  });

  it('renders a declared field from config_schema with a linkified description', async () => {
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [
        {
          type: 'http',
          config_schema: {
            properties: {
              'X-API-Key': {
                description: 'AnomalyArmor key. Generate at https://app.anomalyarmor.ai/api-key',
                'x-secret': true,
              },
            },
            required: ['X-API-Key'],
          },
        },
      ],
      required_env_keys: [],
    });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    // The exact declared key is rendered as a labelled input…
    expect(await screen.findByLabelText('X-API-Key')).toBeInTheDocument();
    // …with its description, and the "get your key" URL becomes a clickable link.
    expect(screen.getByText(/Generate at/)).toBeInTheDocument();
    fireEvent.click(screen.getByRole('button', { name: 'https://app.anomalyarmor.ai/api-key' }));
    expect(mockOpenUrl).toHaveBeenCalledWith('https://app.anomalyarmor.ai/api-key');
  });

  it('linkifies a bare-domain "get your key" hint (no scheme) and opens it as https', async () => {
    // Registry copy often omits the scheme (e.g. the Apify-hosted GitHub server's
    // "Free tier at console.apify.com"). The bare domain must still be a clickable
    // link, or the user has no idea where the token comes from.
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [
        {
          type: 'http',
          config_schema: {
            properties: {
              'X-API-Key': {
                description: 'Apify API token. Free tier at console.apify.com',
                'x-secret': true,
              },
            },
            required: ['X-API-Key'],
          },
        },
      ],
      required_env_keys: [],
    });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByLabelText('X-API-Key');
    // The ↗ affordance is aria-hidden, so the link's accessible name is the
    // bare domain; clicking opens it with an https scheme prepended.
    const link = screen.getByRole('button', { name: 'console.apify.com' });
    fireEvent.click(link);
    expect(mockOpenUrl).toHaveBeenCalledWith('https://console.apify.com');
  });

  it('surfaces the HTTP-remote provider host up front and links to the provider site', async () => {
    // A server that declares no auth schema but has a hosted endpoint: name the
    // provider before the user clicks Connect and eats a 401 just to learn it.
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [{ type: 'http', deployment_url: 'https://mcp.lona.agency/mcp' }],
      required_env_keys: [],
    });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByRole('dialog');
    const host = await screen.findByRole('button', { name: 'mcp.lona.agency' });
    fireEvent.click(host);
    // Links to the provider's site (leading `mcp.` dropped), not the raw endpoint.
    expect(mockOpenUrl).toHaveBeenCalledWith('https://lona.agency');
  });

  it('does not linkify file-like tokens in a description', async () => {
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [
        {
          type: 'http',
          config_schema: {
            properties: {
              'X-API-Key': {
                description: 'Put the key in config.json, then visit example.com',
                'x-secret': true,
              },
            },
            required: ['X-API-Key'],
          },
        },
      ],
      required_env_keys: [],
    });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByLabelText('X-API-Key');
    // The real domain is a link; the filename is left as plain prose.
    expect(screen.getByRole('button', { name: 'example.com' })).toBeInTheDocument();
    expect(screen.queryByRole('button', { name: 'config.json' })).not.toBeInTheDocument();
  });

  it('does not strip a two-label provider host down to a public suffix', async () => {
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [{ type: 'http', deployment_url: 'https://server.io/mcp' }],
      required_env_keys: [],
    });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByRole('dialog');
    const host = await screen.findByRole('button', { name: 'server.io' });
    fireEvent.click(host);
    // `server.io` must stay intact — never reduced to the bare TLD `https://io`.
    expect(mockOpenUrl).toHaveBeenCalledWith('https://server.io');
  });

  it('blocks Connect until a required declared field is filled', async () => {
    mockRegistryGet.mockResolvedValue({
      qualified_name: 'acme/test-server',
      display_name: 'Test Server',
      connections: [
        {
          type: 'http',
          config_schema: {
            properties: { 'X-API-Key': { 'x-secret': true } },
            required: ['X-API-Key'],
          },
        },
      ],
      required_env_keys: [],
    });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    await screen.findByLabelText('X-API-Key');
    await act(async () => {
      fireEvent.click(screen.getByRole('button', { name: 'Connect' }));
    });
    // A clear, per-field error — not a silent failed connect.
    await waitFor(() => {
      expect(screen.getByText('"X-API-Key" is required')).toBeInTheDocument();
    });
    expect(mockUpdateEnv).not.toHaveBeenCalled();
    expect(mockConnect).not.toHaveBeenCalled();
  });

  it('does not seed a token box for OAuth servers', async () => {
    mockDetectAuth.mockResolvedValue({ kind: 'oauth', grant_types: ['authorization_code'] });
    render(<ConnectAuthModal server={NO_KEYS_SERVER} onClose={() => {}} onConnected={() => {}} />);
    // OAuth servers get a sign-in button and no auto-seeded Authorization row —
    // pasting a token there is exactly what fails (e.g. a GitHub PAT vs OAuth).
    await screen.findByRole('button', { name: 'Sign in with browser' });
    expect(screen.queryByDisplayValue('Authorization')).not.toBeInTheDocument();
  });
});

// A `t` that resolves against the real English bundle, so these tests also prove
// the three new `mcp.connectAuth.authError.*` keys actually exist in en.ts.
const tEn = (key: string): string => (en as Record<string, string>)[key] ?? key;

describe('authHintMessageKey (#4289)', () => {
  it('maps each core auth_hint code to its i18n key', () => {
    expect(authHintMessageKey('oauth_required')).toBe('mcp.connectAuth.authError.oauthRequired');
    expect(authHintMessageKey('token_rejected')).toBe('mcp.connectAuth.authError.tokenRejected');
    expect(authHintMessageKey('credential_required')).toBe(
      'mcp.connectAuth.authError.credentialRequired'
    );
  });

  it('returns null for an unknown or absent code', () => {
    expect(authHintMessageKey('something_else')).toBeNull();
    expect(authHintMessageKey(undefined)).toBeNull();
  });

  it('every mapped key resolves to non-placeholder English copy', () => {
    for (const code of ['oauth_required', 'token_rejected', 'credential_required']) {
      const key = authHintMessageKey(code);
      expect(key).not.toBeNull();
      const copy = tEn(key as string);
      expect(copy).not.toBe(key); // resolved, not echoed back
      expect(copy.length).toBeGreaterThan(0);
    }
  });
});

describe('reconnectErrorMessage (#4289)', () => {
  it('returns null when the reconnect actually connected', () => {
    expect(reconnectErrorMessage({ status: 'connected' }, tEn)).toBeNull();
  });

  it('OAuth-only 401 → "use Sign in" copy, never the raw message', () => {
    const msg = reconnectErrorMessage({ status: 'unauthorized', auth_hint: 'oauth_required' }, tEn);
    expect(msg).toBe(tEn('mcp.connectAuth.authError.oauthRequired'));
  });

  it('rejected static token 401 → token-rejected copy', () => {
    const msg = reconnectErrorMessage({ status: 'unauthorized', auth_hint: 'token_rejected' }, tEn);
    expect(msg).toBe(tEn('mcp.connectAuth.authError.tokenRejected'));
  });

  it('401 with no/unknown hint falls back to generic reconnect copy', () => {
    // Missing hint…
    expect(reconnectErrorMessage({ status: 'unauthorized' }, tEn)).toBe(
      tEn('mcp.connectAuth.reconnectFailed')
    );
    // …and an unrecognized code (forward-compat with a future core reason).
    expect(
      reconnectErrorMessage({ status: 'unauthorized', auth_hint: 'brand_new_reason' }, tEn)
    ).toBe(tEn('mcp.connectAuth.reconnectFailed'));
  });

  it('a generic (non-401) failure surfaces its own message', () => {
    expect(reconnectErrorMessage({ status: 'disconnected', error: 'timed out' }, tEn)).toBe(
      'timed out'
    );
  });

  it('a non-401 failure with no message falls back to generic copy', () => {
    expect(reconnectErrorMessage({ status: 'disconnected' }, tEn)).toBe(
      tEn('mcp.connectAuth.reconnectFailed')
    );
  });
});