Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

30.4 KB
Raw Blame
/**
 * ConnectAuthModal — opened when the user clicks "Connect"/"Sign in" on an
 * installed MCP server. It renders the auth the *server itself declares*, so
 * each server asks for exactly what it needs instead of a one-size-fits-all box:
 *
 *   • OAuth — when a live probe (`detect_auth`) sees a browser sign-in
 *     challenge, we show a single "Sign in" button and no token field.
 *   • Declared fields — the registry's `connections[].config_schema` lists each
 *     required input by name (`Authorization`, `X-API-Key`, `GITHUB_TOKEN`, …)
 *     with a human description that often carries a "get your key at <url>"
 *     link. We render one labelled (secret) input per field and linkify the URL.
 *   • Custom headers — a free-form fallback for mislabelled remotes that declare
 *     no auth but still want a header (kept behind the declared fields).
 *
 * Only fields the server marks `required` or `isSecret` are shown; pure config
 * (log level, port…) is left to the server's defaults. On submit, non-empty
 * values persist via `update_env` (stored encrypted, then reconnect); for
 * HTTP-remote installs each entry becomes a request header (core
 * `build_http_auth`). With nothing supplied we just connect — open servers need
 * no auth.
 */
import debug from 'debug';
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useT } from '../../../lib/i18n/I18nContext';
import { mcpClientsApi } from '../../../services/api/mcpClientsApi';
import { openUrl } from '../../../utils/openUrl';
import Button from '../../ui/Button';
import { ModalShell } from '../../ui/ModalShell';
import NativeSelect from '../../ui/NativeSelect';
import TextField from '../../ui/TextField';
import type { InstalledServer, McpTool, SmitheryServerDetail } from './types';

const log = debug('mcp-clients:connect-auth');

interface ConnectAuthModalProps {
  server: InstalledServer;
  onClose: () => void;
  /** Called with the connected server's tools once connect succeeds. */
  onConnected: (tools: McpTool[]) => void;
}

/** An auth input the server declares it needs. */
interface AuthField {
  /** Header or env-var name, e.g. `Authorization`, `X-API-Key`, `GITHUB_TOKEN`. */
  name: string;
  /** Human hint from the registry (may contain a "get your key" URL). */
  description?: string;
  /** Masked input + never echoed back. */
  secret: boolean;
  /** Must be supplied (unless already stored on the install). */
  required: boolean;
}

interface CustomHeader {
  id: number;
  name: string;
  value: string;
  /** `bearer` prepends `Bearer ` to the value (the common case); `raw` sends
   * the value verbatim (for API-key headers or other schemes). */
  scheme: 'bearer' | 'raw';
}

/** Apply a header scheme to a value: `bearer` prepends `Bearer ` unless the
 * value already carries a scheme; `raw` is verbatim. */
const applyScheme = (scheme: 'bearer' | 'raw', value: string): string => {
  const v = value.trim();
  if (!v) return v;
  if (scheme === 'bearer' && !/^bearer\s/i.test(v)) return `Bearer ${v}`;
  return v;
};

/** Map a core `auth_hint` reason code (returned by `update_env` on a 401) to its
 * i18n key, so the user sees what to DO rather than an opaque "connect failed":
 *   • `oauth_required`      → use the browser Sign-in (a pasted token won't work)
 *   • `token_rejected`      → the token was wrong/expired
 *   • `credential_required` → auth is needed but none was provided
 * Returns `null` for an unknown/absent code so the caller falls back to generic
 * copy. Exported for unit testing. (#4289) */
export const authHintMessageKey = (code: string | undefined): string | null => {
  switch (code) {
    case 'oauth_required':
      return 'mcp.connectAuth.authError.oauthRequired';
    case 'token_rejected':
      return 'mcp.connectAuth.authError.tokenRejected';
    case 'credential_required':
      return 'mcp.connectAuth.authError.credentialRequired';
    default:
      return null;
  }
};

/** Derive the error string to show after an `update_env` reconnect, or `null`
 * when it actually connected. A 401 (`status === 'unauthorized'`) maps to the
 * actionable `auth_hint` copy — the raw 401 message is withheld server-side, so
 * we never show it; any other non-connected status surfaces its message (or a
 * generic fallback). Pure + exported so the branch is unit-tested without a full
 * modal render. (#4289) */
export const reconnectErrorMessage = (
  result: { status: string; auth_hint?: string; error?: string },
  t: (key: string) => string
): string | null => {
  if (result.status === 'connected') return null;
  if (result.status === 'unauthorized') {
    const key = authHintMessageKey(result.auth_hint);
    return key ? t(key) : t('mcp.connectAuth.reconnectFailed');
  }
  return result.error ?? t('mcp.connectAuth.reconnectFailed');
};

/** Whether a field name is an `Authorization` header (offers a Bearer scheme). */
const isAuthorizationField = (name: string): boolean => name.toLowerCase() === 'authorization';

/** Merge a field into a by-name map: keep the first description/secret seen,
 * OR the `required` flag (any source marking it required wins). */
const upsertField = (map: Map<string, AuthField>, f: AuthField): void => {
  const prev = map.get(f.name);
  if (!prev) {
    map.set(f.name, f);
    return;
  }
  map.set(f.name, {
    name: f.name,
    description: prev.description ?? f.description,
    secret: prev.secret || f.secret,
    required: prev.required || f.required,
  });
};

/** Extract declared auth fields from a registry detail's connection schemas
 * (and its flattened `required_env_keys`, for back-compat). */
const fieldsFromDetail = (detail: SmitheryServerDetail): AuthField[] => {
  const map = new Map<string, AuthField>();
  for (const conn of detail.connections ?? []) {
    const schema = conn.config_schema as
      | {
          properties?: Record<string, { description?: string; 'x-secret'?: boolean }>;
          required?: string[];
        }
      | undefined;
    const props = schema?.properties;
    const required = Array.isArray(schema?.required) ? schema!.required! : [];
    if (props && typeof props === 'object') {
      for (const [name, prop] of Object.entries(props)) {
        upsertField(map, {
          name,
          description: prop?.description,
          secret: prop?.['x-secret'] === true,
          required: required.includes(name),
        });
      }
    }
  }
  for (const name of detail.required_env_keys ?? []) {
    upsertField(map, { name, secret: true, required: true });
  }
  return Array.from(map.values());
};

// Linkify the "get your key at <site>" hint registries put in field
// descriptions. Matches full http(s)/`www.` URLs AND bare domains like
// `console.apify.com` — registry copy frequently omits the scheme, and a bare
// domain rendered as grey text reads as prose, leaving the user with no idea it
// is where the token comes from. The bare-domain arm requires a 2–24 letter TLD
// so version strings (`v1.2`) and abbreviations (`e.g.`) are not linkified.
const URL_BODY =
  '(?:https?:\\/\\/|www\\.)[^\\s)]+|(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\\.)+[a-z]{2,24}(?:\\/[^\\s)]*)?';
const URL_SPLIT_RE = new RegExp(`(${URL_BODY})`, 'gi');
const URL_MATCH_RE = new RegExp(`^(?:${URL_BODY})$`, 'i');

// Common file extensions that masquerade as a bare domain (`config.json`,
// `Node.js`, `report.pdf`). A schemeless, path-less token ending in one of these
// is prose, not a link — don't turn "set this in config.json" into a dead link.
const FILE_EXT_RE =
  /\.(?:json|jsonc|ya?ml|toml|lock|md|mdx|txt|csv|tsv|pdf|docx?|xlsx?|pptx?|png|jpe?g|gif|svg|webp|ico|mp[34]|mov|zip|tar|gz|tgz|rs|js|jsx|mjs|cjs|ts|tsx|py|rb|go|java|php|c|cpp|h|hpp|sh|bash|env|ini|cfg|conf|log|html?|css|scss|sass|xml|sql)$/i;

/** Give a matched link a scheme so the OS opens it (bare domains → https). */
const withScheme = (s: string): string => (/^https?:\/\//i.test(s) ? s : `https://${s}`);

/** Whether a token matched by URL_SPLIT_RE is really a link worth rendering.
 *  Tokens with a scheme or a path are always links; a bare `name.ext` token
 *  whose extension is a known file type (`config.json`, `Node.js`) is not. */
const isLinkLike = (s: string): boolean => {
  if (!URL_MATCH_RE.test(s)) return false;
  if (/^https?:\/\//i.test(s) || s.includes('/')) return true;
  return !FILE_EXT_RE.test(s);
};

/** Host of the server's HTTP-remote endpoint, if the detail declares one — the
 *  provider the token comes from (and the host a 401 would name). */
const hostFromDetail = (detail: SmitheryServerDetail): string | null => {
  const url = detail.connections?.find(
    c => c.type === 'http' && typeof c.deployment_url === 'string' && c.deployment_url.length > 0
  )?.deployment_url;
  if (!url) return null;
  try {
    return new URL(url).host || null;
  } catch {
    return null;
  }
};

/** Best-effort signup/site URL for a provider host: drop a leading
 *  `mcp.`/`api.`/`server.`/`www.` label so `mcp.lona.agency` → the provider's
 *  site `https://lona.agency` rather than the bare MCP endpoint. Only strips
 *  when ≥2 labels remain, so a two-label host like `server.io` is never reduced
 *  to a bare public suffix (`https://io`). */
const providerUrlFromHost = (host: string): string => {
  const stripped = host.replace(/^(?:mcp|api|server|www)\./i, '');
  const safe = stripped.split('.').length >= 2 ? stripped : host;
  return `https://${safe}`;
};

/** Blank Authorization row offered as a starting point for servers that declare
 *  no auth schema. Rendered as a default rather than seeded into state from an
 *  effect (which `react-hooks/set-state-in-effect` forbids); the first edit
 *  materializes it into `customHeaders`. */
const FALLBACK_HEADER: CustomHeader = { id: 0, name: 'Authorization', value: '', scheme: 'bearer' };

const ConnectAuthModal = ({ server, onClose, onConnected }: ConnectAuthModalProps) => {
  const { t } = useT();
  const titleId = useId();
  // Declared auth fields. Seeded from the install's stored keys (names only),
  // then enriched by a best-effort registry_get that carries each field's
  // description / secret / required metadata. `__`-prefixed keys are internal
  // bookkeeping (OAuth refresh bundle) — never render them.
  const [fields, setFields] = useState<AuthField[]>(() =>
    server.env_keys
      .filter(k => !k.startsWith('__'))
      .map(name => ({ name, secret: true, required: false }))
  );
  const [values, setValues] = useState<Record<string, string>>({});
  const [reveal, setReveal] = useState<Record<string, boolean>>({});
  // Per-Authorization-field scheme (the registry gives a free-text description,
  // not Bearer-vs-raw — so the user picks). Defaults to Bearer.
  const [authSchemes, setAuthSchemes] = useState<Record<string, 'bearer' | 'raw'>>({});
  const schemeFor = useCallback(
    (name: string): 'bearer' | 'raw' =>
      authSchemes[name] ?? (isAuthorizationField(name) ? 'bearer' : 'raw'),
    [authSchemes]
  );
  const [customHeaders, setCustomHeaders] = useState<CustomHeader[]>([]);
  const [nextId, setNextId] = useState(1);
  const [busy, setBusy] = useState(false);
  const [error, setError] = useState<string | null>(null);
  // Detected auth style: drives whether we show "Sign in" (browser OAuth) vs.
  // the token/header fields. `detecting` until the probe returns.
  const [authKind, setAuthKind] = useState<'detecting' | 'none' | 'token' | 'oauth'>('detecting');
  const [oauthWaiting, setOauthWaiting] = useState(false);
  const oauthPollTimer = useRef<number | null>(null);
  const oauthCancelled = useRef(false);
  // Host of the server's HTTP-remote endpoint (from the registry detail's
  // deployment_url). Surfaced as a "get your token from this provider" hint so
  // the user learns where the credential comes from BEFORE a 401 round-trip —
  // the same host the failed-connect error reveals, shown up front.
  const [endpointHost, setEndpointHost] = useState<string | null>(null);

  // Only surface fields the server actually wants from the user: required
  // inputs and secrets. Pure config (log level, port, …) keeps server defaults.
  const visibleFields = useMemo(() => fields.filter(f => f.required || f.secret), [fields]);

  // Probe how this server authenticates so we render the right control. The
  // registry can't always tell us, so we ask the server.
  useEffect(() => {
    let cancelled = false;
    void (async () => {
      try {
        const d = await mcpClientsApi.detectAuth(server.server_id);
        if (!cancelled) setAuthKind(d.kind);
      } catch (err) {
        log('detect_auth failed (non-fatal): %s', err instanceof Error ? err.message : err);
        if (!cancelled) setAuthKind('token');
      }
    })();
    return () => {
      cancelled = true;
    };
  }, [server.server_id]);

  // Browser-OAuth: begin (discover + DCR + PKCE), open the authorize URL, then
  // poll until the /oauth/mcp/callback route has stored the token + reconnected.
  const handleOAuth = useCallback(() => {
    oauthCancelled.current = false;
    setBusy(true);
    setError(null);
    setOauthWaiting(true);
    void (async () => {
      try {
        const url = await mcpClientsApi.oauthBegin(server.server_id);
        await openUrl(url);
        const started = Date.now();
        const poll = async (): Promise<void> => {
          if (oauthCancelled.current) return;
          const statuses = await mcpClientsApi.status();
          if (oauthCancelled.current) return;
          const mine = statuses.find(s => s.server_id === server.server_id);
          if (mine?.status === 'connected') {
            const result = await mcpClientsApi.connect(server.server_id);
            onConnected(result.tools ?? []);
            onClose();
            return;
          }
          if (Date.now() - started > 180000) {
            throw new Error(t('mcp.connectAuth.oauthTimeout'));
          }
          oauthPollTimer.current = window.setTimeout(() => {
            void poll().catch(handlePollError);
          }, 2500);
        };
        const handlePollError = (err: unknown) => {
          if (oauthCancelled.current) return;
          setError(err instanceof Error ? err.message : String(err));
          setOauthWaiting(false);
          setBusy(false);
        };
        await poll().catch(handlePollError);
      } catch (err) {
        if (oauthCancelled.current) return;
        const msg = err instanceof Error ? err.message : String(err);
        log('oauth failed: %s', msg);
        setError(msg);
        setOauthWaiting(false);
        setBusy(false);
      }
    })();
  }, [server.server_id, onConnected, onClose, t]);

  const cancelOAuthWait = useCallback(() => {
    oauthCancelled.current = true;
    if (oauthPollTimer.current !== null) {
      window.clearTimeout(oauthPollTimer.current);
      oauthPollTimer.current = null;
    }
    setOauthWaiting(false);
    setBusy(false);
  }, []);

  const handleClose = useCallback(() => {
    cancelOAuthWait();
    onClose();
  }, [cancelOAuthWait, onClose]);

  useEffect(() => () => cancelOAuthWait(), [cancelOAuthWait]);

  // Best-effort: pull the registry's declared fields (names + descriptions +
  // secret/required), so a server that labels its auth shows tailored inputs.
  // Network failures are non-fatal — we keep the install's own keys.
  useEffect(() => {
    let cancelled = false;
    void (async () => {
      try {
        const detail = await mcpClientsApi.registryGet(server.qualified_name);
        if (cancelled) return;
        setEndpointHost(hostFromDetail(detail));
        const declared = fieldsFromDetail(detail);
        setFields(prev => {
          const map = new Map<string, AuthField>();
          for (const f of prev) upsertField(map, f);
          for (const f of declared) upsertField(map, f);
          return Array.from(map.values());
        });
      } catch (err) {
        log('registry_get failed (non-fatal): %s', err instanceof Error ? err.message : err);
      }
    })();
    return () => {
      cancelled = true;
    };
  }, [server.qualified_name]);

  // Offer a blank custom-header row only when the server declares nothing AND
  // isn't an OAuth sign-in — i.e. the mislabelled-remote case where the user
  // nonetheless has a token to paste. OAuth servers get the sign-in button, not
  // a token box (this is what stops "paste a token and hope" failures). Derived
  // rather than seeded from an effect (forbidden by react-hooks/set-state-in-
  // effect) and gated on `detecting` so the row never flashes before discovery.
  const offerFallbackHeader =
    visibleFields.length === 0 && authKind !== 'oauth' && authKind !== 'detecting';
  // What to render: real headers once the user has any, else the fallback row.
  const displayHeaders =
    customHeaders.length === 0 && offerFallbackHeader ? [FALLBACK_HEADER] : customHeaders;

  const addCustomHeader = useCallback(() => {
    setCustomHeaders(prev => [...prev, { id: nextId, name: '', value: '', scheme: 'bearer' }]);
    setNextId(n => n + 1);
  }, [nextId]);

  const removeCustomHeader = useCallback((id: number) => {
    setCustomHeaders(prev => prev.filter(h => h.id !== id));
  }, []);

  // Patch a header by id, materializing the fallback row into state on first
  // edit so the user's input persists without ever seeding state in an effect.
  const patchHeader = useCallback(
    (id: number, patch: Partial<CustomHeader>) =>
      setCustomHeaders(prev => {
        const base = prev.length === 0 && offerFallbackHeader ? [FALLBACK_HEADER] : prev;
        return base.map(x => (x.id === id ? { ...x, ...patch } : x));
      }),
    [offerFallbackHeader]
  );

  const handleConnect = useCallback(() => {
    // A required field is only "missing" when it's blank now AND wasn't already
    // stored on the install (re-opening Connect shouldn't force re-entry).
    const stored = new Set(server.env_keys);
    const missing = visibleFields.find(
      f => f.required && !stored.has(f.name) && !values[f.name]?.trim()
    );
    if (missing) {
      setError(t('mcp.install.missingRequired').replace('{key}', missing.name));
      return;
    }

    setBusy(true);
    setError(null);
    void (async () => {
      try {
        // Build the env/header map: declared values + named custom headers,
        // skipping blanks so we never store empty keys.
        const env: Record<string, string> = {};
        for (const f of visibleFields) {
          const v = values[f.name]?.trim();
          if (v) env[f.name] = applyScheme(schemeFor(f.name), v);
        }
        for (const h of customHeaders) {
          const name = h.name.trim();
          const value = applyScheme(h.scheme, h.value);
          if (name && value) env[name] = value;
        }

        let tools: McpTool[] = [];
        if (Object.keys(env).length > 0) {
          log('connect-with-auth server_id=%s keys=%o', server.server_id, Object.keys(env));
          const result = await mcpClientsApi.updateEnv({ server_id: server.server_id, env });
          // 401 → actionable reason (oauth-required / token-rejected /
          // credential-required); other failure → its message; null → connected.
          const errMsg = reconnectErrorMessage(result, t);
          if (errMsg) {
            setError(errMsg);
            return;
          }
          tools = result.tools ?? [];
        } else {
          log('connect (no auth supplied) server_id=%s', server.server_id);
          const result = await mcpClientsApi.connect(server.server_id);
          tools = result.tools ?? [];
        }
        onConnected(tools);
        onClose();
      } catch (err) {
        const msg = err instanceof Error ? err.message : String(err);
        log('connect failed: %s', msg);
        setError(msg);
      } finally {
        setBusy(false);
      }
    })();
  }, [
    visibleFields,
    values,
    customHeaders,
    schemeFor,
    server.server_id,
    server.env_keys,
    onConnected,
    onClose,
    t,
  ]);

  // Render a field description, linkifying any URL or bare domain so the user
  // can jump straight to the "get your key" page. Links are underlined and
  // carry an ↗ affordance so they read as actionable, not as plain prose.
  const renderDescription = useCallback(
    (text: string): ReactNode =>
      text.split(URL_SPLIT_RE).map((part, i) =>
        isLinkLike(part) ? (
          <button
            key={i}
            type="button"
            onClick={() => void openUrl(withScheme(part))}
            title={withScheme(part)}
            className="font-medium text-primary-600 dark:text-primary-400 underline underline-offset-2 hover:text-primary-700 dark:hover:text-primary-300 break-all">
            {part}
            <span aria-hidden="true"> ↗</span>
          </button>
        ) : (
          <span key={i}>{part}</span>
        )
      ),
    []
  );

  const modal = (
    <ModalShell
      onClose={handleClose}
      titleId={titleId}
      title={t('mcp.connectAuth.title').replace('{name}', server.display_name)}
      subtitle={t('mcp.connectAuth.hint')}
      maxWidthClassName="max-w-md"
      contentClassName="space-y-4 p-5"
      closePolicy={{
        backdrop: !busy || oauthWaiting,
        escape: !busy || oauthWaiting,
        button: !busy || oauthWaiting,
      }}
      footer={
        <div className="flex justify-end gap-2">
          <Button
            variant="secondary"
            size="sm"
            onClick={handleClose}
            disabled={busy && !oauthWaiting}>
            {t('common.cancel')}
          </Button>
          <Button variant="primary" size="sm" onClick={handleConnect} disabled={busy}>
            {busy ? t('mcp.detail.connecting') : t('mcp.detail.connect')}
          </Button>
        </div>
      }>
      <>
        {error && (
          <div className="rounded-lg border border-coral-200 dark:border-coral-500/30 bg-coral-50 dark:bg-coral-500/10 px-3 py-2 text-xs text-coral-700 dark:text-coral-300 wrap-break-word">
            {error}
          </div>
        )}

        {/* Browser OAuth — shown when detection says this server needs a sign-in. */}
        {authKind === 'oauth' && (
          <div className="space-y-2 rounded-lg border border-primary-200 dark:border-primary-500/30 bg-primary-50 dark:bg-primary-500/10 p-3">
            <p className="text-xs text-content-secondary">{t('mcp.connectAuth.oauthHint')}</p>
            <Button variant="primary" size="sm" onClick={handleOAuth} disabled={busy}>
              {oauthWaiting ? t('mcp.connectAuth.oauthWaiting') : t('mcp.connectAuth.signIn')}
            </Button>
            <p className="text-[11px] text-content-faint">{t('mcp.connectAuth.oauthOrToken')}</p>
          </div>
        )}

        {/* Where-to-get-credentials hint. Shown for non-OAuth servers: it names
            the provider host up front (from the registry's deployment_url) so
            the user isn't sent on a 401 round-trip just to discover where the
            token comes from, and offers the per-server config assistant. */}
        {/* Where the token comes from, when the server's endpoint says so.
            Nothing is rendered otherwise — an empty box reads as something
            still loading. */}
        {authKind !== 'oauth' && endpointHost && (
          <p className="rounded-lg border border-line bg-surface-muted px-3 py-2 text-[11px] text-content-secondary">
            {t('mcp.connectAuth.tokenProvider')}{' '}
            <Button
              variant="tertiary"
              size="xs"
              onClick={() => void openUrl(providerUrlFromHost(endpointHost))}
              title={providerUrlFromHost(endpointHost)}
              className="h-auto p-0 align-baseline font-medium text-primary-600 underline underline-offset-2 hover:text-primary-700 dark:text-primary-400 dark:hover:text-primary-300 break-all">
              {endpointHost}
              <span aria-hidden="true"> ↗</span>
            </Button>
          </p>
        )}

        {/* Declared fields — one labelled input per key the server asks for. */}
        {visibleFields.length > 0 && (
          <div className="space-y-2">
            <p className="text-[11px] font-medium uppercase tracking-wide text-content-faint">
              {t('mcp.connectAuth.requiredLabel')}
            </p>
            {visibleFields.map(field => (
              <div key={field.name} className="space-y-1">
                <div className="flex items-center gap-0.5">
                  <label
                    htmlFor={`auth-${field.name}`}
                    className="block text-[11px] font-medium text-content-secondary font-mono">
                    {field.name}
                  </label>
                  {field.required && (
                    <span
                      aria-hidden="true"
                      title={t('mcp.connectAuth.requiredLabel')}
                      className="text-[11px] text-coral-500">
                      *
                    </span>
                  )}
                </div>
                {field.description && (
                  <p className="text-[11px] text-content-faint leading-snug">
                    {renderDescription(field.description)}
                  </p>
                )}
                <div className="flex gap-2">
                  {isAuthorizationField(field.name) && (
                    <NativeSelect
                      inputSize="sm"
                      value={schemeFor(field.name)}
                      onChange={e =>
                        setAuthSchemes(prev => ({
                          ...prev,
                          [field.name]: e.target.value as 'bearer' | 'raw',
                        }))
                      }
                      disabled={busy}
                      title={t('mcp.connectAuth.schemeLabel')}
                      className="shrink-0 text-[11px]">
                      <option value="bearer">{t('mcp.connectAuth.schemeBearer')}</option>
                      <option value="raw">{t('mcp.connectAuth.schemeRaw')}</option>
                    </NativeSelect>
                  )}
                  <TextField
                    id={`auth-${field.name}`}
                    inputSize="sm"
                    type={field.secret && !reveal[field.name] ? 'password' : 'text'}
                    value={values[field.name] ?? ''}
                    onChange={e => setValues(prev => ({ ...prev, [field.name]: e.target.value }))}
                    placeholder={t('mcp.install.enterValue').replace('{key}', field.name)}
                    disabled={busy}
                    // Suppress Chromium password-manager autofill so a token saved
                    // for one MCP doesn't pre-fill another's field.
                    autoComplete="new-password"
                    data-1p-ignore
                    data-lpignore="true"
                    data-form-type="other"
                    className="flex-1"
                  />
                  {field.secret && (
                    <Button
                      variant="secondary"
                      size="sm"
                      onClick={() =>
                        setReveal(prev => ({ ...prev, [field.name]: !prev[field.name] }))
                      }
                      disabled={busy}
                      className="shrink-0">
                      {reveal[field.name] ? t('mcp.install.hide') : t('mcp.install.show')}
                    </Button>
                  )}
                </div>
              </div>
            ))}
          </div>
        )}

        {/* Custom headers — free-form fallback for servers that declare no auth. */}
        <div className="space-y-2">
          <div className="flex items-center justify-between">
            <p className="text-[11px] font-medium uppercase tracking-wide text-content-faint">
              {t('mcp.connectAuth.customHeadersLabel')}
            </p>
            <Button
              variant="tertiary"
              size="xs"
              onClick={addCustomHeader}
              disabled={busy}
              className="h-auto p-0 text-[11px] font-medium text-primary-600 hover:underline dark:text-primary-400">
              {t('mcp.connectAuth.addHeader')}
            </Button>
          </div>
          {displayHeaders.length === 0 && (
            <p className="text-[11px] text-content-faint">
              {t('mcp.connectAuth.customHeadersEmpty')}
            </p>
          )}
          {displayHeaders.map(h => (
            <div key={h.id} className="space-y-1.5 rounded-lg border border-line p-2">
              {/* Row 1: header name + scheme + remove */}
              <div className="flex gap-2">
                <TextField
                  mono
                  inputSize="sm"
                  value={h.name}
                  onChange={e => patchHeader(h.id, { name: e.target.value })}
                  placeholder={t('mcp.connectAuth.headerName')}
                  disabled={busy}
                  autoComplete="off"
                  data-1p-ignore
                  data-lpignore="true"
                  data-form-type="other"
                  className="min-w-0 flex-1"
                />
                <NativeSelect
                  inputSize="sm"
                  value={h.scheme}
                  onChange={e => patchHeader(h.id, { scheme: e.target.value as 'bearer' | 'raw' })}
                  disabled={busy}
                  title={t('mcp.connectAuth.schemeLabel')}
                  className="shrink-0 text-[11px]">
                  <option value="bearer">{t('mcp.connectAuth.schemeBearer')}</option>
                  <option value="raw">{t('mcp.connectAuth.schemeRaw')}</option>
                </NativeSelect>
                <Button
                  variant="secondary"
                  size="sm"
                  iconOnly
                  onClick={() => removeCustomHeader(h.id)}
                  disabled={busy}
                  aria-label={t('mcp.connectAuth.removeHeader')}
                  className="shrink-0">
                  ✕
                </Button>
              </div>
              {/* Row 2: full-width value (tokens are long) */}
              <TextField
                inputSize="sm"
                type="password"
                value={h.value}
                onChange={e => patchHeader(h.id, { value: e.target.value })}
                placeholder={t('mcp.connectAuth.headerValue')}
                disabled={busy}
                // Suppress Chromium password-manager autofill (token leakage
                // across MCP servers on the shared app origin).
                autoComplete="new-password"
                data-1p-ignore
                data-lpignore="true"
                data-form-type="other"
                className="w-full"
              />
            </div>
          ))}
        </div>
      </>
    </ModalShell>
  );

  return modal;
};

export default ConnectAuthModal;