Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(chat): keep MarkdownText's signature; add MarkdownTextNoCitations

M3gA-Mind0650e9654d24
diff --git a/app/src/components/assistant-ui/markdown-text.tsx b/app/src/components/assistant-ui/markdown-text.tsx
index d629592890..dbe2890fad 100644
--- a/app/src/components/assistant-ui/markdown-text.tsx
+++ b/app/src/components/assistant-ui/markdown-text.tsx
@@ -100,12 +100,7 @@ function transformAssistantUrl(url: string): string {
const NO_CITATIONS: readonly CitationSource[] = [];
-/**
- * `citations={false}` renders text that is not this message's own answer (a
- * sub-agent's report shown on its delegation card): its `[n]` markers refer to
- * sources the enclosing message does not have, so they stay plain text.
- */
-const MarkdownTextImpl = ({ citations = true }: { citations?: boolean }) => {
+const MarkdownTextImpl = ({ citations }: { citations: boolean }) => {
// Math is GATED, not always-on, and the gate is `hasLatexContent` rather than
// "contains a $". `remark-math` would otherwise read "$10 vs $20" as an inline
// formula and eat the prose between them; the signature requires a real LaTeX
@@ -164,7 +159,19 @@ const MarkdownTextImpl = ({ citations = true }: { citations?: boolean }) => {
);
};
-export const MarkdownText = memo(MarkdownTextImpl);
+/** The chat's markdown renderer; also an assistant-ui `Text` part component. */
+export const MarkdownText = memo(function MarkdownText() {
+ return <MarkdownTextImpl citations />;
+});
+
+/**
+ * {@link MarkdownText} for text that is not this message's own answer (a
+ * sub-agent's report on its delegation card): its `[n]` markers refer to
+ * sources the enclosing message does not have, so they stay plain text.
+ */
+export const MarkdownTextNoCitations = memo(function MarkdownTextNoCitations() {
+ return <MarkdownTextImpl citations={false} />;
+});
const CodeHeader: FC<CodeHeaderProps> = ({ language, code }) => {
const { isCopied, copyToClipboard } = useCopyToClipboard();
diff --git a/app/src/features/conversations/aui/SubagentTaskCard.tsx b/app/src/features/conversations/aui/SubagentTaskCard.tsx
index 0e658a3448..1de5759f2d 100644
--- a/app/src/features/conversations/aui/SubagentTaskCard.tsx
+++ b/app/src/features/conversations/aui/SubagentTaskCard.tsx
@@ -29,7 +29,7 @@ import { useCallback, useState } from 'react';
import { TaskCard, type TaskCardState } from '../../../components/assistant-ui/elements/task-card';
import { TaskTranscript } from '../../../components/assistant-ui/elements/task-card.aui';
import { useDisclosure } from '../../../components/assistant-ui/lib/useDisclosure';
-import { MarkdownText } from '../../../components/assistant-ui/markdown-text';
+import { MarkdownTextNoCitations } from '../../../components/assistant-ui/markdown-text';
import { formatElapsed } from '../../../components/assistant-ui/utils/task';
import { Button } from '../../../components/ui';
import { useT } from '../../../lib/i18n/I18nContext';
@@ -263,7 +263,7 @@ export const SubagentTaskCard: ToolCallMessagePartComponent = ({
resolved.output && state === 'done' ? (
<div data-testid="subagent-report" className="text-sm">
<TextMessagePartProvider text={resolved.output} isRunning={false}>
- <MarkdownText citations={false} />
+ <MarkdownTextNoCitations />
</TextMessagePartProvider>
</div>
) : null;