The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.
Rust agent-orchestrationai-agentsai-assistantdesktopllmlocal-firstmcppersonal-aiprivacyrustsecond-braintauri
fix(runtime): correctly handle channel send errors during message processing
Steven Enamakel0c43ba328fe0
diff --git a/crates/openhuman-core/src/channels/runtime/dispatch/processor/turn.rs b/crates/openhuman-core/src/channels/runtime/dispatch/processor/turn.rsindex edc966a2fa..f3b84ce188 100644--- a/crates/openhuman-core/src/channels/runtime/dispatch/processor/turn.rs+++ b/crates/openhuman-core/src/channels/runtime/dispatch/processor/turn.rs@@ -509,22 +509,23 @@ pub(crate) async fn process_channel_runtime_message();let delivered = if native_target.is_some() {native_delivery_succeeded- } else {- false- };- if native_target.is_none() {- if let Some(channel) = target_channel.as_ref() {- if let Err(e) = channel- .send_with_outbound_intent(- &SendMessage::new(&response_text, &msg.reply_target)- .in_thread(msg.thread_ts.clone()),- )- .await- {+ } else if let Some(channel) = target_channel.as_ref() {+ match channel+ .send_with_outbound_intent(+ &SendMessage::new(&response_text, &msg.reply_target)+ .in_thread(msg.thread_ts.clone()),+ )+ .await+ {+ Ok(()) => true,+ Err(e) => {eprintln!(" ❌ Failed to reply on {}: {e}", channel.name());+ false}}- }+ } else {+ false+ };(delivered, response_text, resolved_provider, resolved_model)}Err(e) => {diff --git a/crates/openhuman-core/src/channels/tests/runtime_dispatch.rs b/crates/openhuman-core/src/channels/tests/runtime_dispatch.rsindex 12bfc16ec9..8bfd7e1b5b 100644--- a/crates/openhuman-core/src/channels/tests/runtime_dispatch.rs+++ b/crates/openhuman-core/src/channels/tests/runtime_dispatch.rs@@ -362,13 +362,15 @@ fn unrelated_processed_event(n: usize) -> DomainEvent {}}-async fn resolved_route_ctx() -> Arc<ChannelRuntimeContext> {- let channel_impl = Arc::new(RecordingChannel::default());+async fn resolved_route_ctx(send_error: Option<&str>) -> (Arc<ChannelRuntimeContext>, Arc<RecordingChannel>) {+ let mut channel_state = RecordingChannel::default();+ channel_state.send_error = send_error.map(str::to_owned);+ let channel_impl = Arc::new(channel_state);let channel = Arc::new(ChannelHandle::Test(channel_impl));let mut channels_by_name = HashMap::new();channels_by_name.insert(channel.name().to_string(), channel);- Arc::new(ChannelRuntimeContext {+ (Arc::new(ChannelRuntimeContext {relay_thread: None,channels_by_name: Arc::new(channels_by_name),module_objects: Arc::new(HashMap::new()),@@ -393,10 +395,14 @@ async fn resolved_route_ctx() -> Arc<ChannelRuntimeContext> {multimodal_files: crate::config::MultimodalFileConfig::default(),config: None,core: None,- })+ }), channel_impl)}-async fn run_resolved_route_message(message_id: &str, noise_after: usize) {+async fn run_resolved_route_message(+ message_id: &str,+ noise_after: usize,+ send_error: Option<&str>,+) {crate::core::bus::init().await.expect("bus init");let watcher = watch_for_channel_processed(message_id);@@ -409,8 +415,9 @@ async fn run_resolved_route_message(message_id: &str, noise_after: usize) {}).await;+ let (ctx, channel) = resolved_route_ctx(send_error).await;process_channel_message(- resolved_route_ctx().await,+ ctx,traits::ChannelMessage {reply_to_id: None,topic_id: None,@@ -449,15 +456,26 @@ async fn run_resolved_route_message(message_id: &str, noise_after: usize) {else {unreachable!("wait_for_channel_processed returns only ChannelMessageProcessed");};- assert!(success);+ assert_eq!(success, send_error.is_none());assert_eq!(response, "CANNED_RESPONSE_FROM_RESOLVED_ROUTE");assert_eq!(provider, "actual-provider");assert_eq!(model, "actual-model");+ let sends = channel.sent.lock().expect("test sends lock");+ if send_error.is_some() {+ assert!(sends.is_empty(), "a failed send must not be recorded as delivered");+ } else {+ assert_eq!(sends.len(), 1, "successful reply delivery must be recorded");+ }}#[tokio::test]async fn channel_processed_event_records_resolved_agent_route() {- run_resolved_route_message("resolved-route-msg", 0).await;+ run_resolved_route_message("resolved-route-msg", 0, None).await;+}++#[tokio::test]+async fn channel_processed_event_reports_failed_reply_delivery() {+ run_resolved_route_message("failed-reply-delivery-msg", 0, Some("send failed")).await;}/// Regression: the event used to be read only after the message finished, by@@ -465,7 +483,7 @@ async fn channel_processed_event_records_resolved_agent_route() {/// bus ring, so the test failed only in the full parallel suite.#[tokio::test]async fn channel_processed_event_is_found_behind_a_flood_of_unrelated_events() {- run_resolved_route_message("resolved-route-flood-msg", 600).await;+ run_resolved_route_message("resolved-route-flood-msg", 600, None).await;}/// Security regression for the `[FILE:…]` smuggling vector: a remote