Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(voice): assert legacy voice handlers and schema fixtures

Steven Enamakel1531f97740aa
diff --git a/crates/openhuman-core/src/core/all_bound_controller_tests.rs b/crates/openhuman-core/src/core/all_bound_controller_tests.rs
index 7eafa7bc16..4a69e1d838 100644
--- a/crates/openhuman-core/src/core/all_bound_controller_tests.rs
+++ b/crates/openhuman-core/src/core/all_bound_controller_tests.rs
@@ -491,7 +491,7 @@ fn production_registry_binds_every_core_voice_controller_to_its_parser() {
.chain(internal_registry())
.filter(|row| row.controller.schema.method_name().starts_with("voice."))
.collect();
- let entries: Vec<_> = grouped.iter().map(|row| &row.controller).collect();
+ let entries: Vec<_> = grouped.iter().map(|row| row.controller.clone()).collect();
let contracts = crate::voice::parameter_contracts();
let expected_methods = [
"voice.status",
diff --git a/crates/openhuman-core/src/core/schema_test_support_tests.rs b/crates/openhuman-core/src/core/schema_test_support_tests.rs
index 6292857d3c..05dfa1f653 100644
--- a/crates/openhuman-core/src/core/schema_test_support_tests.rs
+++ b/crates/openhuman-core/src/core/schema_test_support_tests.rs
@@ -135,20 +135,9 @@ fn duplicate_controller_and_schema_identity_failures_are_rejected() {
#[test]
fn legacy_entries_are_rejected_without_running_the_legacy_handler() {
- let (_, contract) = fixture();
+ let (bound, contract) = fixture();
let legacy = ControllerEntry::legacy(RegisteredController {
- schema: ControllerSchema {
- namespace: "fixture",
- function: "read",
- description: "Read a fixture.",
- inputs: vec![crate::core::FieldSchema {
- name: "id",
- ty: crate::core::TypeSchema::String,
- comment: "Fixture identifier.",
- required: true,
- }],
- outputs: vec![],
- },
+ schema: bound.schema,
handler: legacy_handler,
});
assert!(verify_parameter_contracts(&[legacy], &[contract])
diff --git a/crates/openhuman-core/src/voice/live/schemas_tests.rs b/crates/openhuman-core/src/voice/live/schemas_tests.rs
index 8f8650ea09..3b60815a1a 100644
--- a/crates/openhuman-core/src/voice/live/schemas_tests.rs
+++ b/crates/openhuman-core/src/voice/live/schemas_tests.rs
@@ -24,6 +24,32 @@ fn registers_four_live_controllers_in_the_voice_namespace() {
.any(|f| f.name == "provider" && f.required));
}
+#[test]
+fn live_legacy_catalog_keeps_private_handler_identities_and_schema_fixtures() {
+ let controllers = live_registered_controllers();
+ let expected = [
+ ("voice.live_providers", handle_live_providers),
+ ("voice.live_settings_get", handle_live_settings_get),
+ ("voice.live_settings_set", handle_live_settings_set),
+ ("voice.live_test_provider", handle_live_test_provider),
+ ];
+ assert_eq!(controllers.len(), expected.len());
+ for (controller, (method, handler)) in controllers.iter().zip(expected) {
+ assert_eq!(controller.schema.method_name(), method);
+ assert!(std::ptr::fn_addr_eq(controller.handler, handler));
+ }
+
+ let contracts = crate::voice::parameter_contracts();
+ for contract in contracts.iter().filter(|contract| contract.method.contains(".live_")) {
+ let controller = controllers
+ .iter()
+ .find(|controller| controller.schema.method_name() == contract.method)
+ .expect("each live voice schema fixture has a legacy row");
+ crate::core::all::verify_parameter_schema(&controller.schema, contract)
+ .expect("legacy live voice schema retains its independent fixture");
+ }
+}
+
#[tokio::test]
async fn handlers_reject_bad_params() {
let bad = |v: serde_json::Value| v.as_object().unwrap().clone();
diff --git a/crates/openhuman-core/src/voice/schemas_tests.rs b/crates/openhuman-core/src/voice/schemas_tests.rs
index 14c5eeb412..d52db1476e 100644
--- a/crates/openhuman-core/src/voice/schemas_tests.rs
+++ b/crates/openhuman-core/src/voice/schemas_tests.rs
@@ -6,12 +6,41 @@ use crate::core::all::{
use serde_json::json;
#[test]
-fn legacy_voice_catalog_keeps_its_handler_and_example_contracts() {
- crate::core::all::verify_parameter_contracts(
- &all_voice_registered_controllers(),
- &crate::voice::parameter_contracts(),
- )
- .unwrap();
+fn legacy_voice_catalog_keeps_its_handlers_and_schema_fixtures() {
+ use super::handlers::*;
+
+ let controllers = all_voice_registered_controllers();
+ let expected = [
+ ("voice.status", handle_voice_status),
+ ("voice.transcribe", handle_voice_transcribe),
+ ("voice.transcribe_bytes", handle_voice_transcribe_bytes),
+ ("voice.tts", handle_voice_tts),
+ ("voice.reply_synthesize", handle_voice_reply_synthesize),
+ ("voice.stt_dispatch", handle_voice_stt_dispatch),
+ ("voice.tts_dispatch", handle_voice_tts_dispatch),
+ ("voice.set_providers", handle_voice_set_providers),
+ (
+ "voice.update_provider_settings",
+ handle_voice_update_provider_settings,
+ ),
+ ("voice.list_models", handle_voice_list_models),
+ ("voice.test_provider", handle_voice_test_provider),
+ ];
+ assert_eq!(controllers.len(), expected.len());
+ for (controller, (method, handler)) in controllers.iter().zip(expected) {
+ assert_eq!(controller.schema.method_name(), method);
+ assert!(std::ptr::fn_addr_eq(controller.handler, handler));
+ }
+
+ let contracts = crate::voice::parameter_contracts();
+ for contract in contracts.iter().filter(|contract| !contract.method.contains(".live_")) {
+ let controller = controllers
+ .iter()
+ .find(|controller| controller.schema.method_name() == contract.method)
+ .expect("each core voice schema fixture has a legacy row");
+ crate::core::all::verify_parameter_schema(&controller.schema, contract)
+ .expect("legacy core voice schema retains its independent fixture");
+ }
}
#[test]