Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(chat): read the correct field for approval and plan review events

Steven Enamakel17277a8885c4
diff --git a/app/src/providers/ChatRuntimeProvider.tsx b/app/src/providers/ChatRuntimeProvider.tsx
index 7496c82665..a8efaf1f24 100644
--- a/app/src/providers/ChatRuntimeProvider.tsx
+++ b/app/src/providers/ChatRuntimeProvider.tsx
@@ -1507,7 +1507,7 @@ const ChatRuntimeProvider = ({ children }: { children: React.ReactNode }) => {
rtLog('approval_decided', {
thread: event.thread_id,
request: event.request_id,
- resolution: event.resolution,
+ resolution: event.cancel_reason,
});
// Only a server-recorded TERMINAL non-decision (TTL expiry, an
// external cancel) needs handling here: an interactive decision made
diff --git a/app/src/providers/__tests__/ChatRuntimeProvider.test.tsx b/app/src/providers/__tests__/ChatRuntimeProvider.test.tsx
index 18a568503e..0d260ed33b 100644
--- a/app/src/providers/__tests__/ChatRuntimeProvider.test.tsx
+++ b/app/src/providers/__tests__/ChatRuntimeProvider.test.tsx
@@ -920,7 +920,7 @@ describe('ChatRuntimeProvider — dedupe, proactive resolution, mid-turn invaria
thread_id: 't-plan-decided',
request_id: 'pr-decided',
decision: 'reject',
- resolution: 'cancelled',
+ cancel_reason: 'cancelled',
});
});
diff --git a/app/src/services/chatService.ts b/app/src/services/chatService.ts
index 424d61ce6f..a5842b05f3 100644
--- a/app/src/services/chatService.ts
+++ b/app/src/services/chatService.ts
@@ -1339,7 +1339,7 @@ export function subscribeChatEvents(listeners: ChatEventListeners): () => void {
EVENTS.approvalDecided,
e.thread_id,
e.request_id,
- e.cancel_reason
+ e.resolution
);
listeners.onApprovalDecided?.(e);
};
@@ -1365,7 +1365,7 @@ export function subscribeChatEvents(listeners: ChatEventListeners): () => void {
EVENTS.planReviewDecided,
e.thread_id,
e.request_id,
- e.resolution
+ e.cancel_reason
);
listeners.onPlanReviewDecided?.(e);
};