Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(agent): a catalogue refresh alone no longer marks the prompt as replaced

M3gA-Mind17c17653d8ad
diff --git a/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh.rs b/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh.rs
index 1e2514fa88..0a7137fb0c 100644
--- a/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh.rs
+++ b/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh.rs
@@ -72,6 +72,13 @@ impl OpenHumanTurnPrelude {
} else {
false
};
+ // Compared before the catalogue refresh below, which changes the
+ // prefix of a kept prompt too: only the rendered prompt itself counts.
+ let changed = rendered
+ && preparation
+ .prefix
+ .as_ref()
+ .is_some_and(|prefix| prefix.messages() != view.prefix.messages());
self.refresh_permanent_prefix(&mut preparation, view.prefix);
if let Some(prefix) = preparation.prefix.as_ref() {
// The runtime sends `prefix` in place of the recorded one, so the
@@ -83,10 +90,6 @@ impl OpenHumanTurnPrelude {
+ prefix.messages().len();
}
if rendered {
- let changed = preparation
- .prefix
- .as_ref()
- .is_some_and(|prefix| prefix.messages() != view.prefix.messages());
let (prefix_in_use, reason) = prompt_refresh_log_fields(changed);
if changed {
tracing::info!(
diff --git a/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs b/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs
index 33ac9e614b..cdf679fe1a 100644
--- a/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs
+++ b/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs
@@ -601,3 +601,55 @@ async fn a_catalogue_change_under_a_kept_prompt_carries_no_note() {
"a catalogue change alone is not a replaced prompt"
);
}
+
+#[tokio::test]
+async fn a_catalogue_change_under_a_rendered_but_identical_prompt_carries_no_note() {
+ // The agent opts in and the current prompt renders identical to the
+ // recorded one, but a permanent tool was added since: the catalogue
+ // refresh changes the prefix. The prompt was not replaced, so no note.
+ let root = tempfile::tempdir().expect("tempdir");
+ let prelude = prelude(root.path(), "current", true);
+ {
+ let mut surface = prelude
+ .tool_surface
+ .lock()
+ .unwrap_or_else(std::sync::PoisonError::into_inner);
+ let spec = tinytools::ToolSpec {
+ name: "A_TOOL".into(),
+ description: "d".into(),
+ parameters: serde_json::json!({"type": "object"}),
+ };
+ surface.visible_tool_specs = Arc::new(vec![Arc::new(spec)]);
+ surface.permanent_tool_names = ["A_TOOL".to_string()].into();
+ }
+ let history = [
+ Message::system("current"),
+ Message::user("earlier"),
+ Message::assistant("hello"),
+ ];
+ let mut request = request();
+ let prepared = prelude
+ .prepare_turn(
+ false,
+ &resumed(&current(), &history),
+ &snapshot(4),
+ &mut request,
+ )
+ .await
+ .expect("prepared turn");
+ let prefix = prepared
+ .prefix
+ .as_ref()
+ .expect("the refreshed catalogue is offered");
+ assert!(prefix
+ .messages()
+ .last()
+ .expect("a catalogue")
+ .text()
+ .contains("A_TOOL"));
+ assert_eq!(
+ request.input.text(),
+ "hi",
+ "a catalogue change under a kept prompt is not a replaced prompt"
+ );
+}