Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(spawn_subagent_async): align async reference tests with task-key routing

Steven Enamakel2082cb693ed9
diff --git a/crates/openhuman-core/src/agent/orchestration/tools/spawn_subagent_async_tests.rs b/crates/openhuman-core/src/agent/orchestration/tools/spawn_subagent_async_tests.rs
index ace29af5dd..af5848b340 100644
--- a/crates/openhuman-core/src/agent/orchestration/tools/spawn_subagent_async_tests.rs
+++ b/crates/openhuman-core/src/agent/orchestration/tools/spawn_subagent_async_tests.rs
@@ -158,7 +158,7 @@ fn background_contract_forbids_user_attention() {
#[test]
fn accepted_message_hides_task_id_from_prose() {
let payload = r#"{"task_id":"sub-internal-123","agent_id":"archivist","mode":"async"}"#;
- let message = format_async_subagent_accepted("archivist", payload, &FleetToolSet::all());
+ let message = format_async_subagent_accepted("archivist", payload);
let prose = message
.split("[async_subagent_ref]")
.next()
@@ -170,146 +170,30 @@ fn accepted_message_hides_task_id_from_prose() {
assert!(message.contains("sub-internal-123"));
}
-/// A parent with `wait_subagent` but not `steer_subagent` (a wait-only
-/// fleet) must be told it can wait/poll but never invited to "send more
-/// input" — that guidance, and the `send_message` instruction, require
-/// `steer_subagent` specifically. Regression for CodeRabbit finding on
-/// `format_async_subagent_accepted`/`async_subagent_ref_payload` gating both
-/// messages on `can_wait()` alone.
#[test]
-fn wait_only_fleet_omits_steering_guidance_and_instruction() {
- let fleet = FleetToolSet::from_scope(
- &tinyagents_definition::ToolScope::Named(vec!["wait_subagent".to_string()]),
- &[],
- );
- assert!(fleet.can_wait());
- assert!(!fleet.has("steer_subagent"));
-
- let payload = async_subagent_ref_payload(
- "sub-123",
- "subsess-456",
- "task_manager_agent",
- Some("thread-worker"),
- false,
- "created",
- "running",
- &fleet,
- );
- assert_eq!(payload["instructions"]["wait"]["tool"], "wait_subagent");
- assert!(
- !payload["instructions"]
- .as_object()
- .expect("instructions map")
- .contains_key("send_message"),
- "send_message offered to a parent without steer_subagent"
- );
- let serialized = serde_json::to_string(&payload).unwrap();
- assert!(
- !serialized.contains("steer_subagent"),
- "steer_subagent leaked into the envelope"
- );
-
- let message = format_async_subagent_accepted("task_manager_agent", &serialized, &fleet);
- let prose = message.split("[async_subagent_ref]").next().unwrap();
- assert!(prose.contains("wait for completion"));
- assert!(
- !prose.contains("send more input"),
- "wait-only parent told to send more input it cannot send"
- );
-}
-
-#[test]
-fn async_reference_payload_includes_agent_id_and_control_instructions() {
+fn async_reference_payload_routes_follow_up_through_the_same_task_key() {
let payload = async_subagent_ref_payload(
"sub-123",
"subsess-456",
+ "research-work",
"task_manager_agent",
Some("thread-worker"),
false,
"created",
"running",
- &FleetToolSet::all(),
);
assert_eq!(payload["agent_id"], "task_manager_agent");
- assert_eq!(payload["agentId"], "task_manager_agent");
- assert_eq!(payload["instructions"]["wait"]["tool"], "wait_subagent");
- assert_eq!(
- payload["instructions"]["timeout_tick"]["arguments"]["timeout_secs"],
- 1
- );
- assert_eq!(payload["instructions"]["delayed_tick"]["tool"], "wait");
- assert_eq!(payload["instructions"]["delayed_loop"]["tool"], "wait_loop");
+ assert_eq!(payload["task_key"], "research-work");
+ assert_eq!(payload["instructions"]["answer_or_resume"]["tool"], "spawn_subagent");
assert_eq!(
- payload["instructions"]["send_message"]["tool"],
- "steer_subagent"
+ payload["instructions"]["answer_or_resume"]["arguments"]["task_key"],
+ "research-work"
);
-}
-
-/// The shipped orchestrator (#5701) has no wait/steer/close tools; the envelope
-/// must not name them, and must say the result arrives on its own.
-#[test]
-fn async_reference_matches_the_orchestrator_fleet_vocabulary() {
- let registry = AgentDefinitionRegistry::builtins_only();
- let def = registry.get("orchestrator").expect("built-in orchestrator");
- let fleet = FleetToolSet::from_scope(&def.tools, &def.disallowed_tools);
-
- let payload = async_subagent_ref_payload(
- "sub-123",
- "subsess-456",
- "task_manager_agent",
- None,
- false,
- "created",
- "running",
- &fleet,
- );
- let instructions = payload["instructions"]
- .as_object()
- .expect("instructions map");
- for absent in [
- "wait",
- "timeout_tick",
- "delayed_tick",
- "delayed_loop",
- "send_message",
- ] {
- assert!(
- !instructions.contains_key(absent),
- "{absent} offered to a parent without it"
- );
- }
- assert_eq!(
- payload["instructions"]["answer_or_resume"]["tool"],
- "continue_subagent"
- );
- assert_eq!(payload["result_delivery"], "automatic");
let serialized = serde_json::to_string(&payload).unwrap();
- for name in [
- "wait_subagent",
- "steer_subagent",
- "wait_loop",
- "close_subagent",
- ] {
- assert!(
- !serialized.contains(name),
- "{name} leaked into the envelope"
- );
+ for retired in ["continue_subagent", "wait_subagent", "steer_subagent", "close_subagent"] {
+ assert!(!serialized.contains(retired), "{retired} leaked into the envelope");
}
- let next: Vec<&str> = payload["next_actions"]
- .as_array()
- .unwrap()
- .iter()
- .filter_map(|v| v.as_str())
- .collect();
- assert!(next
- .iter()
- .any(|a| a.contains("delivered to you automatically")));
-
- let message = format_async_subagent_accepted("task_manager_agent", &serialized, &fleet);
- let prose = message.split("[async_subagent_ref]").next().unwrap();
- assert!(prose.contains("delivered to you automatically"));
- assert!(!prose.contains("wait for completion"));
}
#[test]