Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(desktop): add tests for state update deserialization

Steven Enamakel36d59628173e
diff --git a/crates/openhuman-core/src/core/all_app_state_controller_tests.rs b/crates/openhuman-core/src/core/all_app_state_controller_tests.rs
new file mode 100644
index 0000000000..80ee69dedc
--- /dev/null
+++ b/crates/openhuman-core/src/core/all_app_state_controller_tests.rs
@@ -0,0 +1,87 @@
+use super::*;
+use crate::core::TypeSchema;
+
+#[test]
+fn raw_app_state_desktop_registry_matches_its_independent_contract() {
+ let entries: Vec<_> = registry()
+ .iter()
+ .filter(|row| row.controller.schema.namespace == "app_state")
+ .collect();
+ let methods = ["app_state.snapshot", "app_state.update_local_state"];
+ let contracts = crate::desktop::app_state::app_state_parameter_contracts();
+
+ assert_eq!(
+ entries.len(),
+ methods.len(),
+ "complete raw app_state inventory"
+ );
+ assert_eq!(
+ entries
+ .iter()
+ .map(|row| row.controller.schema.method_name())
+ .collect::<Vec<_>>(),
+ methods,
+ "app_state registration order is a wire contract"
+ );
+ assert!(entries.iter().all(|row| row.group == DomainGroup::Desktop));
+ assert!(internal_registry()
+ .iter()
+ .all(|row| row.controller.schema.namespace != "app_state"));
+ assert_eq!(
+ entries
+ .iter()
+ .map(|row| row.controller.rpc_method_name())
+ .collect::<Vec<_>>(),
+ [
+ "openhuman.app_state_snapshot",
+ "openhuman.app_state_update_local_state"
+ ]
+ );
+ for entry in &entries {
+ let outputs = &entry.controller.schema.outputs;
+ assert_eq!(outputs.len(), 1);
+ assert_eq!(outputs[0].name, "result");
+ assert!(outputs[0].required);
+ assert!(matches!(&outputs[0].ty, TypeSchema::Json));
+ }
+
+ let entries: Vec<_> = entries
+ .into_iter()
+ .map(|row| row.controller.clone())
+ .collect();
+ crate::core::all::verify_parameter_contracts(&entries, &contracts)
+ .expect("raw app_state entries use their declared schemas and runtime decoders");
+}
+
+#[test]
+fn raw_app_state_decoders_ignore_unknown_outer_fields() {
+ use serde_json::json;
+
+ let entries: Vec<_> = registry()
+ .iter()
+ .filter(|row| row.controller.schema.namespace == "app_state")
+ .map(|row| row.controller.clone())
+ .collect();
+ let snapshot = entries
+ .iter()
+ .find(|entry| entry.schema.method_name() == "app_state.snapshot")
+ .expect("raw snapshot entry");
+ snapshot
+ .decode_params(Map::from_iter([
+ ("unknown_scalar".into(), json!(17)),
+ ("unknown_nested".into(), json!({"ignored": [true, null]})),
+ ]))
+ .expect("snapshot ignores its entire parameter map");
+
+ let update = entries
+ .iter()
+ .find(|entry| entry.schema.method_name() == "app_state.update_local_state")
+ .expect("raw update entry");
+ update
+ .decode_params(Map::from_iter([
+ ("encryptionKey".into(), json!("unchanged")),
+ ("ignored_scalar".into(), json!(false)),
+ ("ignored_nested".into(), json!({"extra": 1})),
+ ]))
+ .expect("update ignores undeclared outer keys");
+}
diff --git a/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs b/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs
index a1658e2650..ddd01ff44e 100644
--- a/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs
+++ b/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs
@@ -106,4 +106,59 @@ fn deserialize_update_local_state_params_with_null_clears_value() {
serde_json::from_value(serde_json::Value::Object(m)).unwrap();
assert_eq!(params.encryption_key, Some(None));
assert!(matches!(params.onboarding_tasks, Some(None)));
+ assert_eq!(params.keyring_consent, Some(None));
+}
+
+#[test]
+fn update_local_state_patch_preserves_camel_case_tristate_and_nested_defaults() {
+ let missing: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({})).unwrap();
+ assert_eq!(missing.encryption_key, None);
+ assert_eq!(missing.onboarding_tasks, None);
+ assert_eq!(missing.keyring_consent, None);
+
+ let params: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({
+ "encryptionKey": " keep whitespace ",
+ "onboardingTasks": {
+ "accessibilityPermissionGranted": false,
+ "enabledTools": [],
+ "connectedSources": [],
+ "updatedAtMs": null,
+ "unknownNestedField": true
+ },
+ "keyringConsent": {
+ "storageMode": "",
+ "consentedAtMs": 17,
+ "unknownNestedField": true
+ },
+ "unknownOuterField": {"ignored": true},
+ "encryption_key": "snake_case_is_not_an_alias"
+ }))
+ .unwrap();
+
+ assert_eq!(
+ params.encryption_key.as_deref(),
+ Some(Some(" keep whitespace "))
+ );
+ let tasks = params.onboarding_tasks.as_ref().unwrap().as_ref().unwrap();
+ assert!(!tasks.accessibility_permission_granted);
+ assert!(tasks.enabled_tools.is_empty());
+ assert!(tasks.connected_sources.is_empty());
+ assert_eq!(tasks.updated_at_ms, None);
+ let consent = params.keyring_consent.as_ref().unwrap().as_ref().unwrap();
+ assert_eq!(consent.storage_mode, "");
+ assert_eq!(consent.consented_at_ms, Some(17));
+}
+
+#[test]
+fn update_local_state_patch_rejects_wrong_nested_and_outer_types() {
+ for value in [
+ serde_json::json!({"encryptionKey": false}),
+ serde_json::json!({"onboardingTasks": []}),
+ serde_json::json!({"keyringConsent": {"consentedAtMs": "17"}}),
+ ] {
+ assert!(
+ serde_json::from_value::<UpdateLocalStateParams>(value).is_err(),
+ "malformed app_state patch types are rejected"
+ );
+ }
}