Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(settings): own-property check for the doctor severity fallback

M3gA-Mind4fb1ac73b77e
diff --git a/app/src/components/settings/panels/SystemDiagnostics.doctor.test.tsx b/app/src/components/settings/panels/SystemDiagnostics.doctor.test.tsx
index 7ae41ff799..a40db2c409 100644
--- a/app/src/components/settings/panels/SystemDiagnostics.doctor.test.tsx
+++ b/app/src/components/settings/panels/SystemDiagnostics.doctor.test.tsx
@@ -86,7 +86,10 @@ describe('<SystemDiagnostics /> doctor report', () => {
callCoreRpc.mockResolvedValueOnce({
result: {
...report,
- findings: [{ ...report.findings[1], severity: 'critical', message: 'From a newer core.' }],
+ findings: [
+ { ...report.findings[1], severity: 'critical', message: 'From a newer core.' },
+ { ...report.findings[1], severity: 'constructor', message: 'Prototype-named severity.' },
+ ],
},
logs: [],
});
@@ -96,6 +99,8 @@ describe('<SystemDiagnostics /> doctor report', () => {
expect(await screen.findByText('From a newer core.')).toBeInTheDocument();
expect(screen.getByText('critical')).toBeInTheDocument();
+ expect(screen.getByText('Prototype-named severity.')).toBeInTheDocument();
+ expect(screen.getByText('constructor')).toBeInTheDocument();
});
it('requests the live tier only after the user confirms the token warning', async () => {
diff --git a/app/src/components/settings/panels/SystemDiagnostics.tsx b/app/src/components/settings/panels/SystemDiagnostics.tsx
index dc89aff749..57c52d3e3a 100644
--- a/app/src/components/settings/panels/SystemDiagnostics.tsx
+++ b/app/src/components/settings/panels/SystemDiagnostics.tsx
@@ -250,8 +250,15 @@ const DoctorRow = () => {
key={`${finding.check_id}:${finding.severity}:${index}`}
className="rounded-lg border border-line-subtle p-3">
<div className="flex flex-wrap items-start gap-2">
- <Badge variant={severityBadge[finding.severity] ?? 'neutral'}>
- {finding.severity in severityBadge
+ {/* Own-property check: an unknown severity such as
+ `constructor` must not hit Object.prototype. */}
+ <Badge
+ variant={
+ Object.hasOwn(severityBadge, finding.severity)
+ ? severityBadge[finding.severity]
+ : 'neutral'
+ }>
+ {Object.hasOwn(severityBadge, finding.severity)
? t(`${textKey}.severity.${finding.severity}`)
: String(finding.severity)}
</Badge>