Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

chore: remove delegate agent config from doctor checks and tool wiring

Steven Enamakel5e9f6aa8d868
diff --git a/crates/openhuman-core/src/agent/session_host/builder/factory.rs b/crates/openhuman-core/src/agent/session_host/builder/factory.rs
index 3c8ea19dd4..57386167df 100644
--- a/crates/openhuman-core/src/agent/session_host/builder/factory.rs
+++ b/crates/openhuman-core/src/agent/session_host/builder/factory.rs
@@ -216,7 +216,6 @@ impl OpenHumanSessionHost {
&tool_config.browser,
&tool_config.http_request,
&tool_config.action_dir,
- &tool_config.agents,
&tool_config,
workspace_descriptor
.as_ref()
diff --git a/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs b/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs
index 20085a7006..aa3f3a5e23 100644
--- a/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs
+++ b/crates/openhuman-core/src/agent/session_host/runtime_session/prompt_refresh_tests.rs
@@ -249,6 +249,7 @@ fn resumed<'a>(prefix: &'a PrefixSnapshot, history: &'a [Message]) -> SessionSta
transcript_target: None,
committed_turns: 1,
resumed: true,
+ identity: None,
}
}
diff --git a/crates/openhuman-core/src/agent/tinyagents/observability/event_projection_cache_layout.rs b/crates/openhuman-core/src/agent/tinyagents/observability/event_projection_cache_layout.rs
index 4cf52e7371..f8660a99ea 100644
--- a/crates/openhuman-core/src/agent/tinyagents/observability/event_projection_cache_layout.rs
+++ b/crates/openhuman-core/src/agent/tinyagents/observability/event_projection_cache_layout.rs
@@ -21,3 +21,5 @@ pub(crate) fn surface_cache_layout_events(model: &str, events: &[CacheLayoutEven
);
}
}
+use tinyagents_harness::cache::CacheLayoutEvent;
+
diff --git a/crates/openhuman-core/src/core/cli/help.rs b/crates/openhuman-core/src/core/cli/help.rs
index 384518f05f..787db3fcad 100644
--- a/crates/openhuman-core/src/core/cli/help.rs
+++ b/crates/openhuman-core/src/core/cli/help.rs
@@ -1,5 +1,5 @@
use super::super::all;
-use crate::core::{ControllerSchema, TypeSchema};
+use crate::core::ControllerSchema;
use std::collections::BTreeMap;
/// Prints the general help message listing available commands and namespaces.
diff --git a/crates/openhuman-core/src/doctor/checks/inference.rs b/crates/openhuman-core/src/doctor/checks/inference.rs
index af7c87b6e7..e5cd6e7bd7 100644
--- a/crates/openhuman-core/src/doctor/checks/inference.rs
+++ b/crates/openhuman-core/src/doctor/checks/inference.rs
@@ -482,18 +482,6 @@ fn temperature(config: &Config) -> Vec<Finding> {
}
}
- let mut agent_ids = config.agents.keys().collect::<Vec<_>>();
- agent_ids.sort();
- for (index, agent_id) in agent_ids.into_iter().enumerate() {
- if let Some(temperature) = config.agents[agent_id].temperature {
- add_temperature_finding(
- &mut findings,
- &format!("agents[{index}].temperature"),
- temperature,
- );
- }
- }
-
findings
}
diff --git a/crates/openhuman-core/src/doctor/checks/inference_tests.rs b/crates/openhuman-core/src/doctor/checks/inference_tests.rs
index 144b6c87e9..1067f6d4d9 100644
--- a/crates/openhuman-core/src/doctor/checks/inference_tests.rs
+++ b/crates/openhuman-core/src/doctor/checks/inference_tests.rs
@@ -564,23 +564,13 @@ async fn an_out_of_range_temperature_reports_the_role_setting() {
}
#[tokio::test]
-async fn invalid_role_and_agent_temperatures_report_their_config_paths() {
+async fn invalid_role_and_route_temperatures_report_their_config_paths() {
let mut config = Config::default();
config.chat_provider = Some("openai:[email protected]".to_owned());
config.model_routes = vec![crate::config::ModelRouteConfig {
hint: "reasoning".to_owned(),
model: "openai:[email protected]".to_owned(),
}];
- config.agents.insert(
- "delegate-test".to_owned(),
- crate::config::DelegateAgentConfig {
- model: "openrouter/example".to_owned(),
- system_prompt: None,
- temperature: Some(f64::NAN),
- max_depth: 3,
- },
- );
-
let findings = run_only(config, TEMPERATURE).await;
let paths = findings
.iter()
@@ -591,7 +581,6 @@ async fn invalid_role_and_agent_temperatures_report_their_config_paths() {
for expected in [
"chat_provider",
"model_routes[0].model",
- "agents[0].temperature",
] {
assert!(
paths.contains(&expected),
diff --git a/crates/openhuman-core/src/doctor/checks/runtime_settings.rs b/crates/openhuman-core/src/doctor/checks/runtime_settings.rs
index 815d062f37..aaff0509be 100644
--- a/crates/openhuman-core/src/doctor/checks/runtime_settings.rs
+++ b/crates/openhuman-core/src/doctor/checks/runtime_settings.rs
@@ -71,18 +71,6 @@ fn runtime_settings(config: &Config) -> Vec<Finding> {
}
}
- let mut agent_names = config.agents.keys().collect::<Vec<_>>();
- agent_names.sort();
- for (index, agent_name) in agent_names.into_iter().enumerate() {
- if config.agents[agent_name].model.trim().is_empty() {
- findings.push(warning(
- &format!("agents[{index}].model"),
- "A delegated agent has no model configured.",
- "Set a model for the delegated agent at the reported index.",
- ));
- }
- }
-
if config.components.channels {
if has_configured_channel(config) {
findings.push(pass(
diff --git a/crates/openhuman-core/src/doctor/checks/runtime_settings_tests.rs b/crates/openhuman-core/src/doctor/checks/runtime_settings_tests.rs
index 69449b8d90..27b8d1ab87 100644
--- a/crates/openhuman-core/src/doctor/checks/runtime_settings_tests.rs
+++ b/crates/openhuman-core/src/doctor/checks/runtime_settings_tests.rs
@@ -18,7 +18,7 @@ async fn run_check(config: crate::config::Config) -> Vec<crate::doctor::Finding>
#[tokio::test]
async fn former_runtime_settings_findings_keep_their_paths_without_exposing_values() {
- use crate::config::{DelegateAgentConfig, ModelRouteConfig};
+ use crate::config::ModelRouteConfig;
let mut config = crate::config::Config::default();
config.reliability.fallback_providers = vec!["private-model-name".to_owned()];
@@ -32,16 +32,6 @@ async fn former_runtime_settings_findings_keep_their_paths_without_exposing_valu
model: "private-model-name".to_owned(),
},
];
- let delegate = DelegateAgentConfig {
- model: String::new(),
- system_prompt: None,
- temperature: None,
- max_depth: 3,
- };
- config
- .agents
- .insert("private-agent-name".to_owned(), delegate);
-
let findings = run_check(config).await;
let paths = findings
.iter()
@@ -53,7 +43,6 @@ async fn former_runtime_settings_findings_keep_their_paths_without_exposing_valu
"reliability.fallback_providers",
"model_routes[0].model",
"model_routes[1].hint",
- "agents[0].model",
] {
assert!(
paths.contains(&path),
diff --git a/crates/openhuman-core/src/tools/ops.rs b/crates/openhuman-core/src/tools/ops.rs
index 491ba4b941..eaaaf5033a 100644
--- a/crates/openhuman-core/src/tools/ops.rs
+++ b/crates/openhuman-core/src/tools/ops.rs
@@ -89,7 +89,6 @@ pub fn all_tools_with_runtime(
browser_config,
http_config,
action_dir,
- agents,
root_config,
approval_workspace_root,
)
@@ -110,7 +109,6 @@ pub fn all_tools_with_runtime_and_pack_handle(
browser_config: &crate::config::BrowserConfig,
http_config: &crate::config::HttpRequestConfig,
action_dir: &std::path::Path,
- agents: &HashMap<String, DelegateAgentConfig>,
root_config: &crate::config::Config,
approval_workspace_root: Option<&std::path::Path>,
) -> (
diff --git a/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests.rs b/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests.rs
index 057a69e163..4a8d1313ac 100644
--- a/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests.rs
+++ b/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests.rs
@@ -47,7 +47,9 @@ impl Tool for FakeTool {
}
/// A registry holding several real packed tools plus the two pack tools, bound.
-fn registry_with_all(names: &[&'static str]) -> Arc<Vec<Box<dyn Tool>>> {
+fn registry_with_all(
+ names: &[&'static str],
+) -> (Arc<Vec<Box<dyn Tool>>>, tinyagents_harness_tools::skills::PackRegistryHandle) {
let mut tools: Vec<Box<dyn Tool>> = names
.iter()
.map(|name| {
@@ -59,24 +61,27 @@ fn registry_with_all(names: &[&'static str]) -> Arc<Vec<Box<dyn Tool>>> {
}) as Box<dyn Tool>
})
.collect();
- append_pack_tools(&mut tools);
+ let handle = append_pack_tools(&mut tools);
let tools = Arc::new(tools);
- bind_pack_registry(&tools);
- tools
+ bind_pack_registry(&handle, &tools);
+ (tools, handle)
}
/// A registry holding one real packed tool plus the two pack tools, bound.
-fn registry_with(name: &'static str, level: PermissionLevel) -> Arc<Vec<Box<dyn Tool>>> {
+fn registry_with(
+ name: &'static str,
+ level: PermissionLevel,
+) -> (Arc<Vec<Box<dyn Tool>>>, tinyagents_harness_tools::skills::PackRegistryHandle) {
let mut tools: Vec<Box<dyn Tool>> = vec![Box::new(FakeTool {
name,
level,
external: false,
timeout: ToolTimeout::Inherit,
})];
- append_pack_tools(&mut tools);
+ let handle = append_pack_tools(&mut tools);
let tools = Arc::new(tools);
- bind_pack_registry(&tools);
- tools
+ bind_pack_registry(&handle, &tools);
+ (tools, handle)
}
fn find<'a>(tools: &'a [Box<dyn Tool>], name: &str) -> &'a dyn Tool {
diff --git a/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests_scoping_and_visibility_tests.rs b/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests_scoping_and_visibility_tests.rs
index 2c06702514..aaf2d29019 100644
--- a/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests_scoping_and_visibility_tests.rs
+++ b/crates/openhuman-core/src/tools/toolpacks/toolpacks_tests_scoping_and_visibility_tests.rs
@@ -329,7 +329,7 @@ fn retired_specialist_aliases_are_not_packed() {
/// schema, leaving unrelated packs available to direct calls.
#[test]
fn spawn_tool_schema_closes_only_reachable_specialist_packs() {
- let raw = registry_with_all(&[
+ let (raw, _handle) = registry_with_all(&[
"skill_registry_install",
"media_generate_image",
"propose_workflow",
diff --git a/crates/openhuman-core/src/tools/traits_tests.rs b/crates/openhuman-core/src/tools/traits_tests.rs
index c4a8418255..161b973021 100644
--- a/crates/openhuman-core/src/tools/traits_tests.rs
+++ b/crates/openhuman-core/src/tools/traits_tests.rs
@@ -46,12 +46,6 @@ async fn a_tool_written_against_this_path_satisfies_the_shared_trait() {
assert_eq!(erased.category(), ToolCategory::System);
}
-#[test]
-fn a_tool_carrying_no_host_extension_has_no_delegation_target() {
- let tool = DummyTool;
- assert!(delegation_target(&tool).is_none());
-}
-
#[test]
fn spec_uses_tool_metadata_and_schema() {
let spec = DummyTool.spec();
diff --git a/crates/openhuman-core/src/web_chat/progress_bridge_attribution.rs b/crates/openhuman-core/src/web_chat/progress_bridge_attribution.rs
index cd8ce211c0..643ec7afb5 100644
--- a/crates/openhuman-core/src/web_chat/progress_bridge_attribution.rs
+++ b/crates/openhuman-core/src/web_chat/progress_bridge_attribution.rs
@@ -1,26 +1,3 @@
-/// Build the worktree-isolation slice of a `subagent_completed`
-/// [`SubagentProgressDetail`] (#3376). An empty `changed_files` collapses to
-/// `None` so the renderer omits an empty "changed files" list rather than
-/// showing "0 files"; a non-empty list is forwarded verbatim. `worktree_path`
-/// / `dirty_status` pass through (`None` for non-isolated workers). Split out
-/// so the empty/non-empty branch is unit-testable without a live DB + channel.
-fn subagent_worktree_detail(
- worktree_path: Option<String>,
- changed_files: Vec<String>,
- dirty_status: Option<bool>,
-) -> SubagentProgressDetail {
- SubagentProgressDetail {
- worktree_path,
- changed_files: if changed_files.is_empty() {
- None
- } else {
- Some(changed_files)
- },
- dirty_status,
- ..Default::default()
- }
-}
-
/// Trace user attribution for a turn whose stored user payload carries no identity
/// (headless / autonomous / freshly booted cores): read the on-disk
/// app-session profile and return the user's email (preferred) or backend