Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(storage): ensure status store creation handles errors

Steven Enamakel646d07c34608
diff --git a/crates/openhuman-core/src/agent/session_host/runtime_adapter_trace_tests.rs b/crates/openhuman-core/src/agent/session_host/runtime_adapter_trace_tests.rs
index b8c8314648..1fe18f75c0 100644
--- a/crates/openhuman-core/src/agent/session_host/runtime_adapter_trace_tests.rs
+++ b/crates/openhuman-core/src/agent/session_host/runtime_adapter_trace_tests.rs
@@ -164,6 +164,7 @@ async fn cancellation_during_required_output_repair_finalizes_native_run() {
AgentEvent::RunCompleted { run_id: completed, .. } if completed.as_str() == run_id
)));
let status = crate::storage::sessions::status_store_for(&workspace)
+ .expect("status store")
.get_status(&run_id)
.await
.expect("status lookup")
diff --git a/crates/openhuman-core/src/agent/tinyagents/reaper_tests.rs b/crates/openhuman-core/src/agent/tinyagents/reaper_tests.rs
index 901677f3d2..9a6102f739 100644
--- a/crates/openhuman-core/src/agent/tinyagents/reaper_tests.rs
+++ b/crates/openhuman-core/src/agent/tinyagents/reaper_tests.rs
@@ -25,7 +25,7 @@ async fn seed_status(store: &DriverStatusStore, status_kind: ExecutionStatus) ->
async fn workspace_adapter_reaps_and_empty_workspace_is_a_noop() {
let tmp = std::env::temp_dir().join(format!("oh-reaper-{}", uuid::Uuid::new_v4()));
assert_eq!(reap_orphaned_runs(&tmp).await, 0);
- let store = crate::storage::sessions::status_store_for(&tmp);
+ let store = crate::storage::sessions::status_store_for(&tmp).expect("status store");
let run = seed_status(&store, ExecutionStatus::Running).await;
assert_eq!(reap_orphaned_runs(&tmp).await, 1);
let status = store.get_status(&run).await.unwrap().expect("present");
@@ -38,7 +38,7 @@ async fn workspace_adapter_reaps_and_empty_workspace_is_a_noop() {
#[tokio::test]
async fn a_shared_backend_leaves_running_work_alone() {
let tmp = std::env::temp_dir().join(format!("oh-reaper-{}", uuid::Uuid::new_v4()));
- let store = crate::storage::sessions::status_store_for(&tmp);
+ let store = crate::storage::sessions::status_store_for(&tmp).expect("status store");
let run = seed_status(&store, ExecutionStatus::Running).await;
assert_eq!(reap_unless_shared(&tmp, true).await, 0);
let status = store.get_status(&run).await.unwrap().expect("present");
@@ -79,7 +79,7 @@ async fn a_build_only_runtime_is_swept_before_it_can_be_invoked() {
// `OPENHUMAN_WORKSPACE` names the root; the resolved workspace is the
// `workspace` directory under it, which is what the sweep will read.
let workspace = tmp.join("workspace");
- let store = crate::storage::sessions::status_store_for(&workspace);
+ let store = crate::storage::sessions::status_store_for(&workspace).expect("status store");
let orphan = seed_status(&store, ExecutionStatus::Running).await;
assert_eq!(store.list_active().await.unwrap().len(), 1);
@@ -107,7 +107,7 @@ async fn a_build_only_runtime_is_swept_before_it_can_be_invoked() {
// The child writes the durable store in a separate process. Reopen it for
// verification instead of reading through the parent's handle, whose
// refactored KV layer may still serve the status it cached while seeding.
- let after_store = crate::storage::sessions::status_store_for(&workspace);
+ let after_store = crate::storage::sessions::status_store_for(&workspace).expect("status store");
let after = after_store
.get_status(&orphan)
.await
diff --git a/crates/openhuman-core/src/storage/sessions/workspace.rs b/crates/openhuman-core/src/storage/sessions/workspace.rs
index 5e13af1c32..98f684d8e6 100644
--- a/crates/openhuman-core/src/storage/sessions/workspace.rs
+++ b/crates/openhuman-core/src/storage/sessions/workspace.rs
@@ -71,6 +71,11 @@ pub fn provider_for_workspace(workspace_dir: &Path) -> Arc<dyn SessionStoreProvi
/// The provider over `workspace_dir`'s default backend, installed or not.
pub(super) fn fallback_provider(workspace_dir: &Path) -> Arc<dyn SessionStoreProvider> {
+ if crate::core::runtime::is_saas() && crate::storage::installed().is_none() {
+ return refusing_provider(
+ "no host storage backend is installed for this SaaS session".to_owned(),
+ );
+ }
let backend = match crate::storage::local::backend_for(workspace_dir) {
Ok(backend) => backend,
Err(error) => {
diff --git a/crates/openhuman-core/src/storage/sessions/workspace_tests.rs b/crates/openhuman-core/src/storage/sessions/workspace_tests.rs
index 2208b1d069..fde5464d7e 100644
--- a/crates/openhuman-core/src/storage/sessions/workspace_tests.rs
+++ b/crates/openhuman-core/src/storage/sessions/workspace_tests.rs
@@ -55,7 +55,7 @@ fn an_attachment_stash_and_artifact_blobs_bind_the_tenant_scope() {
#[test]
fn a_run_status_store_is_built_for_the_workspace() {
let ws = scratch();
- let _status = status_store_for(ws.path());
+ let _status = status_store_for(ws.path()).expect("status store");
}
#[test]