Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(storage): silence await_holding_lock in storage slot tests

Steven Enamakel6b3a50641cd8
diff --git a/crates/openhuman-core/src/flows/catalog_storage_tests.rs b/crates/openhuman-core/src/flows/catalog_storage_tests.rs
index c8dfbb445b..f3d0a3a2e6 100644
--- a/crates/openhuman-core/src/flows/catalog_storage_tests.rs
+++ b/crates/openhuman-core/src/flows/catalog_storage_tests.rs
@@ -278,6 +278,7 @@ async fn catalog_module_uses_captured_profile_and_storage_preserves_cas_metadata
}
#[tokio::test]
+#[allow(clippy::await_holding_lock)] // Serializes access to the process-wide installed storage slot.
async fn catalog_storage_resolves_the_current_backend_and_confines_graph_namespace_queries() {
use tinyflows_bus::catalog::{
CatalogCollectionSpec, CatalogDocumentPrecondition, CatalogFilter, CatalogQuery,
diff --git a/crates/openhuman-core/src/profiles/cron_tests.rs b/crates/openhuman-core/src/profiles/cron_tests.rs
index 6cc26887f7..ed468ec4c9 100644
--- a/crates/openhuman-core/src/profiles/cron_tests.rs
+++ b/crates/openhuman-core/src/profiles/cron_tests.rs
@@ -81,6 +81,7 @@ async fn hosted_cron_sweep_runs_trusted_memory_jobs_in_agent_only_profiles() {
hosted_memory_cron_sweep_child().await;
}
+#[allow(clippy::await_holding_lock)] // Serializes access to the process-wide installed storage slot.
async fn hosted_memory_cron_sweep_child() {
let _storage_slot = crate::storage::test_support::lock_storage_slot();
let registry = crate::storage::fence::registry();
diff --git a/crates/openhuman-core/src/profiles/host_migration_fence_tests.rs b/crates/openhuman-core/src/profiles/host_migration_fence_tests.rs
index 06d877f535..efe9db8189 100644
--- a/crates/openhuman-core/src/profiles/host_migration_fence_tests.rs
+++ b/crates/openhuman-core/src/profiles/host_migration_fence_tests.rs
@@ -1,6 +1,7 @@
use super::*;
#[tokio::test]
+#[allow(clippy::await_holding_lock)] // Serializes access to the process-wide installed storage slot.
async fn provisioning_with_a_new_root_replaces_a_dead_higher_epoch_fence() {
const CHILD: &str = "OPENHUMAN_PROFILE_DEAD_HIGHER_FENCE_CHILD";
if std::env::var_os(CHILD).is_none() {
@@ -71,6 +72,7 @@ async fn provisioning_with_a_new_root_replaces_a_dead_higher_epoch_fence() {
}
#[tokio::test]
+#[allow(clippy::await_holding_lock)] // Serializes access to the process-wide installed storage slot.
async fn opening_replaces_a_dropped_hosts_fence_before_cron_reconciliation() {
const CHILD: &str = "OPENHUMAN_PROFILE_REOPEN_DROPPED_FENCE_CHILD";
if std::env::var_os(CHILD).is_none() {
diff --git a/crates/openhuman-core/src/storage/mod.rs b/crates/openhuman-core/src/storage/mod.rs
index f994ba3d12..93dabdd7f5 100644
--- a/crates/openhuman-core/src/storage/mod.rs
+++ b/crates/openhuman-core/src/storage/mod.rs
@@ -113,12 +113,12 @@ pub trait DocumentStoreExt: tinystoragedrivers_api::DocumentStoreExt {
impl<T: tinystoragedrivers_api::DocumentStoreExt + ?Sized> DocumentStoreExt for T {}
+type StorageTask = Box<dyn FnOnce(&tokio::runtime::Runtime) + Send>;
+
/// Dedicated runtime for synchronous domain surfaces that bridge to the
/// asynchronous storage ports. Keeping it on its own thread also permits a
/// synchronous facade to be called while the caller is on a current-thread
/// Tokio runtime.
-type StorageTask = Box<dyn FnOnce(&tokio::runtime::Runtime) + Send>;
-
struct Blocking {
tasks: mpsc::Sender<StorageTask>,
}
diff --git a/crates/openhuman-core/src/storage/schema_support_tests.rs b/crates/openhuman-core/src/storage/schema_support_tests.rs
index beed7ef59c..25795af3ab 100644
--- a/crates/openhuman-core/src/storage/schema_support_tests.rs
+++ b/crates/openhuman-core/src/storage/schema_support_tests.rs
@@ -75,7 +75,7 @@ fn owner_conversion_preserves_driver_times_and_absolute_expiry() {
updated_ms: Some(200),
};
let converted = map_legacy_collection(vec![source], "legacy", |rows| {
- Ok(rows
+ rows
.into_iter()
.map(|row| {
Ok(
@@ -83,7 +83,7 @@ fn owner_conversion_preserves_driver_times_and_absolute_expiry() {
.source_metadata(row.meta),
)
})
- .collect::<anyhow::Result<Vec<_>>>()?)
+ .collect::<anyhow::Result<Vec<_>>>()
})
.unwrap();