Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

chore(orchestrator): update agent routing comments and tests

Steven Enamakel7587c136f3bc
diff --git a/crates/openhuman-core/src/agent_registry/agents/orchestrator/agent.toml b/crates/openhuman-core/src/agent_registry/agents/orchestrator/agent.toml
index d15aa75d9c..36b299c579 100644
--- a/crates/openhuman-core/src/agent_registry/agents/orchestrator/agent.toml
+++ b/crates/openhuman-core/src/agent_registry/agents/orchestrator/agent.toml
@@ -96,8 +96,7 @@ allowlist = [
# skills from community registries (OpenHuman, HermesHub, ClawHub).
# Running an installed skill is the orchestrator's own `run_workflow`.
"skill_setup",
- # Workflow-authoring specialist (Phase 5a). Synthesised into a
- # `build_workflow` tool at agent-build time. Route any "set up a workflow
+ # Workflow-authoring specialist. Route any "set up a workflow
# that…", "automate…", "when X happens do Y", or "build/edit an automation
# or flow" request here — it grounds nodes in real tool slugs + connections,
# can sandbox dry-run a draft, and returns a workflow PROPOSAL for the user
@@ -105,8 +104,7 @@ allowlist = [
# Calls run asynchronously. Reuse the same task_key to continue this
# proposal or answer a clarification without creating another child.
"workflow_builder",
- # Workflow-discovery specialist (the "Flow Scout"). Synthesised into a
- # `discover_workflows` tool at agent-build time. Route "what workflows
+ # Workflow-discovery specialist (the "Flow Scout"). Route "what workflows
# should I set up?", "suggest some automations", or "discover flows for me"
# here — it reads the user's memory/threads/connections/flows read-only and
# records concrete, buildable suggestions for the Flows page. It never
@@ -116,7 +114,7 @@ allowlist = [
# NOTE: `summarizer` is not listed. It is runtime-only: the oversized
# tool-result hook resolves it from the registry
# (`context.summarizer_payload_threshold_tokens`, default 4000), and it
- # never gets a delegate tool.
+ # is only reached by runtime summarization and is not model-callable.
{ skills = "*" },
]
@@ -154,8 +152,8 @@ named = [
# strips this name from the allowlist and keeps the deferred set beside it
# (`agent/session_host/builder/builder_build.rs`).
"tool_search",
- # The orchestrator runs installed skills itself; installation stays on the
- # `setup_skills` hand-off.
+ # The orchestrator runs installed skills itself; installation is routed to
+ # `skill_setup` through `spawn_subagent`.
"run_workflow",
# `ask_user_clarification` is deliberately absent. On the chat surface it
# is a no-op with a schema cost: it ends the turn with the question as the
diff --git a/crates/openhuman-core/src/agent_registry/agents/orchestrator/prompt_tests_session_routing_tests.rs b/crates/openhuman-core/src/agent_registry/agents/orchestrator/prompt_tests_session_routing_tests.rs
index ec28346323..bb595f1472 100644
--- a/crates/openhuman-core/src/agent_registry/agents/orchestrator/prompt_tests_session_routing_tests.rs
+++ b/crates/openhuman-core/src/agent_registry/agents/orchestrator/prompt_tests_session_routing_tests.rs
@@ -31,51 +31,20 @@ fn a_thread_renamed_session_still_resolves_to_its_registry_entry() {
);
}
-/// The generated block must actually render for a real, renamed session.
-///
-/// The first live capture had every `prompt.md` edit in it and no block, which
-/// only a silent early return can produce. Pin the whole path: a renamed agent
-/// id, a visible set that withholds the packed delegates, and at least one row
-/// naming a real route.
+/// There is no longer a synthesized specialist catalogue: the registered
+/// spawn tool carries the allowed agent ids in its own schema.
#[test]
-fn the_withheld_block_renders_for_a_renamed_session_with_a_filter() {
+fn retired_withheld_specialist_block_is_empty() {
crate::agent_registry::host_definition::AgentDefinitionRegistry::init_global_builtins()
.expect("builtin agent definitions must load");
// A visible set shaped like the live one: the advertised delegates are in,
// the packed ones are not.
- let visible: HashSet<String> = ["file_read", "goal_complete"]
- .iter()
- .map(|s| s.to_string())
- .collect();
+ let visible: HashSet<String> = ["spawn_subagent".to_string()].into_iter().collect();
let mut ctx = ctx_with(&[]);
ctx.agent_id = "orchestrator_thread-captu";
ctx.visible_tool_names = &visible;
-
- let block = render_withheld_specialists(&ctx);
- assert!(
- block.starts_with("## Capabilities not in your tool list"),
- "expected the generated heading, got: {:?}",
- block.chars().take(120).collect::<String>()
- );
- // A packed delegate no Cargo feature gates must always render with its
- // route; this is the row that pins the block in every build profile.
- assert!(
- block.contains("`tasks` (`manage_tasks`"),
- "a packed delegate must render with its route:\n{block}"
- );
- // `make_presentation` is a `documents`-gated skill: under `default` it is
- // not compiled and its row cannot render, so expecting it unconditionally
- // reads as a broken block (which is how openhuman#6507 came to be filed
- // and retracted). Assert it exactly when the feature is on, and assert its
- // absence when it is off, so the expectation tracks the build profile.
- let presentation_row = block.contains("`documents` (`make_presentation`");
- assert_eq!(
- presentation_row,
- cfg!(feature = "documents"),
- "the `documents` row must render exactly when the `documents` feature is enabled \
- (see openhuman#6512):\n{block}"
- );
+ assert!(render_withheld_specialists(&ctx).is_empty());
}
/// The generated intro must not carry the source's line-continuation padding.
@@ -158,7 +127,7 @@ fn prompt_routes_workflow_authoring_to_the_builder_not_use_skill() {
fn skill_sections_name_the_hand_off_this_session_can_call() {
crate::agent_registry::host_definition::AgentDefinitionRegistry::init_global_builtins()
.expect("builtin agent definitions must load");
- let belt: HashSet<String> = ["setup_skills", "run_workflow", "file_read", "use_skill"]
+ let belt: HashSet<String> = ["spawn_subagent", "run_workflow", "file_read", "use_skill"]
.iter()
.map(|s| s.to_string())
.collect();
@@ -168,14 +137,14 @@ fn skill_sections_name_the_hand_off_this_session_can_call() {
assert_eq!(
hand_off_route(&ctx, "skill_setup").as_deref(),
- Some("`setup_skills`")
+ Some("`spawn_subagent` with agent_id `skill_setup`")
);
// Running a skill is the orchestrator's own `run_workflow`, not a hand-off.
assert_eq!(run_workflow_route(&ctx).as_deref(), Some("`run_workflow`"));
// Listed but held by a pack: name the call that actually reaches it.
assert_eq!(
hand_off_route(&ctx, "image_agent").as_deref(),
- Some("`create_image` (`use_skill` skill `media`)")
+ Some("`spawn_subagent` with agent_id `image_agent`")
);
// Not in the orchestrator's allowlist: no route, so name nothing.
assert_eq!(hand_off_route(&ctx, "summarizer"), None);
@@ -183,7 +152,7 @@ fn skill_sections_name_the_hand_off_this_session_can_call() {
// The generated withheld block no longer lists the unpacked hand-offs.
let block = render_withheld_specialists(&ctx);
- for handoff in ["setup_skills", "run_workflow"] {
+ for handoff in ["spawn_subagent", "run_workflow"] {
assert!(
!block.contains(handoff),
"`{handoff}` is a direct tool and must not be listed as withheld:\n{block}"
@@ -193,7 +162,7 @@ fn skill_sections_name_the_hand_off_this_session_can_call() {
// A packed route needs `use_skill` on the belt. A session filtered down to
// neither the delegate nor `use_skill` cannot reach the specialist at all,
// and naming a call it cannot make is the bug, not the fix.
- let no_use_skill: HashSet<String> = ["setup_skills", "file_read"]
+ let no_use_skill: HashSet<String> = ["file_read"]
.iter()
.map(|s| s.to_string())
.collect();
@@ -210,8 +179,8 @@ fn skill_sections_name_the_hand_off_this_session_can_call() {
);
assert_eq!(
hand_off_route(&ctx, "skill_setup").as_deref(),
- Some("`setup_skills`"),
- "a delegate on the belt is still a direct route"
+ None,
+ "without spawn_subagent there is no model-facing specialist route"
);
}