Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

refactor(session_host): drop transcript locator memo and rename stop summary

Steven Enamakela8801cd06af2
diff --git a/crates/openhuman-core/src/agent/session_host/builder/builder_build.rs b/crates/openhuman-core/src/agent/session_host/builder/builder_build.rs
index 008a1f1c52..0658229d73 100644
--- a/crates/openhuman-core/src/agent/session_host/builder/builder_build.rs
+++ b/crates/openhuman-core/src/agent/session_host/builder/builder_build.rs
@@ -458,7 +458,6 @@ impl SessionHostBuilder {
// `subagents` declaration against the global registry.
agent_definition_id: agent_definition_name.clone(),
session_history_locator: self.session_history_locator,
- session_history_locator_memo: std::sync::OnceLock::new(),
session_key: {
let unix_ts = std::time::SystemTime::now()
.duration_since(std::time::UNIX_EPOCH)
diff --git a/crates/openhuman-core/src/agent/session_host/stop_summary.rs b/crates/openhuman-core/src/agent/session_host/stop_policy.rs
similarity index 100%
rename from crates/openhuman-core/src/agent/session_host/stop_summary.rs
rename to crates/openhuman-core/src/agent/session_host/stop_policy.rs
diff --git a/crates/openhuman-core/src/agent/session_host/types.rs b/crates/openhuman-core/src/agent/session_host/types.rs
index 41631bfd5e..fe2e8025d8 100644
--- a/crates/openhuman-core/src/agent/session_host/types.rs
+++ b/crates/openhuman-core/src/agent/session_host/types.rs
@@ -327,35 +327,11 @@ pub struct OpenHumanSessionHost {
/// Injected transcript locator, or `None` to resolve the session store for
/// this agent key.
///
- /// The single injection point for the whole transcript seam: it resolves
- /// both resume reads (`latest_for_agent`, `root_for_thread`) and binds this
- /// session's write handle (`open_stem`). `None` is the production default
- /// and is resolved *lazily* by
- /// [`OpenHumanSessionHost::session_locator`][Self::session_locator] into the
- /// session store's transcripts for the **current** `workspace_dir` — never
- /// captured at build time, because callers (tests especially) reassign
- /// `workspace_dir` after `build()` and a frozen locator would silently keep
- /// reading the old directory.
+ /// Optional transcript locator used by focused session-host tests and
+ /// embedders that supply their own durable transcript store. Production
+ /// thread-bound sessions use `SessionIdentityResolver` admission instead.
pub(super) session_history_locator:
Option<std::sync::Arc<dyn tinyagents_session::transcript::TranscriptLocator>>,
- /// First-call memo for [`OpenHumanSessionHost::session_locator`][Self::session_locator]'s
- /// lazily-resolved store locator (the `session_history_locator` `None` branch).
- ///
- /// tinyagents' `SessionBuilder` only accepts a later transcript-target
- /// change when it is the *same* locator object (`Arc::ptr_eq`), not merely
- /// an equivalent one — see `tinyagents_session::transcript`'s
- /// `TranscriptTarget::same_binding`. `session_locator` is called from more
- /// than one place while building a session's runtime turn machinery (the
- /// `before_resume` resume target and the eager construction-time bind), and
- /// without this memo each call minted a fresh `Arc` over the same
- /// destination, so the second bind was rejected with "cannot change a
- /// transcript target after it is bound or committed" even though both
- /// calls agreed on the file. `OnceLock` keeps the resolution lazy — still
- /// read from `workspace_dir` at first use, not frozen at struct-build time
- /// — while guaranteeing every later caller in this host's lifetime gets
- /// back the identical `Arc`.
- pub(super) session_history_locator_memo:
- std::sync::OnceLock<std::sync::Arc<dyn tinyagents_session::transcript::TranscriptLocator>>,
/// Unique transcript key for this session, formatted as
/// `"{unix_ts}_{agent_id}"`. Generated once at agent-build time so
/// every transcript write in this session uses the same filename