Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(threads): move transcript ordering test to its own module

Steven Enamakelbaea227e5b4c
diff --git a/crates/openhuman-core/src/threads/turn_state/mirror_observe_tests.rs b/crates/openhuman-core/src/threads/turn_state/mirror_observe_tests.rs
index 65229d99f0..3babbf6650 100644
--- a/crates/openhuman-core/src/threads/turn_state/mirror_observe_tests.rs
+++ b/crates/openhuman-core/src/threads/turn_state/mirror_observe_tests.rs
@@ -15,81 +15,6 @@ fn iteration_start_promotes_lifecycle_and_records_round() {
assert_eq!(s.phase, Some(TurnPhase::Thinking));
}
-#[test]
-fn transcript_interleaves_narration_thinking_and_tools_in_order() {
- let (_d, mut m) = fresh("t");
- // A turn that thinks, narrates, calls a tool, then narrates again. The
- // transcript must preserve that exact streaming order via `seq`, coalesce
- // consecutive same-kind deltas in the same round, and carry the server
- // label through onto the tool row.
- m.observe(&AgentProgress::ThinkingDelta {
- delta: "Let me ".into(),
- iteration: 1,
- });
- m.observe(&AgentProgress::ThinkingDelta {
- delta: "check.".into(),
- iteration: 1,
- });
- m.observe(&AgentProgress::TextDelta {
- delta: "Reading your inbox".into(),
- iteration: 1,
- });
- m.observe(&AgentProgress::ToolCallStarted {
- call_id: "tc-1".into(),
- tool_name: "gmail_read".into(),
- arguments: serde_json::json!({ "to": "[email protected]" }),
- iteration: 1,
- display_label: Some("Reading messages".into()),
- display_detail: Some("[email protected]".into()),
- });
- m.observe(&AgentProgress::TextDelta {
- delta: "Done.".into(),
- iteration: 1,
- });
-
- let s = m.snapshot();
- assert_eq!(
- s.transcript.len(),
- 4,
- "thinking, narration, tool, narration"
- );
- match &s.transcript[0] {
- TranscriptItem::Thinking { text, seq, .. } => {
- assert_eq!(text, "Let me check.", "coalesced same-round thinking");
- assert_eq!(*seq, 0);
- }
- other => panic!("expected thinking first, got {other:?}"),
- }
- match &s.transcript[1] {
- TranscriptItem::Narration { text, .. } => assert_eq!(text, "Reading your inbox"),
- other => panic!("expected narration, got {other:?}"),
- }
- match &s.transcript[2] {
- TranscriptItem::ToolCall { call_id, .. } => assert_eq!(call_id, "tc-1"),
- other => panic!("expected tool call, got {other:?}"),
- }
- match &s.transcript[3] {
- TranscriptItem::Narration { text, .. } => assert_eq!(text, "Done."),
- other => panic!("expected trailing narration, got {other:?}"),
- }
- // seq is strictly increasing in push order.
- let seqs: Vec<u32> = s
- .transcript
- .iter()
- .map(|i| match i {
- TranscriptItem::Narration { seq, .. }
- | TranscriptItem::Thinking { seq, .. }
- | TranscriptItem::ToolCall { seq, .. } => *seq,
- })
- .collect();
- assert_eq!(seqs, vec![0, 1, 2, 3]);
-
- // The server label/detail landed on the timeline row the transcript points to.
- let row = s.tool_timeline.iter().find(|e| e.id == "tc-1").unwrap();
- assert_eq!(row.display_name.as_deref(), Some("Reading messages"));
- assert_eq!(row.detail.as_deref(), Some("[email protected]"));
-}
-
#[test]
fn tool_call_start_and_complete_track_timeline() {
let (_d, mut m) = fresh("t");
diff --git a/crates/openhuman-core/src/threads/turn_state/mirror_tests.rs b/crates/openhuman-core/src/threads/turn_state/mirror_tests.rs
index 9bc7ff057c..cd25b0cbb1 100644
--- a/crates/openhuman-core/src/threads/turn_state/mirror_tests.rs
+++ b/crates/openhuman-core/src/threads/turn_state/mirror_tests.rs
@@ -16,3 +16,5 @@ fn fresh(thread_id: &str) -> (tempfile::TempDir, TurnStateMirror) {
mod finish_and_subagent_args_tests;
#[path = "mirror_observe_tests.rs"]
mod observe_tests;
+#[path = "mirror_transcript_tests.rs"]
+mod transcript_tests;
diff --git a/crates/openhuman-core/src/threads/turn_state/mirror_transcript_tests.rs b/crates/openhuman-core/src/threads/turn_state/mirror_transcript_tests.rs
new file mode 100644
index 0000000000..a4bbcc39d6
--- /dev/null
+++ b/crates/openhuman-core/src/threads/turn_state/mirror_transcript_tests.rs
@@ -0,0 +1,76 @@
+use super::*;
+
+#[test]
+fn transcript_interleaves_narration_thinking_and_tools_in_order() {
+ let (_d, mut m) = fresh("t");
+ // A turn that thinks, narrates, calls a tool, then narrates again. The
+ // transcript must preserve that exact streaming order via `seq`, coalesce
+ // consecutive same-kind deltas in the same round, and carry the server
+ // label through onto the tool row.
+ m.observe(&AgentProgress::ThinkingDelta {
+ delta: "Let me ".into(),
+ iteration: 1,
+ });
+ m.observe(&AgentProgress::ThinkingDelta {
+ delta: "check.".into(),
+ iteration: 1,
+ });
+ m.observe(&AgentProgress::TextDelta {
+ delta: "Reading your inbox".into(),
+ iteration: 1,
+ });
+ m.observe(&AgentProgress::ToolCallStarted {
+ call_id: "tc-1".into(),
+ tool_name: "gmail_read".into(),
+ arguments: serde_json::json!({ "to": "[email protected]" }),
+ iteration: 1,
+ display_label: Some("Reading messages".into()),
+ display_detail: Some("[email protected]".into()),
+ });
+ m.observe(&AgentProgress::TextDelta {
+ delta: "Done.".into(),
+ iteration: 1,
+ });
+
+ let s = m.snapshot();
+ assert_eq!(
+ s.transcript.len(),
+ 4,
+ "thinking, narration, tool, narration"
+ );
+ match &s.transcript[0] {
+ TranscriptItem::Thinking { text, seq, .. } => {
+ assert_eq!(text, "Let me check.", "coalesced same-round thinking");
+ assert_eq!(*seq, 0);
+ }
+ other => panic!("expected thinking first, got {other:?}"),
+ }
+ match &s.transcript[1] {
+ TranscriptItem::Narration { text, .. } => assert_eq!(text, "Reading your inbox"),
+ other => panic!("expected narration, got {other:?}"),
+ }
+ match &s.transcript[2] {
+ TranscriptItem::ToolCall { call_id, .. } => assert_eq!(call_id, "tc-1"),
+ other => panic!("expected tool call, got {other:?}"),
+ }
+ match &s.transcript[3] {
+ TranscriptItem::Narration { text, .. } => assert_eq!(text, "Done."),
+ other => panic!("expected trailing narration, got {other:?}"),
+ }
+ // seq is strictly increasing in push order.
+ let seqs: Vec<u32> = s
+ .transcript
+ .iter()
+ .map(|i| match i {
+ TranscriptItem::Narration { seq, .. }
+ | TranscriptItem::Thinking { seq, .. }
+ | TranscriptItem::ToolCall { seq, .. } => *seq,
+ })
+ .collect();
+ assert_eq!(seqs, vec![0, 1, 2, 3]);
+
+ // The server label/detail landed on the timeline row the transcript points to.
+ let row = s.tool_timeline.iter().find(|e| e.id == "tc-1").unwrap();
+ assert_eq!(row.display_name.as_deref(), Some("Reading messages"));
+ assert_eq!(row.detail.as_deref(), Some("[email protected]"));
+}