The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.
Rust agent-orchestrationai-agentsai-assistantdesktopllmlocal-firstmcppersonal-aiprivacyrustsecond-braintauri
test(schemas): refactor tests for app state schema parsing
Steven Enamakelc0ae6ca243a0
diff --git a/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs b/crates/openhuman-core/src/desktop/app_state/schemas_tests.rsindex 5528bd1012..f9779ef46f 100644--- a/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs+++ b/crates/openhuman-core/src/desktop/app_state/schemas_tests.rs@@ -80,45 +80,36 @@ fn app_state_schema_contracts_and_registration_are_preserved() {}}-#[test]-fn deserialize_update_local_state_params_empty() {- let params: UpdateLocalStateParams =- serde_json::from_value(serde_json::Value::Object(Map::new())).unwrap();- assert!(params.encryption_key.is_none());- assert!(params.onboarding_tasks.is_none());-}--#[test]-fn deserialize_update_local_state_params_with_values() {- let mut m = Map::new();- // encryption_key is Option<Option<String>> — sending a string value sets Some(Some("..."))- m.insert("encryptionKey".into(), serde_json::json!("my-key"));- let params: UpdateLocalStateParams =- serde_json::from_value(serde_json::Value::Object(m)).unwrap();- assert!(params.encryption_key.is_some());-}-#[test]fn deserialize_update_local_state_params_with_null_clears_value() {- let mut m = Map::new();- m.insert("encryptionKey".into(), serde_json::Value::Null);- m.insert("onboardingTasks".into(), serde_json::Value::Null);- m.insert("keyringConsent".into(), serde_json::Value::Null);- let params: UpdateLocalStateParams =- serde_json::from_value(serde_json::Value::Object(m)).unwrap();- assert_eq!(params.encryption_key, Some(None));- assert!(matches!(params.onboarding_tasks, Some(None)));- assert_eq!(params.keyring_consent, Some(None));+ let patch = parse_update(json!({+ "encryptionKey": null,+ "onboardingTasks": null,+ "keyringConsent": null+ }))+ .unwrap();+ assert_eq!(patch.encryption_key, Some(None));+ assert!(matches!(patch.onboarding_tasks, Some(None)));+ assert_eq!(patch.keyring_consent, Some(None));}#[test]fn update_local_state_patch_preserves_camel_case_tristate_and_nested_defaults() {- let missing: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({})).unwrap();+ let missing = parse_update(json!({})).unwrap();assert_eq!(missing.encryption_key, None);assert!(missing.onboarding_tasks.is_none());assert_eq!(missing.keyring_consent, None);- let params: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({+ for expected in ["", "ordinary", " keep whitespace "] {+ let patch = parse_update(json!({"encryptionKey": expected})).unwrap();+ assert_eq!(+ patch.encryption_key.as_ref().map(|value| value.as_deref()),+ Some(Some(expected)),+ "encryptionKey remains verbatim"+ );+ }++ let patch = parse_update(json!({"encryptionKey": " keep whitespace ","onboardingTasks": {"accessibilityPermissionGranted": false,@@ -137,7 +128,7 @@ fn update_local_state_patch_preserves_camel_case_tristate_and_nested_defaults()})).unwrap();- let snake_case_only: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({+ let snake_case_only = parse_update(json!({"encryption_key": "ignored","onboarding_tasks": {"accessibility_permission_granted": true},"keyring_consent": {"storage_mode": "ignored"}@@ -148,19 +139,19 @@ fn update_local_state_patch_preserves_camel_case_tristate_and_nested_defaults()assert!(snake_case_only.keyring_consent.is_none());assert_eq!(- params.encryption_key.as_ref().map(|value| value.as_deref()),+ patch.encryption_key.as_ref().map(|value| value.as_deref()),Some(Some(" keep whitespace ")));- let tasks = params.onboarding_tasks.as_ref().unwrap().as_ref().unwrap();+ let tasks = patch.onboarding_tasks.as_ref().unwrap().as_ref().unwrap();assert!(!tasks.accessibility_permission_granted);assert!(tasks.enabled_tools.is_empty());assert!(tasks.connected_sources.is_empty());assert_eq!(tasks.updated_at_ms, None);- let consent = params.keyring_consent.as_ref().unwrap().as_ref().unwrap();+ let consent = patch.keyring_consent.as_ref().unwrap().as_ref().unwrap();assert_eq!(consent.storage_mode, "");assert_eq!(consent.consented_at_ms, Some(17));- let defaults: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({+ let defaults = parse_update(json!({"onboardingTasks": {},"keyringConsent": {}}))@@ -187,26 +178,36 @@ fn update_local_state_patch_rejects_wrong_nested_and_outer_types() {serde_json::json!({"onboardingTasks": "not-an-object"}),serde_json::json!({"keyringConsent": {"consentedAtMs": "17"}}),] {+ let error = parse_update(value).expect_err("malformed patch types are rejected");assert!(- serde_json::from_value::<UpdateLocalStateParams>(value).is_err(),- "malformed app_state patch types are rejected"+ error.starts_with("invalid params:"),+ "invalid update input keeps its parse error prefix: {error}");}}#[test]fn update_local_state_patch_preserves_array_to_struct_defaults() {- let params: UpdateLocalStateParams = serde_json::from_value(serde_json::json!({+ let patch = parse_update(json!({"onboardingTasks": [],"keyringConsent": []})).unwrap();- let tasks = params.onboarding_tasks.as_ref().unwrap().as_ref().unwrap();+ let tasks = patch.onboarding_tasks.as_ref().unwrap().as_ref().unwrap();assert!(!tasks.accessibility_permission_granted);assert!(tasks.enabled_tools.is_empty());assert!(tasks.connected_sources.is_empty());assert_eq!(tasks.updated_at_ms, None);- let consent = params.keyring_consent.as_ref().unwrap().as_ref().unwrap();+ let consent = patch.keyring_consent.as_ref().unwrap().as_ref().unwrap();assert_eq!(consent.storage_mode, "");assert_eq!(consent.consented_at_ms, None);}++fn parse_update(value: serde_json::Value) -> Result<StoredAppStatePatch, String> {+ parse_update_local_state(+ value+ .as_object()+ .expect("test patch is a JSON object")+ .clone(),+ )+}