Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(cron): log why a shell job could not run; give the cron e2e host storage

M3gA-Mindc680d0931144
diff --git a/crates/openhuman-core/src/cron/scheduler/shell_job.rs b/crates/openhuman-core/src/cron/scheduler/shell_job.rs
index a8be66da19..6bf79d5b8f 100644
--- a/crates/openhuman-core/src/cron/scheduler/shell_job.rs
+++ b/crates/openhuman-core/src/cron/scheduler/shell_job.rs
@@ -123,7 +123,14 @@ pub(super) async fn run_job_command_with_timeout(
.await
{
Ok(output) => output,
- Err(_) => return (false, "Command execution is unavailable.".to_owned()),
+ Err(error) => {
+ tracing::warn!(
+ job_id = %job.id,
+ error = %format!("{error:#}"),
+ "[cron:shell] command could not run"
+ );
+ return (false, "Command execution is unavailable.".to_owned());
+ }
};
if output.timed_out {
return (
diff --git a/crates/openhuman-core/src/sandbox/shell_exec.rs b/crates/openhuman-core/src/sandbox/shell_exec.rs
index 341e22310d..3ce508971f 100644
--- a/crates/openhuman-core/src/sandbox/shell_exec.rs
+++ b/crates/openhuman-core/src/sandbox/shell_exec.rs
@@ -220,7 +220,13 @@ async fn run_owned(
},
)
.await
- .map_err(|_| anyhow::anyhow!("TinyBox could not create a command resource"))?;
+ .map_err(|error| {
+ tracing::warn!(
+ error = ?error,
+ "[sandbox:shell] TinyBox refused to create a command resource"
+ );
+ anyhow::anyhow!("TinyBox could not create a command resource")
+ })?;
let process = tinybox::reserve(config, contract::ReserveRequest::Process(resource.clone()))
.await
.map_err(|_| anyhow::anyhow!("TinyBox could not reserve a command process"))?;
diff --git a/tests/raw_coverage/automation_scheduling_e2e.rs b/tests/raw_coverage/automation_scheduling_e2e.rs
index 67b082ee3f..4e1fee99b8 100644
--- a/tests/raw_coverage/automation_scheduling_e2e.rs
+++ b/tests/raw_coverage/automation_scheduling_e2e.rs
@@ -236,6 +236,10 @@ fn str_at<'a>(value: &'a Value, pointer: &str) -> &'a str {
#[tokio::test]
async fn cron_run_records_history_and_remove_is_not_idempotent() {
let _lock = env_lock_async().await;
+ // The shell job runs through the TinyBox module, which keeps its command
+ // resources in host storage. A real host's boot installs that backend;
+ // this suite boots none, so install one for the test.
+ let _storage = crate::HostStorage::install(&_lock);
let h = setup().await;
let job = h