Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(profiles): drive permissive decoder and credential expiry cases from shared fixtures

Steven Enamakelce77a3f15083
diff --git a/crates/openhuman-core/src/core/all_profiles_controller_tests.rs b/crates/openhuman-core/src/core/all_profiles_controller_tests.rs
index bd4280fa1a..caef46dc44 100644
--- a/crates/openhuman-core/src/core/all_profiles_controller_tests.rs
+++ b/crates/openhuman-core/src/core/all_profiles_controller_tests.rs
@@ -59,36 +59,26 @@ fn bound_profile_decoders_keep_permissive_unknown_field_behavior() {
use serde_json::json;
let entries = raw_profiles_entries();
- for (method, params) in [
- ("profiles.provision", json!({"user_id":"u1", "extra":true})),
- (
- "profiles.deprovision",
- json!({"profile_id":"p1", "extra":true}),
- ),
- ("profiles.list", json!({"entirely_ignored":{"extra":true}})),
- ("profiles.status", json!({"profile_id":"p1", "extra":true})),
- (
- "profiles.set_credential",
- json!({
- "profile_id":"p1",
- "kind":"api_key",
- "token":"fixture-only-token",
- "extra":true
- }),
- ),
- (
- "profiles.clear_credential",
- json!({"profile_id":"p1", "extra":true}),
- ),
- ("profiles.release", json!({"profile_id":"p1", "extra":true})),
- ] {
- let params = params.as_object().expect("fixture object").clone();
+ for contract in crate::profiles::schemas::profile_parameter_contracts() {
+ let mut params = contract.examples[0]
+ .as_object()
+ .expect("owner fixture object")
+ .clone();
+ params.insert("extra_scalar".into(), json!(true));
+ params.insert("extra_nested".into(), json!({"ignored":true}));
entries
.iter()
- .find(|entry| entry.schema.method_name() == method)
- .unwrap_or_else(|| panic!("missing raw {method} entry"))
+ .find(|entry| entry.schema.method_name() == contract.method)
+ .unwrap_or_else(|| panic!("missing raw {} entry", contract.method))
+ // Deliberately skip schema validation: this pins the legacy
+ // DTO/list decoder behavior for keys the schemas do not declare.
.decode_params(params)
- .unwrap_or_else(|error| panic!("{method} decoder rejected permissive map: {error}"));
+ .unwrap_or_else(|error| {
+ panic!(
+ "{} decoder rejected permissive map: {error}",
+ contract.method
+ )
+ });
}
}
diff --git a/crates/openhuman-core/src/profiles/schemas_tests.rs b/crates/openhuman-core/src/profiles/schemas_tests.rs
index 87b9a29a00..271d4e74b0 100644
--- a/crates/openhuman-core/src/profiles/schemas_tests.rs
+++ b/crates/openhuman-core/src/profiles/schemas_tests.rs
@@ -104,48 +104,34 @@ fn credential_schema_and_parser_keep_field_order_defaults_and_kinds() {
["profile_id", "kind", "token", "expires_at"]
);
- let absent = parse_credential(
- json!({
+ for (kind, expires_at, expected_expiry) in [
+ (UserCredentialKind::ApiKey, None, None),
+ (UserCredentialKind::Session, Some(json!(null)), None),
+ (
+ UserCredentialKind::Session,
+ Some(json!("not-normalized")),
+ Some("not-normalized"),
+ ),
+ ] {
+ let kind_name = match kind {
+ UserCredentialKind::Session => "session",
+ UserCredentialKind::ApiKey => "api_key",
+ };
+ let mut params = json!({
"profile_id":"p1",
- "kind":"api_key",
+ "kind":kind_name,
"token":"fixture-only-token"
})
.as_object()
.expect("object params")
- .clone(),
- )
- .expect("api key with absent expiry");
- assert_eq!(absent.kind, UserCredentialKind::ApiKey);
- assert_eq!(absent.expires_at, None);
-
- let null = parse_credential(
- json!({
- "profile_id":"p1",
- "kind":"session",
- "token":"fixture-only-token",
- "expires_at":null
- })
- .as_object()
- .expect("object params")
- .clone(),
- )
- .expect("session with null expiry");
- assert_eq!(null.kind, UserCredentialKind::Session);
- assert_eq!(null.expires_at, None);
-
- let string = parse_credential(
- json!({
- "profile_id":"p1",
- "kind":"session",
- "token":"fixture-only-token",
- "expires_at":"not-normalized"
- })
- .as_object()
- .expect("object params")
- .clone(),
- )
- .expect("string expiry remains unchanged by the parser");
- assert_eq!(string.expires_at.as_deref(), Some("not-normalized"));
+ .clone();
+ if let Some(expires_at) = expires_at {
+ params.insert("expires_at".into(), expires_at);
+ }
+ let parsed = parse_credential(params).expect("valid credential params");
+ assert_eq!(parsed.kind, kind);
+ assert_eq!(parsed.expires_at.as_deref(), expected_expiry);
+ }
for invalid in [json!("unknown"), json!(42), json!(null)] {
let params = json!({