Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

refactor(inference): simplify turn model injection logic

Steven Enamakeldbb343883515
diff --git a/crates/openhuman-core/src/inference/turn_models.rs b/crates/openhuman-core/src/inference/turn_models.rs
index 139308c4ea..26124a4069 100644
--- a/crates/openhuman-core/src/inference/turn_models.rs
+++ b/crates/openhuman-core/src/inference/turn_models.rs
@@ -494,11 +494,6 @@ impl TurnModelSource {
let host_injected = ctx
.host_overrides()
.and_then(|overrides| overrides.model_for(&cn.role));
- #[cfg(any(test, feature = "e2e-test-support", feature = "rss-bench"))]
- let injected = host_injected
- .or_else(crate::inference::provider::factory::test_provider_override::current);
- #[cfg(not(any(test, feature = "e2e-test-support", feature = "rss-bench")))]
- let injected = host_injected;
let injected_profile = host_injected.as_ref().and_then(|model| model.profile());
let provider_string = cn.primary_override.clone().unwrap_or_else(|| {
crate::inference::provider::provider_for_role(&cn.role, &cn.config)
diff --git a/crates/openhuman-core/src/inference/turn_models_tests.rs b/crates/openhuman-core/src/inference/turn_models_tests.rs
index fa42a6be18..aeae192094 100644
--- a/crates/openhuman-core/src/inference/turn_models_tests.rs
+++ b/crates/openhuman-core/src/inference/turn_models_tests.rs
@@ -334,7 +334,7 @@ async fn injected_turn_profile_is_authoritative_and_skips_unselected_routes() {
);
let mut profile = ModelProfile::default();
profile.provider = Some("ollama:injected".into());
- profile.tool_calling = true;
+ profile.tool_calling = false;
profile.modalities.image_in = true;
profile.max_input_tokens = Some(123_456);
let mut overrides = HostOverrides::default();
@@ -356,13 +356,62 @@ async fn injected_turn_profile_is_authoritative_and_skips_unselected_routes() {
.expect("host injected model builds");
assert_eq!(models.provider_id(), "ollama:injected");
- assert!(models.native_tools());
+ assert!(!models.native_tools());
assert!(models.supports_vision());
assert!(models.is_local());
assert_eq!(models.context_window(), Some(123_456));
assert_eq!(builds.load(Ordering::SeqCst), 0);
}
+#[tokio::test]
+async fn injected_turn_without_profile_keeps_conservative_capabilities() {
+ use crate::agent::host_overrides::HostOverrides;
+ use crate::core::runtime::{ContextOverlay, CoreContext, DispatchCtx, DomainSet};
+ use crate::core::types::HostKind;
+
+ struct ProfilelessModel;
+ #[async_trait]
+ impl ChatModel<()> for ProfilelessModel {
+ async fn invoke(
+ &self,
+ _state: &(),
+ _request: ModelRequest,
+ ) -> tinyinference_llm::Result<ModelResponse> {
+ Ok(ModelResponse::assistant("profileless"))
+ }
+ }
+
+ let root = CoreContext::for_test_with_host_kind(
+ HostKind::Library,
+ DomainSet::full(),
+ None,
+ );
+ let mut overrides = HostOverrides::default();
+ overrides.model = Some(Arc::new(ProfilelessModel));
+ let context = root.derive_with(
+ ContextOverlay::new(
+ crate::config::Config {
+ chat_provider: Some("openhuman".into()),
+ ..Default::default()
+ },
+ DomainSet::full(),
+ Default::default(),
+ )
+ .host_overrides(Arc::new(overrides)),
+ );
+ let ctx = DispatchCtx::new(context);
+ let models = TurnModelSource::new_crate_native(&ctx, "chat", Arc::new(Default::default()))
+ .build("hint:chat", 0.2, None, None)
+ .expect("profileless host-injected model builds");
+
+ assert_eq!(models.provider_id(), "injected");
+ assert!(!models.native_tools());
+ assert!(!models.supports_vision());
+ assert!(!models.is_local());
+ assert_eq!(models.context_window(), None);
+ assert!(models.primary.profile().is_none());
+}
+
#[tokio::test]
async fn explicit_turn_context_without_provider_does_not_borrow_ambient_provider() {
use crate::core::runtime::{CoreContext, DispatchCtx, DomainSet};