Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

fix(deeplink): install __simulateDeepLink only in dev/E2E builds

M3gA-Minde716fba10ba8
diff --git a/app/src/utils/__tests__/desktopDeepLinkListener.test.ts b/app/src/utils/__tests__/desktopDeepLinkListener.test.ts
index b72ebd353e..8577fcf264 100644
--- a/app/src/utils/__tests__/desktopDeepLinkListener.test.ts
+++ b/app/src/utils/__tests__/desktopDeepLinkListener.test.ts
@@ -444,6 +444,25 @@ describe('desktopDeepLinkListener', () => {
}
});
+ it('does not install the deep-link simulator in a shipped (non dev-like) build', async () => {
+ const win = window as Window & { __simulateDeepLink?: unknown };
+ delete win.__simulateDeepLink;
+ vi.resetModules();
+ vi.doMock('../config', async importOriginal => ({
+ ...(await importOriginal<typeof import('../config')>()),
+ IS_DEV_LIKE: false,
+ }));
+ try {
+ const { setupDesktopDeepLinkListener: setupShipped } =
+ await import('../desktopDeepLinkListener');
+ await setupShipped();
+ expect(win.__simulateDeepLink).toBeUndefined();
+ } finally {
+ vi.doUnmock('../config');
+ vi.resetModules();
+ }
+ });
+
it('does not make the E2E deep-link helper wait for auth readiness', async () => {
let resolveReadiness!: (_value: { ready: true }) => void;
waitForOAuthAuthReadiness.mockReturnValueOnce(
diff --git a/app/src/utils/desktopDeepLinkListener.ts b/app/src/utils/desktopDeepLinkListener.ts
index 78e4b828a6..c86f885e74 100644
--- a/app/src/utils/desktopDeepLinkListener.ts
+++ b/app/src/utils/desktopDeepLinkListener.ts
@@ -15,7 +15,7 @@ import {
completeDeepLinkAuthProcessing,
failDeepLinkAuthProcessing,
} from '../store/deepLinkAuthState';
-import { E2E_RESTART_APP_AS_RELOAD } from './config';
+import { E2E_RESTART_APP_AS_RELOAD, IS_DEV_LIKE } from './config';
import { getStoredCoreMode } from './configPersistence';
import {
CORE_CONFIG_UNREADABLE_I18N_KEY,
@@ -741,7 +741,9 @@ export const setupDesktopDeepLinkListener = async () => {
void handleDeepLinkUrls(urls);
});
- if (typeof window !== 'undefined') {
+ // Dev/E2E builds only: the helper mints a CSRF `state` nonce, so in a
+ // shipped binary any script in the WebView could inject a login token.
+ if (IS_DEV_LIKE && typeof window !== 'undefined') {
// window.__simulateDeepLink('openhuman://auth?token=1234567890')
// window.__simulateDeepLink('openhuman://oauth/success?integrationId=69cafd0b103bd070232d3223&provider=notion')
// window.__simulateDeepLink('openhuman://oauth/success?integrationId=69cafd0b103bd070232d3223&skillId=discord')