Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

refactor(speech): defer stt provider creation to transcription time

Steven Enamakelf2bbd2f5495a
diff --git a/crates/openhuman-core/src/inference/host_runtime/service/speech.rs b/crates/openhuman-core/src/inference/host_runtime/service/speech.rs
index d98cf13597..cdbf34d086 100644
--- a/crates/openhuman-core/src/inference/host_runtime/service/speech.rs
+++ b/crates/openhuman-core/src/inference/host_runtime/service/speech.rs
@@ -50,7 +50,7 @@ pub async fn transcribe_with_prompt(
let provider_name = effective_stt_provider(config);
debug!("{LOG_PREFIX} configured STT dispatch provider={provider_name} path={audio_path}");
- let provider = selected_stt_provider(config, &provider_name)?;
+ let provider = selected_stt_provider(config, &provider_name);
let text = tinyinference_voice::transcription::transcribe_file(Path::new(audio_path), &provider)
.await?;
debug!(
@@ -73,7 +73,7 @@ pub async fn transcribe_bytes(
extension: Option<&str>,
) -> Result<LocalAiSpeechResult, String> {
let provider_name = effective_stt_provider(config);
- let provider = selected_stt_provider(config, &provider_name)?;
+ let provider = selected_stt_provider(config, &provider_name);
let text = tinyinference_voice::transcription::transcribe_bytes(audio, extension, &provider)
.await?;
service.mark_stt_ready();
@@ -86,15 +86,20 @@ pub async fn transcribe_bytes(
fn selected_stt_provider<'a>(
config: &'a Config,
provider_name: &str,
-) -> Result<ConfiguredSttProvider<'a>, String> {
- let provider =
- create_stt_provider(provider_name, "", config).map_err(|error| error.to_string())?;
- Ok(ConfiguredSttProvider { config, provider })
+) -> ConfiguredSttProvider<'a> {
+ let provider_name = provider_name.to_owned();
+ ConfiguredSttProvider {
+ config,
+ provider_factory: Box::new(move |config| {
+ create_stt_provider(&provider_name, "", config).map_err(|error| error.to_string())
+ }),
+ }
}
struct ConfiguredSttProvider<'a> {
config: &'a Config,
- provider: Box<dyn SttProvider>,
+ provider_factory:
+ Box<dyn Fn(&Config) -> Result<Box<dyn SttProvider>, String> + Send + Sync + 'a>,
}
#[async_trait::async_trait]
@@ -105,9 +110,9 @@ impl tinyinference_voice::transcription::TranscriptionProvider for ConfiguredStt
mime_type: &str,
file_name: &str,
) -> Result<String, String> {
+ let provider = (self.provider_factory)(self.config)?;
let audio_base64 = BASE64.encode(audio);
- let outcome = self
- .provider
+ let outcome = provider
.transcribe(
self.config,
&audio_base64,
diff --git a/crates/openhuman-core/src/inference/host_runtime/service/speech_tests.rs b/crates/openhuman-core/src/inference/host_runtime/service/speech_tests.rs
index 2d13b5905e..e34d6240ab 100644
--- a/crates/openhuman-core/src/inference/host_runtime/service/speech_tests.rs
+++ b/crates/openhuman-core/src/inference/host_runtime/service/speech_tests.rs
@@ -50,9 +50,12 @@ async fn native_transcription_helpers_preserve_audio_metadata_for_host_stt() {
let file_path = tmp.path().join("voice.wav");
std::fs::write(&file_path, b"file-audio").unwrap();
let calls = Arc::new(Mutex::new(Vec::new()));
+ let provider_calls = Arc::clone(&calls);
let provider = ConfiguredSttProvider {
config: &config,
- provider: Box::new(CapturingSttProvider(Arc::clone(&calls))),
+ provider_factory: Box::new(move |_| {
+ Ok(Box::new(CapturingSttProvider(Arc::clone(&provider_calls))) as Box<dyn SttProvider>)
+ }),
};
let file_text = tinyinference_voice::transcription::transcribe_file(&file_path, &provider)