Skip to content

The fastest, cheapest, most efficient open-source agent harness. Run more than 500 agents on a $10 VPS.

test(storage): make lease fencing tests use real clock and node takeover

Steven Enamakelf665d09ee104
diff --git a/crates/openhuman-core/src/modules/storage_host_bus_tests.rs b/crates/openhuman-core/src/modules/storage_host_bus_tests.rs
index 4c97d38fab..0d72cdc5d5 100644
--- a/crates/openhuman-core/src/modules/storage_host_bus_tests.rs
+++ b/crates/openhuman-core/src/modules/storage_host_bus_tests.rs
@@ -63,13 +63,14 @@ async fn a_module_write_under_a_stale_lease_is_fenced_by_the_host() {
.ensure_collection(&CollectionSpec::new("notes"))
.await
.unwrap();
- let clock = Arc::new(AtomicU64::new(0));
+ let start_ms = crate::storage::fence::system_now_ms();
+ let clock = Arc::new(AtomicU64::new(start_ms));
let reading = Arc::clone(&clock);
let fences = Arc::new(FenceRegistry::new(move || reading.load(Ordering::SeqCst)));
let ttl = Duration::from_secs(30);
let leases: Arc<dyn LeaseStore> =
Arc::new(DocumentLeases::cluster(shared.as_ref(), "node-a", None, ttl).unwrap());
- let grant_a = leases.acquire("acme", 0).await.unwrap();
+ let grant_a = leases.acquire("acme", start_ms).await.unwrap();
fences.register(Arc::new(LeaseFence::new(
Arc::clone(&leases),
"acme",
diff --git a/crates/openhuman-core/src/modules/storage_import_tinymcp_tests.rs b/crates/openhuman-core/src/modules/storage_import_tinymcp_tests.rs
index 62c05b299e..1475c1e540 100644
--- a/crates/openhuman-core/src/modules/storage_import_tinymcp_tests.rs
+++ b/crates/openhuman-core/src/modules/storage_import_tinymcp_tests.rs
@@ -318,8 +318,10 @@ async fn an_import_cannot_recapture_a_reopened_profiles_new_fence() {
let fixture = crate::storage::test_support::sqlite_backend().unwrap();
let backend: Arc<dyn StorageBackend> = Arc::clone(&fixture.backend);
let id = ProfileId::for_user("import-takeover", ProfileIdMode::Raw).unwrap();
+ let mut saas = SaasConfig::new(root.path());
+ saas.node_id = Some("import-first-node".to_owned());
let host = ProfileHost::with_backend(
- SaasConfig::new(root.path()),
+ saas,
CoreContext::for_test(DomainSet::full(), None),
Some(Arc::clone(&backend)),
)
@@ -331,15 +333,36 @@ async fn an_import_cannot_recapture_a_reopened_profiles_new_fence() {
let old_profile = host.open(&id).await.unwrap();
let old_context = Arc::clone(old_profile.context());
- let old_context_weak = Arc::downgrade(&old_context);
- drop(old_context);
drop(old_profile);
- assert!(host.release(&id).await.unwrap());
- let current_profile = host.open(&id).await.unwrap();
+ let lease_ttl = host.saas().lease_ttl();
+ let lease_store = crate::storage::lease::DocumentLeases::cluster(
+ backend.as_ref(),
+ "import-takeover-probe",
+ None,
+ lease_ttl,
+ )
+ .unwrap();
+ let takeover_at = crate::profiles::lease::now_ms().saturating_add(
+ u64::try_from(lease_ttl.as_millis())
+ .unwrap_or(u64::MAX)
+ .saturating_mul(2),
+ );
+ let stolen = lease_store.acquire(id.as_str(), takeover_at).await.unwrap();
+ lease_store.release(stolen).await.unwrap();
+
+ let mut reopened_saas = SaasConfig::new(root.path());
+ reopened_saas.node_id = Some("import-second-node".to_owned());
+ let reopened_host = ProfileHost::with_backend(
+ reopened_saas,
+ CoreContext::for_test(DomainSet::full(), None),
+ Some(Arc::clone(&backend)),
+ )
+ .unwrap()
+ .with_fences(Arc::new(crate::storage::fence::FenceRegistry::new(
+ crate::profiles::lease::now_ms,
+ )));
+ let current_profile = reopened_host.open(&id).await.unwrap();
let current_context = Arc::clone(current_profile.context());
- let old_context = old_context_weak
- .upgrade()
- .expect("the host retains the retired context for stale-work checks");
assert!(!Arc::ptr_eq(&old_context, &current_context));
// A stale turn context cannot keep the profile lease alive while the test
@@ -353,7 +376,7 @@ async fn an_import_cannot_recapture_a_reopened_profiles_new_fence() {
let module_scope = crate::storage::scope_for_module(Some(id.as_str()), MODULE_ID).unwrap();
let stale = super::super::storage_import_support::capture_profile_module_storage(
- &host,
+ &reopened_host,
&id,
id.as_str(),
&old_turn,
@@ -370,7 +393,7 @@ async fn an_import_cannot_recapture_a_reopened_profiles_new_fence() {
Default::default(),
));
let captured = super::super::storage_import_support::capture_profile_module_storage(
- &host,
+ &reopened_host,
&id,
id.as_str(),
&current_turn,