The IDE you know, rebuilt in Rust. IntelliJ IDEA–style keymap, tool windows and search-everywhere in a fast native app: editor, code insight, debugger, Git, terminal, database and HTTP clients for 60+ languages.
TypeScript code-editorcross-platformdapdatabase-clientdebuggerdesktop-appdeveloper-toolsgithttp-clientideintellijlsprusttauriterminal
fix(editor): Allow selecting and copying text in read-only code previews (#136)
l0ng-ai630d436e1899
diff --git a/src/editor/core/cm/preview.test.ts b/src/editor/core/cm/preview.test.tsnew file mode 100644index 000000000..8b4a1b3a0--- /dev/null+++ b/src/editor/core/cm/preview.test.ts@@ -0,0 +1,18 @@+import { describe, expect, it } from "vitest";+import { EditorState } from "@codemirror/state";+import { EditorView } from "@codemirror/view";+import { selectableText } from "@/ui";+import { previewExtensions } from "./preview";++describe("previewExtensions", () => {+ it("keeps the read-only preview selectable and focusable", async () => {+ const view = new EditorView({+ state: EditorState.create({ doc: "let a = 1;", extensions: await previewExtensions("/p/a.txt", undefined) }),+ });+ expect(view.state.readOnly).toBe(true);+ expect(view.contentDOM.getAttribute("contenteditable")).toBe("false");+ expect(view.contentDOM.getAttribute("tabindex")).toBe("0");+ expect(view.contentDOM.classList.contains(selectableText)).toBe(true);+ view.destroy();+ });+});diff --git a/src/editor/core/cm/preview.ts b/src/editor/core/cm/preview.tsindex 86fd2fb35..44f0ece8e 100644--- a/src/editor/core/cm/preview.ts+++ b/src/editor/core/cm/preview.ts@@ -13,6 +13,7 @@ import { openideaTheme } from "./theme";import { findLanguageDescription, loadSupport, loadedSupport, uiModeForPath } from "./languages";import { fontExtension } from "./setup";import { tx } from "@/platform/i18n";+import { selectableText } from "@/ui";export async function previewExtensions(path: string, settings: EditorSettings | undefined): Promise<Extension> {const open = editorsFor(path)[0]?.ctx;@@ -26,7 +27,8 @@ export async function previewExtensions(path: string, settings: EditorSettings |syntaxHighlighting(openideaHighlightStyle),EditorState.readOnly.of(true),EditorView.editable.of(false),- EditorView.contentAttributes.of({ "aria-label": tx`Preview of ${path}` }),+ // Not editable, so selection and Copy need the text opted back in and a tab stop.+ EditorView.contentAttributes.of({ "aria-label": tx`Preview of ${path}`, class: selectableText, tabindex: "0" }),support ?? [],];}