The IDE you know, rebuilt in Rust. IntelliJ IDEA–style keymap, tool windows and search-everywhere in a fast native app: editor, code insight, debugger, Git, terminal, database and HTTP clients for 60+ languages.
TypeScript code-editorcross-platformdapdatabase-clientdebuggerdesktop-appdeveloper-toolsgithttp-clientideintellijlsprusttauriterminal
fix(go): use directory output for build-only configurations (#1994)
Shohruh Ismoilov705f3557a8f0
diff --git a/crates/ide-run/src/go.rs b/crates/ide-run/src/go.rsindex 5593b46e0..f1ad47916 100644--- a/crates/ide-run/src/go.rs+++ b/crates/ide-run/src/go.rs@@ -40,6 +40,16 @@ pub fn plan(root: &Path, config: &RunConfig) -> IdeResult<Option<Plan>> {root.join(get("outputDir"))};std::fs::create_dir_all(&output)?;+ let run_after_build = get("runAfterBuild") == "true";+ if !run_after_build {+ // Go requires a directory output for patterns containing several main packages.+ // Preserve explicit -o values, including Go's platform-specific special paths.+ if !build.args.iter().any(|arg| arg == "-o" || arg.starts_with("-o=")) {+ let directory = format!("{}{sep}", output.to_string_lossy(), sep = std::path::MAIN_SEPARATOR);+ build.args.splice(1..1, ["-o".into(), directory]);+ }+ return Ok(Some(Plan { build, run: None }));+ }let mut hash = std::collections::hash_map::DefaultHasher::new();config.id.hash(&mut hash);let mut binary = output.join(format!("go-app-{:x}{}", hash.finish(), std::env::consts::EXE_SUFFIX));diff --git a/crates/ide-run/tests/process.rs b/crates/ide-run/tests/process.rsindex a382701ad..94765dedd 100644--- a/crates/ide-run/tests/process.rs+++ b/crates/ide-run/tests/process.rs@@ -631,6 +631,50 @@ fn go_build_runs_with_separate_arguments_environment_and_working_directory() {assert!(text(&out, stdout).is_empty(), "a failed build must never run an older binary");}+#[test]+fn go_build_only_supports_multiple_packages_and_explicit_output() {+ let h = harness();+ let Some(go) = ide_run::which::find_executable("go", &std::env::var_os("PATH").unwrap_or_default()) else {+ return;+ };+ std::fs::write(h.root.path().join("go.mod"), "module example.com/buildall\ngo 1.22\n").unwrap();+ for name in ["one", "two"] {+ let dir = h.root.path().join("cmd").join(name);+ std::fs::create_dir_all(&dir).unwrap();+ std::fs::write(dir.join("main.go"), "package main\nfunc main() {}\n").unwrap();+ }+ let mut config = cfg("go-build-only", &go.to_string_lossy(), &["build", "./..."]);+ config.kind = "go".into();+ config.extras.params = BTreeMap::from([+ ("goKind".into(), "build".into()),+ ("scope".into(), "package".into()),+ ("target".into(), "./...".into()),+ ("runAfterBuild".into(), "false".into()),+ ("outputDir".into(), "compiled output".into()),+ ]);+ let (id, output) = start(&h, &config);+ assert_eq!(wait_exit(&h, id, Duration::from_secs(60)), Some(0), "{}", text(&output, stderr));+ for name in ["one", "two"] {+ assert!(+ h.root.path().join("compiled output").join(format!("{name}{}", std::env::consts::EXE_SUFFIX)).is_file()+ );+ }+ std::fs::create_dir_all(h.root.path().join("explicit output")).unwrap();+ config.args = vec!["build".into(), "-o=explicit output/".into(), "./...".into()];+ let plan = ide_run::go::plan(h.root.path(), &config).unwrap().unwrap();+ assert_eq!(plan.build.args, config.args);+ assert!(plan.run.is_none());+ let (id, output) = start(&h, &config);+ assert_eq!(wait_exit(&h, id, Duration::from_secs(60)), Some(0), "{}", text(&output, stderr));+ for name in ["one", "two"] {+ assert!(+ h.root.path().join("explicit output").join(format!("{name}{}", std::env::consts::EXE_SUFFIX)).is_file()+ );+ }+ config.args = vec!["build".into(), "-o".into(), "one-binary".into(), "./cmd/one".into()];+ assert_eq!(ide_run::go::plan(h.root.path(), &config).unwrap().unwrap().build.args, config.args);+}+#[test]fn go_file_tests_use_build_selected_sources_and_only_the_selected_test_file() {let h = harness();