Skip to content

The IDE you know, rebuilt in Rust. IntelliJ IDEA–style keymap, tool windows and search-everywhere in a fast native app: editor, code insight, debugger, Git, terminal, database and HTTP clients for 60+ languages.

feat(agents): page multiple questions with tabs and a stable height (#2297)

SunZhiQiang97972952822d
diff --git a/e2e/agentQuestions.spec.ts b/e2e/agentQuestions.spec.ts
new file mode 100644
index 000000000..2a9e6f336
--- /dev/null
+++ b/e2e/agentQuestions.spec.ts
@@ -0,0 +1,158 @@
+import { expect, test } from "./fixtures";
+import type { AgentQuestion, AgentTask } from "../src/bindings";
+
+const task: AgentTask = {
+ id: "questions",
+ title: "Plan the change",
+ status: "needsInput",
+ isolation: "local",
+ provider: "codex",
+ model: null,
+ cwd: "/dev/acme-api",
+ branch: null,
+ base: null,
+ baseCommit: null,
+ error: null,
+ createdMs: 0,
+ updatedMs: 0,
+ config: [],
+ commands: [],
+ usage: null,
+ queue: [],
+};
+const questions: AgentQuestion[] = [
+ {
+ header: "Layout",
+ question: "Which layout should we use?",
+ multiSelect: false,
+ options: [{ label: "Table", description: "One row per check", preview: "| check | result |" }],
+ },
+ {
+ header: "Checks",
+ question: "Which checks should we include? " + "Explain the checks and their expected results. ".repeat(8),
+ multiSelect: true,
+ options: [
+ { label: "LongOption".repeat(20), description: "Description ".repeat(25), preview: null },
+ { label: "Updates", description: "Check for updates", preview: null },
+ ],
+ },
+ {
+ header: "Delivery",
+ question: "When should the change ship?",
+ multiSelect: false,
+ options: [{ label: "Today", description: "After the checks pass", preview: null }],
+ },
+];
+
+for (const theme of ["dark", "light"] as const) {
+ for (const width of [760, 1400]) {
+ for (const count of [1, 3]) {
+ test(`${count} questions at ${width}px in ${theme}`, async ({ workbench: page }) => {
+ await page.setViewportSize({ width, height: 900 });
+ await page.evaluate(
+ async ({ task, questions, theme }) => {
+ const storePath = "/src/features/agents/store.ts";
+ const themePath = "/src/workbench/theme.ts";
+ const ipcPath = "/src/platform/ipc.ts";
+ const store = await import(storePath);
+ (await import(themePath)).previewTheme(theme);
+ // Keep this fixture entirely local, including submission.
+ (await import(ipcPath)).commands.agentRespond = async (
+ _task: string,
+ _permission: number,
+ answer: string,
+ ) => {
+ document.documentElement.dataset.questionAnswer = answer;
+ return { status: "ok", data: null };
+ };
+ store.useAgents.setState({
+ loaded: true,
+ tasks: new Map([[task.id, task]]),
+ entries: new Map([
+ [
+ task.id,
+ [{ type: "permission", id: 1, title: "Plan the change", options: [], chosen: null, questions }],
+ ],
+ ]),
+ });
+ store.openTaskInEditorLocation(task.id);
+ },
+ { task, questions: questions.slice(0, count), theme },
+ );
+ const card = page.getByRole("form", { name: "Plan the change" });
+ await expect(card).toBeVisible();
+ const submit = card.getByRole("button", { name: "Submit", exact: true });
+ await expect(submit).toBeDisabled();
+ if (count === 1) {
+ await expect(card.getByRole("tablist")).toHaveCount(0);
+ await expect(card.getByRole("button", { name: "Next", exact: true })).toHaveCount(0);
+ await card.getByRole("radio", { name: /^Table/ }).check();
+ await expect(submit).toBeEnabled();
+ await card.getByRole("radio", { name: /^Other/ }).check();
+ await card.getByPlaceholder("Type your answer").fill("Custom layout");
+ await page.keyboard.press("Enter");
+ await expect(page.locator("html")).toHaveAttribute(
+ "data-question-answer",
+ JSON.stringify({ [questions[0]!.question]: ["Custom layout"] }),
+ );
+ return;
+ }
+ const tabs = card.getByRole("tab");
+ await expect(tabs).toHaveCount(3);
+ await expect(card.getByRole("button", { name: "Next", exact: true })).toBeInViewport({ ratio: 1 });
+ const initial = await card.boundingBox();
+ await tabs.first().focus();
+ await page.keyboard.press("ArrowRight");
+ await expect(tabs.nth(1)).toBeFocused();
+ await expect(tabs.nth(1)).toHaveAttribute("aria-selected", "true");
+ await page.keyboard.press("Tab");
+ await expect(card.getByRole("tabpanel", { name: "Checks" })).toBeFocused();
+ await expect(card.getByRole("tabpanel")).toHaveCount(1);
+ await expect(card.getByText("| check | result |", { exact: true })).toBeHidden();
+ const geometry = await card.evaluate((el) => ({
+ width: el.clientWidth,
+ scroll: el.scrollWidth,
+ panelWidth: el.querySelector('[role="tabpanel"][aria-hidden="false"]')!.clientWidth,
+ panelScroll: el.querySelector('[role="tabpanel"][aria-hidden="false"]')!.scrollWidth,
+ }));
+ expect(geometry.scroll).toBe(geometry.width);
+ expect(geometry.panelScroll).toBe(geometry.panelWidth);
+ await card.getByRole("checkbox", { name: /^LongOption/ }).check();
+ const panels = card.getByRole("tabpanel", { name: "Checks" }).locator("..");
+ await panels.evaluate((el) => (el.scrollTop = el.scrollHeight));
+ await expect(tabs.nth(1)).toBeInViewport({ ratio: 1 });
+ await card.getByRole("button", { name: "Next", exact: true }).click();
+ await expect(card.getByRole("tabpanel", { name: "Delivery" })).toBeFocused();
+ expect(
+ await card
+ .getByRole("tabpanel", { name: "Delivery" })
+ .locator("..")
+ .evaluate((el) => el.scrollTop),
+ ).toBe(0);
+ await card.getByRole("radio", { name: /^Today/ }).check();
+ await card.getByRole("button", { name: "Previous", exact: true }).click();
+ await expect(card.getByRole("tabpanel", { name: "Checks" })).toBeFocused();
+ await expect(card.getByRole("checkbox", { name: /^LongOption/ })).toBeChecked();
+ await tabs.nth(1).focus();
+ await page.keyboard.press("Home");
+ await expect(tabs.first()).toBeFocused();
+ await page.keyboard.press("Tab");
+ await expect(card.getByRole("tabpanel", { name: "Layout" })).toBeFocused();
+ await page.keyboard.press("1");
+ await expect(card.getByRole("radio", { name: /^Table/ })).toBeChecked();
+ await expect(submit).toBeEnabled();
+ expect((await card.boundingBox())!.height).toBeCloseTo(initial!.height, 0);
+ await submit.focus();
+ await page.keyboard.press("Enter");
+ await expect(page.locator("html")).toHaveAttribute(
+ "data-question-answer",
+ JSON.stringify({
+ [questions[0]!.question]: ["Table"],
+ [questions[1]!.question]: [questions[1]!.options[0]!.label],
+ [questions[2]!.question]: ["Today"],
+ }),
+ );
+ });
+ }
+ }
+}
diff --git a/src/features/agents/Session.module.css b/src/features/agents/Session.module.css
index d04334a2e..35f01ce4d 100644
--- a/src/features/agents/Session.module.css
+++ b/src/features/agents/Session.module.css
@@ -1278,6 +1278,32 @@
background: var(--bg-elev);
container: question-card / inline-size;
}
+.questionTabCheck {
+ flex: none;
+ color: var(--accent);
+}
+/* All questions share one grid cell: the card keeps the tallest question's height. */
+.questionPanels {
+ display: grid;
+ grid-template-columns: minmax(0, 1fr);
+ min-width: 0;
+}
+.questionPanelsPaged {
+ min-height: 0;
+ overflow-y: auto;
+}
+.questionPanel {
+ grid-area: 1 / 1;
+ min-width: 0;
+}
+.questionPanelHidden {
+ visibility: hidden;
+ pointer-events: none;
+}
+/* The shown preview re-enables visibility, which would escape the hidden panel. */
+.questionPanelHidden .questionPreviewActive {
+ visibility: hidden;
+}
.question {
display: flex;
flex-direction: column;
@@ -1336,6 +1362,7 @@
}
.questionOption > :last-child {
flex: 1;
+ min-width: 0;
}
.questionChoice {
display: flex;
@@ -1350,6 +1377,8 @@
}
.questionLabel {
flex: 1;
+ min-width: 0;
+ overflow-wrap: anywhere;
color: var(--fg);
}
.questionDescription {
@@ -1426,6 +1455,19 @@
}
.questionActions {
display: flex;
+ flex-wrap: wrap;
+ align-items: center;
justify-content: flex-end;
gap: 8px;
}
+.questionPager {
+ display: flex;
+ align-items: center;
+ gap: 6px;
+}
+.questionPage {
+ color: var(--fg-subtle);
+ font-size: var(--fs-small);
+ font-variant-numeric: tabular-nums;
+ white-space: nowrap;
+}
diff --git a/src/features/agents/SessionEditor.tsx b/src/features/agents/SessionEditor.tsx
index de42d35a6..2d4f68040 100644
--- a/src/features/agents/SessionEditor.tsx
+++ b/src/features/agents/SessionEditor.tsx
@@ -7,6 +7,7 @@ import {
useCallback,
useContext,
useEffect,
+ useId,
useLayoutEffect,
useMemo,
useRef,
@@ -43,6 +44,7 @@ import {
SearchField,
Spinner,
T,
+ Tabs,
Tree,
copyMenuFor,
copyText,
@@ -1849,7 +1851,7 @@ const isRecommended = (label: string) => label.endsWith(RECOMMENDED_SUFFIX);
const plainLabel = (label: string) => (isRecommended(label) ? label.slice(0, -RECOMMENDED_SUFFIX.length) : label);
-/** An open `AskUserQuestion` request, as a card above the composer that answers all its questions at once. */
+/** An open `AskUserQuestion` request, as a card above the composer; one question at a time. */
function QuestionCard({ task, entries }: { task: AgentTask; entries: AgentEntry[] | null }) {
const entry = entries?.find(
(candidate): candidate is PermissionEntry =>
@@ -1872,10 +1874,23 @@ function QuestionForm({
const [answers, setAnswers] = useState<QuestionAnswer[]>(() =>
questions.map((question) => ({ question, picked: [], other: null })),
);
- const [focusedPosition, setFocusedPosition] = useState(0);
- const [hovered, setHovered] = useState<{ position: number; label: string } | null>(null);
+ const [position, setPosition] = useState(0);
+ const [hovered, setHovered] = useState<string | null>(null);
const [busy, setBusy] = useState(false);
+ const questionPrefix = useId();
+ const panelsRef = useRef<HTMLDivElement>(null);
+ const panelRef = useRef<HTMLDivElement>(null);
+ // Paging with the buttons lands the keyboard focus on the question itself.
+ const focusPanel = useRef(false);
+ const multiple = answers.length > 1;
const complete = answers.every(isAnswered);
+ const questionId = (part: string, index: number) => `${questionPrefix}-${part}-${index}`;
+ useEffect(() => {
+ if (panelsRef.current) panelsRef.current.scrollTop = 0;
+ if (!focusPanel.current) return;
+ focusPanel.current = false;
+ panelRef.current?.focus();
+ }, [position]);
const send = (option: string) => {
setBusy(true);
void respond(task.id, entry.id, option).finally(() => setBusy(false));
@@ -1906,12 +1921,18 @@ function QuestionForm({
answer.question.multiSelect ? { ...answer, other: checked ? "" : null } : { ...answer, picked: [], other: "" },
);
const chooseByNumber = (number: number) => {
- const answer = answers[focusedPosition];
+ const answer = answers[position];
if (!answer) return;
const option = answer.question.options[number - 1];
if (option) choose(answer, option.label, !answer.picked.includes(option.label));
else if (number === answer.question.options.length + 1) chooseOther(answer, answer.other === null);
};
+ const goTo = (next: number, moveFocus = false) => {
+ if (next < 0 || next >= answers.length) return;
+ focusPanel.current = moveFocus;
+ setPosition(next);
+ setHovered(null);
+ };
return (
<form
className={styles.questionCard}
@@ -1929,142 +1950,189 @@ function QuestionForm({
}
}}
>
- {answers.map((answer, position) => {
- const { question } = answer;
- const group = `question-${entry.id}-${position}`;
- const hasPreviews = question.options.some((option) => option.preview);
- const targetLabel =
- (hovered?.position === position ? hovered.label : undefined) ??
- answer.picked[0] ??
- (answer.other !== null ? group : undefined);
- const previewed =
- targetLabel === undefined
- ? question.options.find((option) => option.preview)
- : question.options.find((option) => option.label === targetLabel);
- const choices = [
- ...question.options.map((option) => ({
- key: option.label,
- checked: answer.picked.includes(option.label),
- onChange: (checked: boolean) => choose(answer, option.label, checked),
- label: (
- <span className={styles.questionOptionText}>
+ {multiple && (
+ <div inert={busy}>
+ <Tabs
+ variant="compact"
+ layout="squeeze"
+ aria-label={entry.title}
+ panelIdPrefix={questionPrefix}
+ activeId={String(position)}
+ onSelect={(id) => {
+ if (!busy) goTo(Number(id));
+ }}
+ items={answers.map((item, index) => ({
+ id: String(index),
+ label: <span>{item.question.header?.trim() || item.question.question}</span>,
+ text: item.question.header?.trim() || item.question.question,
+ tooltip: item.question.question,
+ trailing: isAnswered(item) ? (
+ <Icon name="check" size={12} className={styles.questionTabCheck} />
+ ) : undefined,
+ }))}
+ />
+ </div>
+ )}
+ {/* All questions stay mounted in one grid cell, so the card keeps the tallest one's height. */}
+ <div ref={panelsRef} className={clsx(styles.questionPanels, multiple && styles.questionPanelsPaged)}>
+ {answers.map((item, index) => {
+ const current = index === position;
+ const group = questionId("group", index);
+ const hasPreviews = item.question.options.some((option) => option.preview);
+ const targetLabel = (current ? hovered : null) ?? item.picked[0] ?? (item.other !== null ? group : undefined);
+ const previewed =
+ targetLabel === undefined
+ ? item.question.options.find((option) => option.preview)
+ : item.question.options.find((option) => option.label === targetLabel);
+ const choices = [
+ ...item.question.options.map((option) => ({
+ key: option.label,
+ checked: item.picked.includes(option.label),
+ onChange: (checked: boolean) => choose(item, option.label, checked),
+ label: (
+ <span className={styles.questionOptionText}>
+ <span className={styles.questionLabel}>
+ {plainLabel(option.label)}
+ {isRecommended(option.label) && (
+ <span className={styles.questionTag}>
+ <T>Recommended</T>
+ </span>
+ )}
+ </span>
+ {option.description && <span className={styles.questionDescription}>{option.description}</span>}
+ </span>
+ ),
+ })),
+ {
+ key: group,
+ checked: item.other !== null,
+ onChange: (checked: boolean) => chooseOther(item, checked),
+ label: (
<span className={styles.questionLabel}>
- {plainLabel(option.label)}
- {isRecommended(option.label) && (
- <span className={styles.questionTag}>
- <T>Recommended</T>
- </span>
- )}
+ <T>Other</T>
</span>
- {option.description && <span className={styles.questionDescription}>{option.description}</span>}
- </span>
- ),
- })),
- {
- key: group,
- checked: answer.other !== null,
- onChange: (checked: boolean) => chooseOther(answer, checked),
- label: (
- <span className={styles.questionLabel}>
- <T>Other</T>
- </span>
- ),
- },
- ];
- return (
- <fieldset
- key={group}
- className={styles.question}
- disabled={busy}
- onFocus={() => setFocusedPosition(position)}
- >
- <legend className={styles.questionText}>
- {question.header && <span className={styles.questionTag}>{question.header}</span>}
- {question.question}
- </legend>
- <div className={clsx(styles.questionBody, hasPreviews && styles.questionBodyWithPreview)}>
- <div className={styles.questionChoices}>
- {choices.map((choice, index) => {
- const label = (
- <span className={styles.questionChoice}>
- {choice.label}
- <span className={styles.questionKey}>{index + 1}</span>
- </span>
- );
- return (
- <div
- key={choice.key}
- onMouseEnter={() => setHovered({ position, label: choice.key })}
- onMouseLeave={() => setHovered(null)}
- >
- {question.multiSelect ? (
- <Checkbox
- className={styles.questionOption}
- checked={choice.checked}
- label={label}
- onChange={choice.onChange}
- />
- ) : (
- <Radio
- className={styles.questionOption}
- name={group}
- checked={choice.checked}
- label={label}
- onChange={() => choice.onChange(true)}
- />
- )}
- </div>
- );
- })}
- {answer.other !== null && (
- <Input
- autoFocus
- className={styles.questionOther}
- value={answer.other}
- placeholder="Type your answer"
- onChange={(event) => update(answer, { ...answer, other: event.target.value })}
- onKeyDown={(event) => {
- if (event.key === "Escape" && answer.other) {
- event.stopPropagation();
- update(answer, { ...answer, other: "" });
- }
- }}
- />
- )}
- </div>
- {hasPreviews && (
- <div className={styles.questionPreview}>
- {[...question.options, null].map((option) => {
- const active = option === (previewed ?? null);
- return (
- <div
- key={option?.label ?? group}
- className={clsx(styles.questionPreviewItem, active && styles.questionPreviewActive)}
- aria-hidden={!active}
- >
- <span className={styles.questionPreviewCaption}>
- {option ? plainLabel(option.label) : <T>Other</T>}
+ ),
+ },
+ ];
+ return (
+ <div
+ key={group}
+ ref={current ? panelRef : undefined}
+ role={multiple ? "tabpanel" : undefined}
+ id={questionId("panel", index)}
+ aria-labelledby={multiple ? questionId("tab", index) : undefined}
+ aria-hidden={!current}
+ inert={!current}
+ tabIndex={multiple && current ? 0 : -1}
+ className={clsx(styles.questionPanel, !current && styles.questionPanelHidden)}
+ >
+ <fieldset className={styles.question} disabled={busy}>
+ <legend className={styles.questionText}>
+ {item.question.header && <span className={styles.questionTag}>{item.question.header}</span>}
+ {item.question.question}
+ </legend>
+ <div className={clsx(styles.questionBody, hasPreviews && styles.questionBodyWithPreview)}>
+ <div className={styles.questionChoices}>
+ {choices.map((choice, choiceIndex) => {
+ const label = (
+ <span className={styles.questionChoice}>
+ {choice.label}
+ <span className={styles.questionKey}>{choiceIndex + 1}</span>
</span>
- {option?.preview ? (
- <pre className={styles.questionPreviewBody}>{option.preview}</pre>
- ) : (
- <span className={styles.questionPreviewEmpty}>
- <T>No preview</T>
- </span>
- )}
- </div>
- );
- })}
+ );
+ return (
+ <div
+ key={choice.key}
+ onMouseEnter={() => setHovered(choice.key)}
+ onMouseLeave={() => setHovered(null)}
+ >
+ {item.question.multiSelect ? (
+ <Checkbox
+ className={styles.questionOption}
+ checked={choice.checked}
+ label={label}
+ onChange={choice.onChange}
+ />
+ ) : (
+ <Radio
+ className={styles.questionOption}
+ name={group}
+ checked={choice.checked}
+ label={label}
+ onChange={() => choice.onChange(true)}
+ />
+ )}
+ </div>
+ );
+ })}
+ {item.other !== null && (
+ <Input
+ autoFocus
+ className={styles.questionOther}
+ value={item.other}
+ placeholder="Type your answer"
+ onChange={(event) => update(item, { ...item, other: event.target.value })}
+ onKeyDown={(event) => {
+ if (event.key === "Escape" && item.other) {
+ event.stopPropagation();
+ update(item, { ...item, other: "" });
+ }
+ }}
+ />
+ )}
+ </div>
+ {hasPreviews && (
+ <div className={styles.questionPreview}>
+ {[...item.question.options, null].map((option) => {
+ const shown = option === (previewed ?? null);
+ return (
+ <div
+ key={option?.label ?? group}
+ className={clsx(styles.questionPreviewItem, shown && styles.questionPreviewActive)}
+ aria-hidden={!shown}
+ >
+ <span className={styles.questionPreviewCaption}>
+ {option ? plainLabel(option.label) : <T>Other</T>}
+ </span>
+ {option?.preview ? (
+ <pre className={styles.questionPreviewBody}>{option.preview}</pre>
+ ) : (
+ <span className={styles.questionPreviewEmpty}>
+ <T>No preview</T>
+ </span>
+ )}
+ </div>
+ );
+ })}
+ </div>
+ )}
</div>
- )}
+ </fieldset>
</div>
- </fieldset>
- );
- })}
+ );
+ })}
+ </div>
<div className={styles.questionActions}>
<Button variant="ghost" disabled={busy} onClick={() => send("reject")}>
Skip
</Button>
+ {multiple && (
+ <div className={styles.questionPager}>
+ <Button size="small" disabled={busy || position === 0} onClick={() => goTo(position - 1, true)}>
+ Previous
+ </Button>
+ <span className={styles.questionPage}>
+ {position + 1} / {answers.length}
+ </span>
+ <Button
+ size="small"
+ disabled={busy || position === answers.length - 1}
+ onClick={() => goTo(position + 1, true)}
+ >
+ Next
+ </Button>
+ </div>
+ )}
<Button type="submit" variant="primary" disabled={busy || !complete}>
Submit
</Button>
diff --git a/src/features/agents/sessionState.test.tsx b/src/features/agents/sessionState.test.tsx
index 4b7397e2e..7b41c2040 100644
--- a/src/features/agents/sessionState.test.tsx
+++ b/src/features/agents/sessionState.test.tsx
@@ -498,6 +498,7 @@ describe("a pending AskUserQuestion", () => {
render(<SessionEditor input={input("A")} />);
const card = await screen.findByRole("form", { name: "Which?" });
fireEvent.click(within(card).getByRole("radio", { name: /^One/ }));
+ fireEvent.click(within(card).getByRole("tab", { name: "second" }));
fireEvent.click(within(card).getByRole("radio", { name: /^Two/ }));
fireEvent.click(within(card).getByRole("button", { name: "Submit" }));
await waitFor(() =>
@@ -505,7 +506,7 @@ describe("a pending AskUserQuestion", () => {
);
});
- it("shows every question with its descriptions in a card and sends all answers at once", async () => {
+ it("shows one question at a time with tabs and sends all answers at once", async () => {
backend.entries.set("A", [
{
type: "permission",
@@ -540,14 +541,36 @@ describe("a pending AskUserQuestion", () => {
render(<SessionEditor input={input("A")} />);
const card = await screen.findByRole("form", { name: "Which layout?" });
expect(screen.queryByRole("alert")).toBeNull();
+ const tabs = within(card).getAllByRole("tab");
+ expect(tabs.map((tab) => tab.textContent)).toEqual(["Layout", "Checks"]);
+ const panel = within(card).getByRole("tabpanel", { name: "Layout" });
+ expect(panel).toHaveAttribute("tabindex", "0");
+ expect(tabs[0]).toHaveAttribute("aria-controls", panel.id);
+ tabs[0]!.focus();
+ fireEvent.keyDown(tabs[0]!, { key: "ArrowLeft" });
+ expect(tabs[1]).toHaveFocus();
+ expect(tabs[1]).toHaveAttribute("aria-selected", "true");
+ fireEvent.keyDown(tabs[1]!, { key: "Home" });
+ expect(tabs[0]).toHaveFocus();
+ // Every question stays mounted (one grid cell), so switching tabs keeps the card's height.
+ expect(card.querySelectorAll('[role="tabpanel"]')).toHaveLength(2);
expect(within(card).getByText("One row per check")).toBeTruthy();
expect(within(card).getByText("Recommended")).toBeTruthy();
+ // Only the first question is on screen; the second waits behind its tab.
+ expect(within(card).queryByRole("checkbox", { name: /^Disk/ })).toBeNull();
const submit = within(card).getByRole("button", { name: "Submit" });
fireEvent.click(within(card).getByRole("radio", { name: /^List/ }));
expect(submit).toHaveProperty("disabled", true);
+ // Paging moves between questions, without losing the answers already given.
+ expect(within(card).getByRole("button", { name: "Previous" })).toHaveProperty("disabled", true);
+ fireEvent.click(within(card).getByRole("button", { name: "Next" }));
+ expect(within(card).getByRole("tab", { name: "Checks" })).toHaveAttribute("aria-selected", "true");
+ expect(within(card).getByRole("tabpanel", { name: "Checks" })).toHaveFocus();
+ fireEvent.click(within(card).getByRole("tab", { name: "Layout" }));
+ expect(within(card).getByRole("radio", { name: /^List/ })).toHaveProperty("checked", true);
+ fireEvent.click(within(card).getByRole("tab", { name: "Checks" }));
fireEvent.click(within(card).getByRole("checkbox", { name: /^Disk/ }));
- const others = within(card).getAllByRole("checkbox", { name: /^Other/ });
- fireEvent.click(others[0]!);
+ fireEvent.click(within(card).getByRole("checkbox", { name: /^Other/ }));
expect(submit).toHaveProperty("disabled", true);
fireEvent.change(within(card).getByPlaceholderText("Type your answer"), { target: { value: "GPU temps" } });
fireEvent.click(submit);
@@ -583,6 +606,9 @@ describe("a pending AskUserQuestion", () => {
useAgents.setState({ entries: new Map(backend.entries) });
render(<SessionEditor input={input("A")} />);
const card = await screen.findByRole("form", { name: "Which layout?" });
+ expect(within(card).queryByRole("tablist")).toBeNull();
+ expect(within(card).queryByRole("tabpanel")).toBeNull();
+ expect(within(card).queryByRole("button", { name: "Next" })).toBeNull();
const table = within(card).getByRole("radio", { name: /^Table/ });
const list = within(card).getByRole("radio", { name: /^List/ });
fireEvent.focus(table);
diff --git a/src/platform/locales/text/en.json b/src/platform/locales/text/en.json
index 3751385ce..3fec084a7 100644
--- a/src/platform/locales/text/en.json
+++ b/src/platform/locales/text/en.json
@@ -190,6 +190,8 @@
"Type your answer": "Type your answer",
"Recommended": "Recommended",
"No preview": "No preview",
+ "Previous": "Previous",
+ "Next": "Next",
"Running in the background": "Running in the background",
"Couldn't stop the background task": "Couldn't stop the background task",
"Copy Markdown": "Copy Markdown",
diff --git a/src/platform/locales/text/es.json b/src/platform/locales/text/es.json
index d4262de67..f1e4d62b4 100644
--- a/src/platform/locales/text/es.json
+++ b/src/platform/locales/text/es.json
@@ -2110,6 +2110,8 @@
"Sign-off commit": "Firmar confirmación (sign-off)",
"Size": "Tamaño",
"Size:": "Tamaño:",
+ "Previous": "Anterior",
+ "Next": "Siguiente",
"Skip": "Omitir",
"Skip Commit": "Omitir confirmación",
"Skip if defined": "Omitir si está definido",
diff --git a/src/platform/locales/text/fr.json b/src/platform/locales/text/fr.json
index 61d745ed3..10fb3f224 100644
--- a/src/platform/locales/text/fr.json
+++ b/src/platform/locales/text/fr.json
@@ -2009,6 +2009,8 @@
"Sign-off commit": "Signer le commit (sign-off)",
"Size": "Taille",
"Size:": "Taille :",
+ "Previous": "Précédent",
+ "Next": "Suivant",
"Skip": "Ignorer",
"Skip Commit": "Ignorer le commit",
"Skip if defined": "Ignorer si défini",
diff --git a/src/platform/locales/text/ko.json b/src/platform/locales/text/ko.json
index f2e924534..bd9cdc006 100644
--- a/src/platform/locales/text/ko.json
+++ b/src/platform/locales/text/ko.json
@@ -2166,6 +2166,8 @@
"Sign-off commit": "커밋 서명(Sign-off)",
"Size": "크기",
"Size:": "크기:",
+ "Previous": "이전",
+ "Next": "다음",
"Skip": "건너뛰기",
"Skip Commit": "커밋 건너뛰기",
"Skip if defined": "정의된 경우 건너뛰기",
diff --git a/src/platform/locales/text/pl.json b/src/platform/locales/text/pl.json
index f4c145ef8..4ab651803 100644
--- a/src/platform/locales/text/pl.json
+++ b/src/platform/locales/text/pl.json
@@ -2091,6 +2091,8 @@
"Sign-off commit": "Podpisz zatwierdzenie (sign-off)",
"Size": "Rozmiar",
"Size:": "Rozmiar:",
+ "Previous": "Poprzedni",
+ "Next": "Następny",
"Skip": "Pomiń",
"Skip Commit": "Pomiń zatwierdzenie",
"Skip if defined": "Pomiń, jeśli zdefiniowano",
diff --git a/src/platform/locales/text/pt.json b/src/platform/locales/text/pt.json
index 7603b005c..09a7f5815 100644
--- a/src/platform/locales/text/pt.json
+++ b/src/platform/locales/text/pt.json
@@ -2092,6 +2092,8 @@
"Sign-off commit": "Assinar commit (sign-off)",
"Size": "Tamanho",
"Size:": "Tamanho:",
+ "Previous": "Anterior",
+ "Next": "Próximo",
"Skip": "Ignorar",
"Skip Commit": "Pular commit",
"Skip if defined": "Ignorar se definido",
diff --git a/src/platform/locales/text/zh.json b/src/platform/locales/text/zh.json
index d59fa8c4d..4258d180d 100644
--- a/src/platform/locales/text/zh.json
+++ b/src/platform/locales/text/zh.json
@@ -6657,6 +6657,8 @@
"Type your answer": "输入你的回答",
"Recommended": "推荐",
"No preview": "无预览",
+ "Previous": "上一题",
+ "Next": "下一题",
"Running in the background": "后台运行中",
"Couldn't stop the background task": "无法停止后台任务",
"Stage {count} files": "暂存 {count} 个文件",