Skip to content

Same agent Smaller bill. The tools and infrastructure to get more work from your AI. Fewer tokens. Less compute. Lower cost.

fix: fail fast when clickhouse migrations fail (#1522)

mikemikimike1783f61dabf8
diff --git a/src/client/src/__tests__/clickhouse/migrations/create-custom-dashboards-migration.test.ts b/src/client/src/__tests__/clickhouse/migrations/create-custom-dashboards-migration.test.ts
new file mode 100644
index 00000000..15fae7a2
--- /dev/null
+++ b/src/client/src/__tests__/clickhouse/migrations/create-custom-dashboards-migration.test.ts
@@ -0,0 +1,82 @@
+describe("custom dashboard migration", () => {
+ it("does not seed dashboards when table creation fails", async () => {
+ jest.resetModules();
+ const mockHelper = jest.fn().mockResolvedValue({
+ migrationExist: false,
+ queriesRun: false,
+ });
+ const mockTableCollector = jest.fn().mockResolvedValue({
+ data: [
+ { name: "openlit_folder" },
+ { name: "openlit_board" },
+ { name: "openlit_widget" },
+ { name: "openlit_board_widget" },
+ ],
+ });
+ const mockSeed = jest.fn();
+ jest.doMock("@/clickhouse/migrations/migration-helper", () => ({
+ __esModule: true,
+ default: mockHelper,
+ }));
+ jest.doMock("@/clickhouse/seed/dashboards", () => ({
+ __esModule: true,
+ default: mockSeed,
+ }));
+ jest.doMock("@/lib/platform/common", () => ({
+ __esModule: true,
+ intelligenceDataCollector: mockTableCollector,
+ }));
+
+ const { default: migration } =
+ await import("@/clickhouse/migrations/create-custom-dashboards-migration");
+
+ await expect(migration("db-1")).resolves.toEqual({
+ migrationExist: false,
+ queriesRun: false,
+ });
+ expect(mockSeed).not.toHaveBeenCalled();
+ });
+
+ it("reports missing dashboard tables and does not seed", async () => {
+ jest.resetModules();
+ const mockHelper = jest.fn().mockResolvedValue({
+ migrationExist: false,
+ queriesRun: true,
+ });
+ const mockTableCollector = jest.fn().mockResolvedValue({
+ data: [{ name: "openlit_folder" }, { name: "openlit_board" }],
+ });
+ const mockSeed = jest.fn();
+ jest.doMock("@/clickhouse/migrations/migration-helper", () => ({
+ __esModule: true,
+ default: mockHelper,
+ }));
+ jest.doMock("@/clickhouse/seed/dashboards", () => ({
+ __esModule: true,
+ default: mockSeed,
+ }));
+ jest.doMock("@/lib/platform/common", () => ({
+ __esModule: true,
+ intelligenceDataCollector: mockTableCollector,
+ }));
+
+ const { default: migration } =
+ await import("@/clickhouse/migrations/create-custom-dashboards-migration");
+
+ await expect(migration("db-1")).resolves.toMatchObject({
+ migrationExist: false,
+ queriesRun: true,
+ err: expect.stringContaining(
+ "missing tables: openlit_widget, openlit_board_widget"
+ ),
+ });
+ expect(mockSeed).not.toHaveBeenCalled();
+ expect(mockTableCollector).toHaveBeenCalledWith(
+ expect.objectContaining({
+ query: expect.stringContaining("system.tables"),
+ }),
+ "query",
+ "db-1"
+ );
+ });
+});
diff --git a/src/client/src/__tests__/clickhouse/migrations/migrations-index.test.ts b/src/client/src/__tests__/clickhouse/migrations/migrations-index.test.ts
new file mode 100644
index 00000000..82c216d8
--- /dev/null
+++ b/src/client/src/__tests__/clickhouse/migrations/migrations-index.test.ts
@@ -0,0 +1,109 @@
+const mockMigration = jest.fn();
+
+const MIGRATION_MODULES = [
+ "@/clickhouse/migrations/create-prompt-migration",
+ "@/clickhouse/migrations/create-vault-migration",
+ "@/clickhouse/migrations/create-evaluation-migration",
+ "@/clickhouse/migrations/create-evaluation-type-defaults-migration",
+ "@/clickhouse/migrations/create-cron-log-migration",
+ "@/clickhouse/migrations/create-custom-dashboards-migration",
+ "@/clickhouse/migrations/create-openground-migration",
+ "@/clickhouse/migrations/create-rule-engine-migration",
+ "@/clickhouse/migrations/create-controller-migration",
+ "@/clickhouse/migrations/create-chat-migration",
+ "@/clickhouse/migrations/create-agents-summary-migration",
+ "@/clickhouse/migrations/create-agent-versions-migration",
+ "@/clickhouse/migrations/alter-controller-mode-migration",
+ "@/clickhouse/migrations/add-controller-resource-attrs-migration",
+ "@/clickhouse/migrations/add-controller-workload-key-migration",
+ "@/clickhouse/migrations/add-controller-sdk-actions-migration",
+ "@/clickhouse/migrations/add-controller-ttl-migration",
+ "@/clickhouse/migrations/add-controller-cluster-id-migration",
+ "@/clickhouse/migrations/update-controller-actions-ttl-migration",
+ "@/clickhouse/migrations/generalize-controller-desired-states-migration",
+ "@/clickhouse/migrations/add-controller-skipping-indexes-migration",
+ "@/clickhouse/migrations/create-providers-migration",
+ "@/clickhouse/migrations/add-provider-models-cache-prices-migration",
+ "@/clickhouse/migrations/create-provider-metadata-migration",
+ "@/clickhouse/migrations/drop-legacy-openground-tables-migration",
+ "@/clickhouse/migrations/seed-orcarouter-provider-migration",
+ "@/clickhouse/migrations/encrypt-vault-values-migration",
+ "@/clickhouse/migrations/add-chat-conversation-type-migration",
+ "@/clickhouse/migrations/add-chat-message-model-attribution-migration",
+ "@/clickhouse/migrations/create-trace-analysis-migration",
+ "@/clickhouse/migrations/create-otter-runs-migration",
+ "@/clickhouse/migrations/add-agents-summary-skip-indexes-migration",
+ "@/clickhouse/migrations/optimize-agent-tables-storage-migration",
+ "@/clickhouse/migrations/add-coding-agent-summary-fields-migration",
+ "@/clickhouse/migrations/create-coding-agents-audit-migration",
+ "@/clickhouse/migrations/add-coding-agent-loc-summary-fields-migration",
+ "@/clickhouse/migrations/create-telemetry-rollups-migration",
+ "@/clickhouse/migrations/alter-telemetry-rollups-dimensions-migration",
+ "@/clickhouse/migrations/drop-vcs-migration",
+];
+
+describe("ClickHouse migration orchestration", () => {
+ beforeEach(() => {
+ jest.resetModules();
+ mockMigration.mockReset();
+ for (const moduleName of MIGRATION_MODULES) {
+ jest.doMock(moduleName, () => ({
+ __esModule: true,
+ default: mockMigration,
+ }));
+ }
+ });
+
+ it("rejects when a migration reports partially failed queries", async () => {
+ mockMigration.mockResolvedValue({ migrationExist: true });
+ mockMigration.mockResolvedValueOnce({
+ migrationExist: false,
+ queriesRun: false,
+ });
+
+ const { default: migrations } = await import("@/clickhouse/migrations");
+
+ await expect(migrations("db-1")).rejects.toThrow(
+ 'ClickHouse migration "create-prompt" failed',
+ );
+ // All independent creates may already be in flight, but dependent
+ // groups must not start after the failed group completes.
+ expect(mockMigration).toHaveBeenCalledTimes(12);
+ });
+
+ it("rejects when a migration returns no result", async () => {
+ let callCount = 0;
+ mockMigration.mockImplementation(async () => {
+ callCount += 1;
+ // Group 1 is 12 parallel creates; the first sequential migration is
+ // add-controller-cluster-id's predecessor, alter-controller-mode.
+ if (callCount === 13) return undefined;
+ return { migrationExist: true };
+ });
+
+ const { default: migrations } = await import("@/clickhouse/migrations");
+
+ await expect(migrations("db-1")).rejects.toThrow(
+ 'ClickHouse migration "alter-controller-mode" failed: the migration did not report successful completion',
+ );
+ expect(mockMigration).toHaveBeenCalledTimes(13);
+ });
+
+ it("rejects when the OrcaRouter seed fails and does not continue", async () => {
+ let callCount = 0;
+ mockMigration.mockImplementation(async () => {
+ callCount += 1;
+ // 12 independent creates + 9 controller schema steps + create-providers
+ // + cache-prices + 2 parallel provider-group migrations + seed.
+ if (callCount === 26) return { err: "seed failed" };
+ return { migrationExist: true };
+ });
+
+ const { default: migrations } = await import("@/clickhouse/migrations");
+
+ await expect(migrations("db-1")).rejects.toThrow(
+ 'ClickHouse migration "seed-orcarouter-provider" failed: seed failed',
+ );
+ expect(mockMigration).toHaveBeenCalledTimes(26);
+ });
+});
diff --git a/src/client/src/clickhouse/migrations/add-controller-cluster-id-migration.ts b/src/client/src/clickhouse/migrations/add-controller-cluster-id-migration.ts
index 4bc83d7e..05a80dc8 100644
--- a/src/client/src/clickhouse/migrations/add-controller-cluster-id-migration.ts
+++ b/src/client/src/clickhouse/migrations/add-controller-cluster-id-migration.ts
@@ -1,15 +1,24 @@
-import { dataCollector } from "@/lib/platform/common";
+import {
+ CONTROLLER_ACTIONS_TABLE,
+ CONTROLLER_INSTANCES_TABLE,
+ CONTROLLER_SERVICES_TABLE,
+} from "@/lib/platform/controller/table-details";
+import migrationHelper from "./migration-helper";
+
+const MIGRATION_ID = "add-controller-cluster-id";
export default async function AddControllerClusterIdMigration(
databaseConfigId?: string
) {
const queries = [
- `ALTER TABLE openlit_controller_services ADD COLUMN IF NOT EXISTS cluster_id String DEFAULT 'default'`,
- `ALTER TABLE openlit_controller_instances ADD COLUMN IF NOT EXISTS cluster_id String DEFAULT 'default'`,
- `ALTER TABLE openlit_controller_actions ADD COLUMN IF NOT EXISTS cluster_id String DEFAULT 'default'`,
+ `ALTER TABLE ${CONTROLLER_SERVICES_TABLE} ADD COLUMN IF NOT EXISTS cluster_id String DEFAULT 'default';`,
+ `ALTER TABLE ${CONTROLLER_INSTANCES_TABLE} ADD COLUMN IF NOT EXISTS cluster_id String DEFAULT 'default';`,
+ `ALTER TABLE ${CONTROLLER_ACTIONS_TABLE} ADD COLUMN IF NOT EXISTS cluster_id String DEFAULT 'default';`,
];
- for (const query of queries) {
- await dataCollector({ query }, "query", databaseConfigId);
- }
+ return migrationHelper({
+ clickhouseMigrationId: MIGRATION_ID,
+ databaseConfigId,
+ queries,
+ });
}
diff --git a/src/client/src/clickhouse/migrations/create-custom-dashboards-migration.ts b/src/client/src/clickhouse/migrations/create-custom-dashboards-migration.ts
index a2b7f315..15551b79 100644
--- a/src/client/src/clickhouse/migrations/create-custom-dashboards-migration.ts
+++ b/src/client/src/clickhouse/migrations/create-custom-dashboards-migration.ts
@@ -1,5 +1,6 @@
import migrationHelper from "./migration-helper";
import CreateCustomDashboardsSeed from "../seed/dashboards";
+import { intelligenceDataCollector } from "@/lib/platform/common";
const MIGRATION_ID = "create-custom-dashboards-table";
@@ -8,6 +9,50 @@ const CUSTOM_DASHBOARDS_BOARDS_TABLE = "openlit_board";
const CUSTOM_DASHBOARDS_FOLDERS_TABLE = "openlit_folder";
const CUSTOM_DASHBOARDS_WIDGETS_TABLE = "openlit_widget";
const CUSTOM_DASHBOARDS_BOARD_WIDGETS_TABLE = "openlit_board_widget";
+const EXPECTED_CUSTOM_DASHBOARD_TABLES = [
+ CUSTOM_DASHBOARDS_FOLDERS_TABLE,
+ CUSTOM_DASHBOARDS_BOARDS_TABLE,
+ CUSTOM_DASHBOARDS_WIDGETS_TABLE,
+ CUSTOM_DASHBOARDS_BOARD_WIDGETS_TABLE,
+];
+
+async function verifyCustomDashboardTables(databaseConfigId?: string) {
+ // `system.tables` has a stable `name` column. `SHOW TABLES` JSONEachRow
+ // shapes have varied across ClickHouse versions; a parse miss here would
+ // fail this group-1 migration and skip every later schema migration.
+ const quotedNames = EXPECTED_CUSTOM_DASHBOARD_TABLES.map(
+ (tableName) => `'${tableName}'`
+ ).join(", ");
+ const { data, err } = await intelligenceDataCollector(
+ {
+ query: `
+ SELECT name
+ FROM system.tables
+ WHERE database = currentDatabase()
+ AND name IN (${quotedNames})
+ `,
+ },
+ "query",
+ databaseConfigId
+ );
+ if (err) return { err };
+
+ const existingTables = new Set(
+ (Array.isArray(data) ? data : [])
+ .map((row) => {
+ if (typeof row === "string") return row;
+ if (!row || typeof row !== "object") return "";
+ const tableRow = row as { name?: unknown; table?: unknown };
+ return String(tableRow.name ?? tableRow.table ?? "");
+ })
+ .filter(Boolean)
+ );
+ const missingTables = EXPECTED_CUSTOM_DASHBOARD_TABLES.filter(
+ (tableName) => !existingTables.has(tableName)
+ );
+
+ return { missingTables };
+}
export default async function CreateCustomDashboardsMigration(databaseConfigId?: string) {
const queries = [
@@ -95,15 +140,40 @@ export default async function CreateCustomDashboardsMigration(databaseConfigId?:
PRIMARY KEY id
) ENGINE = MergeTree()
ORDER BY (id, board_id, widget_id, created_at);
- `
+ `,
];
- const { migrationExist, queriesRun } = await migrationHelper({
+ const { migrationExist, queriesRun, err: migrationErr } = await migrationHelper({
clickhouseMigrationId: MIGRATION_ID,
databaseConfigId,
queries,
});
+ const tableVerification = await verifyCustomDashboardTables(databaseConfigId);
+ if (tableVerification.err) {
+ const errorMessage = migrationErr
+ ? `ClickHouse migration failed: ${String(migrationErr)}; table verification also failed: ${String(tableVerification.err)}`
+ : `ClickHouse dashboard table verification failed: ${String(tableVerification.err)}`;
+ console.error(errorMessage);
+ return { migrationExist, queriesRun, err: errorMessage };
+ }
+
+ if (tableVerification.missingTables?.length) {
+ const errorMessage = `${migrationErr ? `ClickHouse migration failed: ${String(migrationErr)}; ` : ""}ClickHouse dashboard table verification failed; missing tables: ${tableVerification.missingTables.join(", ")}`;
+ console.error(errorMessage);
+ return { migrationExist, queriesRun, err: errorMessage };
+ }
+
+ // Do not seed dashboards when table creation failed. The migration helper
+ // deliberately leaves failed migrations unrecorded so a later boot can
+ // retry them, but the seed path needs the same failure boundary; otherwise
+ // startup can report success while dashboard inserts hit missing tables.
+ if (!migrationExist && !queriesRun) {
+ return migrationErr
+ ? { migrationExist, queriesRun, err: migrationErr }
+ : { migrationExist, queriesRun };
+ }
+
// Always run the seed -- it is idempotent per-title via
// `boardExistsByTitle` and exists precisely so that dashboards
// added to `SEEDED_DASHBOARDS` after a stack's first boot still
diff --git a/src/client/src/clickhouse/migrations/index.ts b/src/client/src/clickhouse/migrations/index.ts
index efe55dc5..155d730c 100644
--- a/src/client/src/clickhouse/migrations/index.ts
+++ b/src/client/src/clickhouse/migrations/index.ts
@@ -38,60 +38,91 @@ import SeedOrcaRouterProviderMigration from "./seed-orcarouter-provider-migratio
import CreateTelemetryRollupsMigration from "./create-telemetry-rollups-migration";
import AlterTelemetryRollupsDimensionsMigration from "./alter-telemetry-rollups-dimensions-migration";
+type MigrationResult = {
+ migrationExist?: boolean;
+ queriesRun?: boolean;
+ err?: unknown;
+ data?: unknown;
+};
+
+function migrationSucceeded(result: unknown): result is MigrationResult {
+ if (!result || typeof result !== "object") return false;
+
+ const migrationResult = result as MigrationResult;
+ if (migrationResult.err) return false;
+ if (migrationResult.migrationExist === true) return true;
+ if ("queriesRun" in migrationResult) {
+ return migrationResult.queriesRun === true;
+ }
+
+ // A few legacy migrations return `{ data: ... }` instead of the
+ // migrationHelper result shape. Keep accepting that successful contract,
+ // while rejecting missing or unrecognised results.
+ return "data" in migrationResult;
+}
+
+async function runMigration(name: string, migration: () => Promise<unknown>): Promise<MigrationResult> {
+ const result = await migration();
+ if (migrationSucceeded(result)) return result;
+
+ const details = result && typeof result === "object" && "err" in result ? String((result as MigrationResult).err) : "the migration did not report successful completion";
+ throw new Error(`ClickHouse migration "${name}" failed: ${details}`);
+}
+
export default async function migrations(databaseConfigId?: string) {
// Group 1: Independent table creations (safe to parallel)
await Promise.all([
- CreatePromptMigration(databaseConfigId),
- CreateVaultMigration(databaseConfigId),
- CreateEvaluationMigration(databaseConfigId),
- CreateEvaluationTypeDefaultsMigration(databaseConfigId),
- CreateCronLogMigration(databaseConfigId),
- CreateCustomDashboardsMigration(databaseConfigId),
- CreateOpengroundMigration(databaseConfigId),
- CreateRuleEngineMigration(databaseConfigId),
- CreateControllerMigration(databaseConfigId),
- CreateChatMigration(databaseConfigId),
- CreateAgentsSummaryMigration(databaseConfigId),
- CreateAgentVersionsMigration(databaseConfigId),
+ runMigration("create-prompt", () => CreatePromptMigration(databaseConfigId)),
+ runMigration("create-vault", () => CreateVaultMigration(databaseConfigId)),
+ runMigration("create-evaluation", () => CreateEvaluationMigration(databaseConfigId)),
+ runMigration("create-evaluation-type-defaults", () => CreateEvaluationTypeDefaultsMigration(databaseConfigId)),
+ runMigration("create-cron-log", () => CreateCronLogMigration(databaseConfigId)),
+ runMigration("create-custom-dashboards", () => CreateCustomDashboardsMigration(databaseConfigId)),
+ runMigration("create-openground", () => CreateOpengroundMigration(databaseConfigId)),
+ runMigration("create-rule-engine", () => CreateRuleEngineMigration(databaseConfigId)),
+ runMigration("create-controller", () => CreateControllerMigration(databaseConfigId)),
+ runMigration("create-chat", () => CreateChatMigration(databaseConfigId)),
+ runMigration("create-agents-summary", () => CreateAgentsSummaryMigration(databaseConfigId)),
+ runMigration("create-agent-versions", () => CreateAgentVersionsMigration(databaseConfigId)),
]);
// Group 2: Controller schema modifications (must be sequential --
// each ALTER/CREATE depends on the previous step completing)
- await AlterControllerModeMigration(databaseConfigId);
- await AddControllerResourceAttrsMigration(databaseConfigId);
- await AddControllerWorkloadKeyMigration(databaseConfigId);
- await AddControllerSDKActionsMigration(databaseConfigId);
- await AddControllerTTLMigration(databaseConfigId);
- await AddControllerClusterIdMigration(databaseConfigId);
- await UpdateControllerActionsTTLMigration(databaseConfigId);
- await GeneralizeControllerDesiredStatesMigration(databaseConfigId);
- await AddControllerSkippingIndexesMigration(databaseConfigId);
+ await runMigration("alter-controller-mode", () => AlterControllerModeMigration(databaseConfigId));
+ await runMigration("add-controller-resource-attrs", () => AddControllerResourceAttrsMigration(databaseConfigId));
+ await runMigration("add-controller-workload-key", () => AddControllerWorkloadKeyMigration(databaseConfigId));
+ await runMigration("add-controller-sdk-actions", () => AddControllerSDKActionsMigration(databaseConfigId));
+ await runMigration("add-controller-ttl", () => AddControllerTTLMigration(databaseConfigId));
+ await runMigration("add-controller-cluster-id", () => AddControllerClusterIdMigration(databaseConfigId));
+ await runMigration("update-controller-actions-ttl", () => UpdateControllerActionsTTLMigration(databaseConfigId));
+ await runMigration("generalize-controller-desired-states", () => GeneralizeControllerDesiredStatesMigration(databaseConfigId));
+ await runMigration("add-controller-skipping-indexes", () => AddControllerSkippingIndexesMigration(databaseConfigId));
// Group 3: Provider migrations (sequential -- metadata depends on providers)
- await CreateProvidersMigration(databaseConfigId);
- await AddProviderModelsCachePricesMigration(databaseConfigId);
+ await runMigration("create-providers", () => CreateProvidersMigration(databaseConfigId));
+ await runMigration("add-provider-models-cache-prices", () => AddProviderModelsCachePricesMigration(databaseConfigId));
await Promise.all([
- CreateProviderMetadataMigration(databaseConfigId),
- DropLegacyOpengroundTablesMigration(databaseConfigId),
+ runMigration("create-provider-metadata", () => CreateProviderMetadataMigration(databaseConfigId)),
+ runMigration("drop-legacy-openground-tables", () => DropLegacyOpengroundTablesMigration(databaseConfigId)),
]);
- await SeedOrcaRouterProviderMigration(databaseConfigId);
+ await runMigration("seed-orcarouter-provider", () => SeedOrcaRouterProviderMigration(databaseConfigId));
- await EncryptVaultValuesMigration(databaseConfigId);
- await AddChatConversationTypeMigration(databaseConfigId);
- await AddChatMessageModelAttributionMigration(databaseConfigId);
- await CreateTraceAnalysisMigration(databaseConfigId);
- await CreateOtterRunsMigration(databaseConfigId);
+ await runMigration("encrypt-vault-values", () => EncryptVaultValuesMigration(databaseConfigId));
+ await runMigration("add-chat-conversation-type", () => AddChatConversationTypeMigration(databaseConfigId));
+ await runMigration("add-chat-message-model-attribution", () => AddChatMessageModelAttributionMigration(databaseConfigId));
+ await runMigration("create-trace-analysis", () => CreateTraceAnalysisMigration(databaseConfigId));
+ await runMigration("create-otter-runs", () => CreateOtterRunsMigration(databaseConfigId));
// Group 4: Agent table optimisations (sequential -- must run after the
// agents-summary + agent-versions CREATEs).
- await AddAgentsSummarySkipIndexesMigration(databaseConfigId);
- await OptimizeAgentTablesStorageMigration(databaseConfigId);
+ await runMigration("add-agents-summary-skip-indexes", () => AddAgentsSummarySkipIndexesMigration(databaseConfigId));
+ await runMigration("optimize-agent-tables-storage", () => OptimizeAgentTablesStorageMigration(databaseConfigId));
// Group 5: Coding-agent extensions (sequential — must run after
// agents_summary exists; safe to parallel within itself).
await Promise.all([
- AddCodingAgentSummaryFieldsMigration(databaseConfigId),
- CreateCodingAgentsAuditMigration(databaseConfigId),
+ runMigration("add-coding-agent-summary-fields", () => AddCodingAgentSummaryFieldsMigration(databaseConfigId)),
+ runMigration("create-coding-agents-audit", () => CreateCodingAgentsAuditMigration(databaseConfigId)),
]);
// Group 6: LOC / commit / PR rollup columns. Must run after the
@@ -99,16 +130,16 @@ export default async function migrations(databaseConfigId?: string) {
// the same `openlit_agents_summary` table; ClickHouse serialises
// ALTERs on a single table anyway, but ordering the awaits keeps
// the dependency explicit.
- await AddCodingAgentLOCSummaryFieldsMigration(databaseConfigId);
+ await runMigration("add-coding-agent-loc-summary-fields", () => AddCodingAgentLOCSummaryFieldsMigration(databaseConfigId));
- await CreateTelemetryRollupsMigration(databaseConfigId);
- await AlterTelemetryRollupsDimensionsMigration(databaseConfigId);
+ await runMigration("create-telemetry-rollups", () => CreateTelemetryRollupsMigration(databaseConfigId));
+ await runMigration("alter-telemetry-rollups-dimensions", () => AlterTelemetryRollupsDimensionsMigration(databaseConfigId));
// Group 7: Drop the never-populated v2 GitHub App VCS tables that
// earlier deployments created via the now-removed
// `create-vcs-migration`. Runs last so stale deployments still get
// the cleanup, and uses IF EXISTS so fresh installs are no-ops.
- await DropVcsMigration(databaseConfigId);
+ await runMigration("drop-vcs", () => DropVcsMigration(databaseConfigId));
// Built-in dashboard seeding (LLM / Vector DB / GPU / Coding
// Agents / future) lives inside `create-custom-dashboards-migration`
diff --git a/src/client/src/clickhouse/migrations/migration-helper.ts b/src/client/src/clickhouse/migrations/migration-helper.ts
index 2ef96be0..05869a61 100644
--- a/src/client/src/clickhouse/migrations/migration-helper.ts
+++ b/src/client/src/clickhouse/migrations/migration-helper.ts
@@ -94,5 +94,9 @@ export default async function migrationHelper({
return { migrationExist: false, queriesRun: true };
}
- return { migrationExist: false, queriesRun: false };
+ return {
+ migrationExist: false,
+ queriesRun: false,
+ err: queriesRun.find(({ err }) => err)?.err,
+ };
}