Same agent Smaller bill. The tools and infrastructure to get more work from your AI. Fewer tokens. Less compute. Lower cost.
TypeScript agent-harnessagent-harness-engineeringai-engineeringai-observabilityamd-gpuclaude-codeclickhousecodexcoding-agentcoding-agentscursorgenaigpu-monitoringllm-observabilityllmopsnvidia-smiobservabilityopen-sourceopenaiopentelemetry
fix: ensure trailing newline in crontab input and remove redundant try/catch (#1108)
Aman Agarwal71401ffaab18
diff --git a/src/client/src/helpers/server/cron.ts b/src/client/src/helpers/server/cron.tsindex e35a859d..ad17dab0 100644--- a/src/client/src/helpers/server/cron.ts+++ b/src/client/src/helpers/server/cron.ts@@ -34,91 +34,89 @@ export default class Cron {}updateCrontab(job: Job): void {- try {- this.validateCronSchedule(job.cronSchedule);- const currentCrontab = this.getCronJobs();- const lines = currentCrontab.split("\n");-- const startIdx = lines.indexOf(this.START_MARKER);- const endIdx = lines.indexOf(this.END_MARKER);-- // Extract existing managed section- let managedSection: string[] = [];- if (startIdx !== -1 && endIdx !== -1 && startIdx < endIdx) {- managedSection = lines.slice(startIdx + 1, endIdx);- }-- // Remove any existing entry with the same CRON_ID- managedSection = managedSection.filter(- (line) => !line.includes(`CRON_ID=${job.cronId}`)- );-- const envVars = Object.entries(job.cronEnvVars)- .map(([key, value]) => `${key}=${value}`)- .join(" ");-- this.createLogDirectoryIfNotExists(job.cronLogPath);-- // Add the new cron job entry- const newEntry = `${job.cronSchedule} CRON_ID=${job.cronId} ${envVars} $(which node) ${job.cronScriptPath} >> ${job.cronLogPath} 2>&1`;- managedSection.push(newEntry);-- // Construct the new crontab content- let newCrontab: string;- if (startIdx === -1 || endIdx === -1 || startIdx > endIdx) {- // If section does not exist, create it- newCrontab = [- currentCrontab.trim(),- this.START_MARKER,- newEntry,- this.END_MARKER,- ]- .filter(Boolean)- .join("\n");- } else {- // Replace the existing managed section- newCrontab = [- ...lines.slice(0, startIdx + 1),- ...managedSection,- ...lines.slice(endIdx),- ].join("\n");- }-- // Apply the new crontab safely using stdin- execSync("crontab -", { input: newCrontab, encoding: "utf-8" });- } catch (error) {- throw error;- }- }+ this.validateCronSchedule(job.cronSchedule);+ const currentCrontab = this.getCronJobs();+ const lines = currentCrontab.split("\n");- deleteCronJob(cronId: string): void {- try {- const currentCrontab = this.getCronJobs();- const lines = currentCrontab.split("\n");-- const startIdx = lines.indexOf(this.START_MARKER);- const endIdx = lines.indexOf(this.END_MARKER);+ const startIdx = lines.indexOf(this.START_MARKER);+ const endIdx = lines.indexOf(this.END_MARKER);- if (startIdx === -1 || endIdx === -1 || startIdx > endIdx) {- consoleLog("Cron job section not found in crontab");- return;- }-- const managedSection = lines.slice(startIdx + 1, endIdx);- const updatedSection = managedSection.filter(- (line) => !line.includes(`CRON_ID=${cronId}`)- );+ // Extract existing managed section+ let managedSection: string[] = [];+ if (startIdx !== -1 && endIdx !== -1 && startIdx < endIdx) {+ managedSection = lines.slice(startIdx + 1, endIdx);+ }- const newCrontab = [+ // Remove any existing entry with the same CRON_ID+ managedSection = managedSection.filter(+ (line) => !line.includes(`CRON_ID=${job.cronId}`)+ );++ const envVars = Object.entries(job.cronEnvVars)+ .map(([key, value]) => `${key}=${value}`)+ .join(" ");++ this.createLogDirectoryIfNotExists(job.cronLogPath);++ // Add the new cron job entry+ const newEntry = `${job.cronSchedule} CRON_ID=${job.cronId} ${envVars} $(which node) ${job.cronScriptPath} >> ${job.cronLogPath} 2>&1`;+ managedSection.push(newEntry);++ // Construct the new crontab content+ let newCrontab: string;+ if (startIdx === -1 || endIdx === -1 || startIdx > endIdx) {+ // If section does not exist, create it+ newCrontab = [+ currentCrontab.trim(),+ this.START_MARKER,+ newEntry,+ this.END_MARKER,+ ]+ .filter(Boolean)+ .join("\n");+ } else {+ // Replace the existing managed section+ newCrontab = [...lines.slice(0, startIdx + 1),- ...updatedSection,+ ...managedSection,...lines.slice(endIdx),].join("\n");+ }- // Apply the new crontab safely using stdin- execSync("crontab -", { input: newCrontab, encoding: "utf-8" });- } catch (error) {- throw error;+ // Apply the new crontab safely using stdin+ execSync("crontab -", {+ input: newCrontab.trimEnd() + "\n",+ encoding: "utf-8",+ });+ }++ deleteCronJob(cronId: string): void {+ const currentCrontab = this.getCronJobs();+ const lines = currentCrontab.split("\n");++ const startIdx = lines.indexOf(this.START_MARKER);+ const endIdx = lines.indexOf(this.END_MARKER);++ if (startIdx === -1 || endIdx === -1 || startIdx > endIdx) {+ consoleLog("Cron job section not found in crontab");+ return;}++ const managedSection = lines.slice(startIdx + 1, endIdx);+ const updatedSection = managedSection.filter(+ (line) => !line.includes(`CRON_ID=${cronId}`)+ );++ const newCrontab = [+ ...lines.slice(0, startIdx + 1),+ ...updatedSection,+ ...lines.slice(endIdx),+ ].join("\n");++ // Apply the new crontab safely using stdin+ execSync("crontab -", {+ input: newCrontab.trimEnd() + "\n",+ encoding: "utf-8",+ });}}