Skip to content

A personal agent with a browser, terminal, files, and work that keeps going built with CopilotKit and AG-UI.

TypeScript

fix: never call the provider for a task cancelled during model setup (#101)

nvtoan0201-swe5b583f3dc504
diff --git a/apps/server/src/engine/model.ts b/apps/server/src/engine/model.ts
index df3b3cb..2813def 100644
--- a/apps/server/src/engine/model.ts
+++ b/apps/server/src/engine/model.ts
@@ -320,6 +320,9 @@ export async function executeModelTask(
"identity",
);
const memories = await service.db.list<{ text: string; source: string }>(owner, "memories");
+ // The abort listener below cannot fire for an already-aborted signal. A task
+ // paused or cancelled during these reads must not start a model run.
+ ctx.signal.throwIfAborted();
const agent = tanstackAgent({
model: config.model,
maxSteps: 16,
diff --git a/tests/model-worker.test.ts b/tests/model-worker.test.ts
index dd5419f..97df7e1 100644
--- a/tests/model-worker.test.ts
+++ b/tests/model-worker.test.ts
@@ -377,6 +377,49 @@ test("browser reads keep observation identity distinct while reusing one session
assert.equal(new Set(webEvidence.map((item) => item.id)).size, 2);
});
+test("a task cancelled while the model run is being prepared never calls the provider", async (t) => {
+ const directory = await mkdtemp(join(tmpdir(), "openmuse-model-cancel-"));
+ const db = await createStore();
+ const { requests } = await modelFixture(t, () => undefined);
+ const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
+ const get = db.get.bind(db);
+ db.get = async (owner, kind, id) => {
+ if (kind === "agent-settings" && id === "identity") await delay(100);
+ return get(owner, kind, id);
+ };
+ const server = await createApp(db, {
+ mode: "sample",
+ port: 8787,
+ host: "127.0.0.1",
+ publicUrl: "http://localhost:8787",
+ dataDir: directory,
+ agentBackend: "model",
+ intelligenceApiKey: "test-project-key-never-sent",
+ model: "openai/fixture",
+ googleRedirectUri: "http://localhost:8787/api/google/callback",
+ allowedOrigins: [],
+ });
+ try {
+ const task = await server.agent.createTask("owner", { prompt: "Plan my week in detail" });
+ const tick = server.agent.worker.tick();
+ for (let attempt = 0; attempt < 100; attempt++) {
+ if ((await server.agent.getTask("owner", task.id)).status === "running") break;
+ await delay(5);
+ }
+ assert.equal((await server.agent.getTask("owner", task.id)).status, "running");
+ await server.agent.control("owner", task.id, "pause");
+ await tick;
+
+ const saved = await server.agent.getTask("owner", task.id);
+ assert.equal(saved.status, "paused");
+ assert.equal(requests.length, 0);
+ } finally {
+ await server.agent.stop();
+ await db.close();
+ await rm(directory, { recursive: true, force: true });
+ }
+});
+
test("aborting delegated read_web stops before page read and requeues the task", async (t) => {
const directory = await mkdtemp(join(tmpdir(), "openmuse-model-browser-abort-"));
const db = await createStore();