A personal agent with a browser, terminal, files, and work that keeps going built with CopilotKit and AG-UI.
TypeScript
fix: open the task already handling an email when its idea is accepted (#135)
Lucky Reddy61554520da64
diff --git a/apps/server/src/engine/service.ts b/apps/server/src/engine/service.tsindex 32174eb..003fea9 100644--- a/apps/server/src/engine/service.ts+++ b/apps/server/src/engine/service.ts@@ -619,6 +619,28 @@ export class AgentService {{ status: "dismissed" },);if (idea.status === "new") {+ // A task already working on (or done with) the same email is opened instead of copied.+ const { kind, input } = idea;+ const handling =+ typeof input.messageId === "string"+ ? (await this.db.list<AgentTask>(owner, "tasks")).find(+ (task) =>+ task.kind === kind &&+ task.input.messageId === input.messageId &&+ task.status !== "failed" &&+ task.status !== "cancelled",+ )+ : undefined;+ if (handling)+ return (+ (await this.db.compareAndSwap<Idea>(+ owner,+ "ideas",+ id,+ { status: "new" },+ { status: "accepted", taskId: handling.id },+ )) ?? this.db.get<Idea>(owner, "ideas", id)+ );const claimed = await this.db.compareAndSwap<Idea>(owner,"ideas",@@ -633,6 +655,7 @@ export class AgentService {idea = claimed ?? (await this.db.get<Idea>(owner, "ideas", id));if (idea?.status !== "accepted") return idea;}+ if (idea.taskId && (await this.db.get(owner, "tasks", idea.taskId))) return idea;const goal = await this.createGoal(owner,{ title: idea.title, description: idea.reason },diff --git a/tests/workflows.test.ts b/tests/workflows.test.tsindex 9a3d254..d37214c 100644--- a/tests/workflows.test.ts+++ b/tests/workflows.test.ts@@ -217,3 +217,41 @@ test("dismissal racing acceptance never creates work for a dismissed idea", asynelse assert.ok(saved?.taskId && tasks.some((t) => t.id === saved.taskId));}});+test("accepting an idea opens the task already handling its email instead of starting another", async () => {+ const ideaOwner = "idea-in-progress";+ await server.workspace.ensureSample(ideaOwner, server.actions);+ const idea = (await server.agent.refreshIdeas(ideaOwner)).find(+ (candidate) => candidate.kind === "document" && candidate.status === "new",+ );+ assert.ok(idea);+ const existing = await server.agent.createTask(+ ideaOwner,+ { kind: "document", prompt: "Complete the permission slip", input: idea.input },+ "chat-request",+ );+ const accepted = await server.agent.decideIdea(ideaOwner, idea.id, "accept");+ assert.equal(accepted?.taskId, existing.id);+ const again = await server.agent.decideIdea(ideaOwner, idea.id, "accept");+ assert.equal(again?.taskId, existing.id);+ const tasks = (await db.list<AgentTask>(ideaOwner, "tasks")).filter(+ (task) => task.kind === "document" && task.input.messageId === idea.input.messageId,+ );+ assert.equal(tasks.length, 1);+});+test("a cancelled task does not stop its idea from starting fresh work", async () => {+ const ideaOwner = "idea-after-cancel";+ await server.workspace.ensureSample(ideaOwner, server.actions);+ const idea = (await server.agent.refreshIdeas(ideaOwner)).find(+ (candidate) => candidate.kind === "document" && candidate.status === "new",+ );+ assert.ok(idea);+ const cancelled = await server.agent.createTask(+ ideaOwner,+ { kind: "document", prompt: "Complete the permission slip", input: idea.input },+ "chat-request",+ );+ await server.agent.control(ideaOwner, cancelled.id, "cancel");+ const accepted = await server.agent.decideIdea(ideaOwner, idea.id, "accept");+ assert.ok(accepted?.taskId && accepted.taskId !== cancelled.id);+ assert.equal((await server.agent.getTask(ideaOwner, accepted.taskId)).status, "queued");+});