Skip to content

A personal agent with a browser, terminal, files, and work that keeps going built with CopilotKit and AG-UI.

TypeScript

fix: keep worker run records from sticking or losing their start time (#52)

Kung, Li-Chiehdafe23e98caf
diff --git a/apps/server/src/engine/worker.ts b/apps/server/src/engine/worker.ts
index 195e70c..eeadea4 100644
--- a/apps/server/src/engine/worker.ts
+++ b/apps/server/src/engine/worker.ts
@@ -162,12 +162,7 @@ export class TaskWorker {
detail,
});
};
- await this.db.put(owner, "runs", {
- id: leaseId,
- taskId,
- startedAt: new Date(this.now()).toISOString(),
- status: "running",
- });
+ const startedAt = new Date(this.now()).toISOString();
const heartbeat = setInterval(
() => {
void this.db
@@ -186,6 +181,12 @@ export class TaskWorker {
Math.max(10, Math.floor(leaseMs / 3)),
);
try {
+ await this.db.put(owner, "runs", {
+ id: leaseId,
+ taskId,
+ startedAt,
+ status: "running",
+ });
const result = await this.execute(owner, task, {
signal: controller.signal,
guard,
@@ -196,7 +197,7 @@ export class TaskWorker {
await this.db.put(owner, "runs", {
id: leaseId,
taskId,
- startedAt: task.updatedAt,
+ startedAt,
finishedAt: new Date(this.now()).toISOString(),
status: result.status ?? task.status,
});
diff --git a/tests/engine.test.ts b/tests/engine.test.ts
index dc886ac..947b100 100644
--- a/tests/engine.test.ts
+++ b/tests/engine.test.ts
@@ -168,3 +168,46 @@ test("pending reviews do not starve queued work", async () => {
await db.close();
}
});
+test("run history keeps the time the run started", async () => {
+ const db = await createStore();
+ try {
+ await db.put("owner", "tasks", task());
+ let clock = Date.parse("2026-01-01T00:00:00.000Z");
+ await new TaskWorker(
+ db,
+ async () => {
+ clock += 60000;
+ return { status: "succeeded" };
+ },
+ { now: () => clock },
+ ).tick();
+ const [run] = (await db.scan<{ startedAt: string; finishedAt: string }>("runs")).map(
+ ({ value }) => value,
+ );
+ assert.equal(run?.startedAt, "2026-01-01T00:00:00.000Z");
+ assert.equal(run?.finishedAt, "2026-01-01T00:01:00.000Z");
+ } finally {
+ await db.close();
+ }
+});
+test("a failed run record does not leave the task stuck in the worker", async () => {
+ const db = await createStore();
+ try {
+ await db.put("owner", "tasks", task());
+ const flaky = Object.create(db) as typeof db;
+ flaky.put = (async (owner: string, kind: string, value: { id: string }) => {
+ if (kind === "runs") throw new Error("database unavailable");
+ return db.put(owner, kind, value);
+ }) as typeof db.put;
+ const worker = new TaskWorker(flaky, async () => ({ status: "succeeded" }));
+ await worker.tick().catch(() => {});
+ const stopped = await Promise.race([
+ worker.stop().then(() => true),
+ new Promise((r) => setTimeout(() => r(false), 500)),
+ ]);
+ assert.equal(stopped, true);
+ assert.equal((await db.get<AgentTask>("owner", "tasks", "task1"))?.status, "failed");
+ } finally {
+ await db.close();
+ }
+});