A personal agent with a browser, terminal, files, and work that keeps going built with CopilotKit and AG-UI.
TypeScript
fix: keep browser evidence identity separate from session identity (#29)
Kevin Rajane73957220927
diff --git a/apps/server/src/engine/model.ts b/apps/server/src/engine/model.tsindex dfd3d8f..aafe9b4 100644--- a/apps/server/src/engine/model.ts+++ b/apps/server/src/engine/model.ts@@ -178,7 +178,7 @@ export async function executeModelTask(evidence: [...task.evidence,{- id: page.sessionId,+ id: randomUUID(),kind: "web",title: page.title,url: page.url,diff --git a/tests/model-worker.test.ts b/tests/model-worker.test.tsindex 6194a98..c5766e7 100644--- a/tests/model-worker.test.ts+++ b/tests/model-worker.test.ts@@ -7,6 +7,7 @@ import { createApp } from "../apps/server/src/app.ts";import { createStore } from "../apps/server/src/db.ts";import { createDemoModel, demoModel } from "../apps/server/src/demo/model.ts";import type { ActionProposal } from "../packages/domain/src/index.ts";+import { browserFixture } from "./helpers/browser.ts";import { fixture as computerFixture } from "./helpers/computer.ts";import { modelFixture } from "./helpers/model.ts";@@ -164,3 +165,63 @@ test("the model worker keeps the text a model replies with when it calls no toolawait rm(directory, { recursive: true, force: true });}});++test("browser reads keep observation identity distinct while reusing one session", async (t) => {+ let currentUrl = "https://example.com/one";+ const sessionIds = new Set<string>();+ const browser = await browserFixture(t, (path, body) => {+ if (path === "/sessions") {+ const id = String(body.id);+ currentUrl = String(body.url);+ sessionIds.add(id);+ return {+ data: {+ id,+ title: currentUrl,+ url: currentUrl,+ status: "active",+ updatedAt: new Date().toISOString(),+ },+ };+ }+ if (path.endsWith("/read")) {+ return {+ data: {+ url: currentUrl,+ title: currentUrl.endsWith("/one") ? "Source one" : "Source two",+ text: `Evidence from ${currentUrl}`,+ truncated: false,+ },+ };+ }+ throw new Error(`Unexpected browser path: ${path}`);+ });+ const calls: { name: string; arguments: object }[] = [+ { name: "read_web", arguments: { url: "https://example.com/one" } },+ { name: "read_web", arguments: { url: "https://example.com/two" } },+ { name: "finish_task", arguments: { summary: "Compared both public sources." } },+ ];+ await modelFixture(t, (index) => calls[index]);+ const app = await createApp(browser.db, {+ ...browser.config,+ agentBackend: "model",+ model: "openai/fixture",+ });+ t.after(() => app.agent.stop());++ const task = await app.agent.createTask("owner", {+ prompt: "Read both public sources and compare them.",+ });+ await app.agent.worker.tick();++ const saved = await app.agent.getTask("owner", task.id);+ assert.equal(saved.status, "succeeded", saved.error ?? saved.question);+ const webEvidence = saved.evidence.filter((item) => item.kind === "web");+ assert.equal(webEvidence.length, 2);+ assert.deepEqual(+ webEvidence.map((item) => item.url),+ ["https://example.com/one", "https://example.com/two"],+ );+ assert.equal(sessionIds.size, 1, "both reads should reuse the same browser session");+ assert.equal(new Set(webEvidence.map((item) => item.id)).size, 2);+});