OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.
fix(dashboard): line and area charts leave a gap for missing values
Carl-Gerhard Lindesvärd38977e079b50
diff --git a/apps/start/src/components/charts/area.tsx b/apps/start/src/components/charts/area.tsxindex 27242bbbf..3758e5930 100644--- a/apps/start/src/components/charts/area.tsx+++ b/apps/start/src/components/charts/area.tsx@@ -120,6 +120,10 @@ export function Area({},[dataKey, yScale]);+ const hasValue = useCallback(+ (d: Record<string, unknown>) => typeof d[dataKey] === 'number',+ [dataKey]+ );const hasDashTail = resolveDashTailBounds(dashFromIndex, data.length);// The stroke gradient is only emitted when at least one edge fades, so fall@@ -159,6 +163,7 @@ export function Area({<AreaClosedcurve={curve}data={renderData}+ defined={hasValue}fill={areaFill}x={(d) => xScale(xAccessor(d)) ?? 0}y={getY}@@ -172,6 +177,7 @@ export function Area({<LinePathcurve={curve}data={renderData}+ defined={hasValue}innerRef={pathRef}stroke={hasDashTail ? 'transparent' : strokePaint}strokeLinecap="round"diff --git a/apps/start/src/components/charts/line.tsx b/apps/start/src/components/charts/line.tsxindex 3e63f01eb..3eb346e93 100644--- a/apps/start/src/components/charts/line.tsx+++ b/apps/start/src/components/charts/line.tsx@@ -99,6 +99,10 @@ export function Line({},[dataKey, yScale]);+ const hasValue = useCallback(+ (d: Record<string, unknown>) => typeof d[dataKey] === 'number',+ [dataKey]+ );const hasDashTail = resolveDashTailBounds(dashFromIndex, data.length);const fadeSides = resolveFadeSides(fadeEdges);@@ -125,6 +129,7 @@ export function Line({<LinePathcurve={curve}data={renderData}+ defined={hasValue}innerRef={pathRef}stroke={hasDashTail ? 'transparent' : lineStroke}strokeLinecap="round"