Skip to content

OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.

tests: name what the assertion pins, not the system it came from

Carl-Gerhard Lindesvärd445543e7e4d7
diff --git a/apps/api/e2e/legacy-job-proof.ts b/apps/api/e2e/legacy-job-proof.ts
index 377dc1388..315a57d14 100644
--- a/apps/api/e2e/legacy-job-proof.ts
+++ b/apps/api/e2e/legacy-job-proof.ts
@@ -354,7 +354,7 @@ async function main() {
);
check(
stored !== null && !stored.includes('"meta"'),
- `${legacyCase.queue}: stored bytes carry no envelope (V1 shape)`
+ `${legacyCase.queue}: stored bytes carry no envelope (legacy shape)`
);
}
@@ -452,7 +452,7 @@ async function main() {
run !== undefined &&
JSON.stringify(run.payload) ===
JSON.stringify(legacyCase.expectPayload),
- `${legacyCase.queue}: resolved to '${legacyCase.expectJob}' with V1's payload`
+ `${legacyCase.queue}: resolved to '${legacyCase.expectJob}' with the legacy payload`
);
}
@@ -472,7 +472,7 @@ async function main() {
);
check(
realFlush !== undefined,
- "cron: the REAL flushEvents handler ran to completion off V1's `{type:'flushEvents'}`"
+ "cron: the REAL flushEvents handler ran to completion off the legacy `{type:'flushEvents'}`"
);
const envelopeLine = logLines.find(
diff --git a/apps/api/src/config/env.test.ts b/apps/api/src/config/env.test.ts
index c73393cf2..1267af05a 100644
--- a/apps/api/src/config/env.test.ts
+++ b/apps/api/src/config/env.test.ts
@@ -52,7 +52,7 @@ describe('ENABLED_QUEUES', () => {
).toEqual(['sessions', 'cron']);
});
- it('rejects an unknown token instead of silently idling (V1 ignored it)', () => {
+ it('rejects an unknown token instead of silently idling', () => {
expect(() =>
loadConfig({ ...base, ENABLED_QUEUES: 'sessions,nope' })
).toThrow(/unknown queue "nope"/);
@@ -66,7 +66,7 @@ describe('ENABLED_QUEUES', () => {
});
describe('<QUEUE>_CONCURRENCY', () => {
- it('keeps V1 key derivation — cohortCompute reads COHORTCOMPUTE_CONCURRENCY', () => {
+ it('keeps the env key derivation — cohortCompute reads COHORTCOMPUTE_CONCURRENCY', () => {
expect(concurrencyEnvKey('cohortCompute')).toBe(
'COHORTCOMPUTE_CONCURRENCY'
);
@@ -78,7 +78,7 @@ describe('<QUEUE>_CONCURRENCY', () => {
expect(concurrencyOverride(loadConfig(base), 'sessions')).toBeUndefined();
});
- it('ignores a non-numeric or non-positive value, as V1 did', () => {
+ it('ignores a non-numeric or non-positive value', () => {
expect(
concurrencyOverride(
loadConfig({ ...base, SESSIONS_CONCURRENCY: 'lots' }),
@@ -114,7 +114,7 @@ describe('the boot flags main.ts branches on', () => {
).toBe(false);
});
- it('QUEUE_NAMESPACE and QUEUE_CLUSTER default to off, so queue keys are V1s', () => {
+ it('QUEUE_NAMESPACE and QUEUE_CLUSTER default to off, so queue keys stay unprefixed', () => {
const config = loadConfig(base);
expect(config.QUEUE_CLUSTER).toBe(false);
expect(config.QUEUE_NAMESPACE).toBeUndefined();
diff --git a/apps/api/src/config/env.ts b/apps/api/src/config/env.ts
index 522448f31..4e616ed70 100644
--- a/apps/api/src/config/env.ts
+++ b/apps/api/src/config/env.ts
@@ -972,9 +972,9 @@ export interface Config {
* it is handed.
*/
INGEST_DUPLICATE_MARKER_TTL_MS: number;
- /** The CORS delegator's origin allowlist, in V1's own order. */
+ /** The CORS delegator's origin allowlist, order-sensitive. */
dashboardOrigins: string[];
- /** V1's `ENABLE_VERBOSE_LOGGING`, already split. */
+ /** `ENABLE_VERBOSE_LOGGING`, already split. */
verboseClientIds: string[];
/**
* `Bun.serve`'s listen options. No `hostname` unless API_HOST says one:
diff --git a/packages/core/src/http/auth.test.ts b/packages/core/src/http/auth.test.ts
index 00621a6b7..cc0f59b7a 100644
--- a/packages/core/src/http/auth.test.ts
+++ b/packages/core/src/http/auth.test.ts
@@ -107,7 +107,7 @@ test('clientAuth passes the allow list through to the authenticator', async () =
// routers (/export, /insights, /import, /manage) answer with a JSON envelope
// carrying the validator's own message, and the ingest routers (/track,
// /event, /profile) answer with that message as plain text.
-test('clientAuth answers 401 with V1s allow-list body when nothing authenticates', async () => {
+test('clientAuth answers 401 with the allow-list body when nothing authenticates', async () => {
result = REFUSAL;
const response = await buildApp().handle(
@@ -121,7 +121,7 @@ test('clientAuth answers 401 with V1s allow-list body when nothing authenticates
});
});
-test('clientAuth answers 401 with V1s ingest body, which is plain text', async () => {
+test('clientAuth answers 401 with the ingest body, which is plain text', async () => {
result = { ok: false, ingest: true, message: 'Missing client id' };
const response = await buildApp().handle(
diff --git a/packages/core/src/http/context.test.ts b/packages/core/src/http/context.test.ts
index cc80da477..c94c5f7cd 100644
--- a/packages/core/src/http/context.test.ts
+++ b/packages/core/src/http/context.test.ts
@@ -166,7 +166,7 @@ describe('the derived HttpCtx', () => {
expect(resolveSession).toHaveBeenCalledTimes(1);
});
- test('writes Set-Cookie through Elysia with V1 attributes', async () => {
+ test('writes Set-Cookie through Elysia with the expected attributes', async () => {
const { app } = build();
const response = await app.handle(
diff --git a/packages/core/src/http/hooks.test.ts b/packages/core/src/http/hooks.test.ts
index 7d1894caa..da52307bd 100644
--- a/packages/core/src/http/hooks.test.ts
+++ b/packages/core/src/http/hooks.test.ts
@@ -46,7 +46,7 @@ describe('clientIpHook', () => {
.use(clientIpHook(testCoreConfig().ipHeaders))
.get('/', ({ clientIp, clientIpHeader }) => ({ clientIp, clientIpHeader }));
- test('prefers the client-forwarded header, as V1 does', async () => {
+ test('prefers the client-forwarded header', async () => {
const response = await app.handle(
new Request('http://localhost/', {
headers: {
diff --git a/packages/core/src/http/http.metrics.test.ts b/packages/core/src/http/http.metrics.test.ts
index 5086cefad..e56f45a76 100644
--- a/packages/core/src/http/http.metrics.test.ts
+++ b/packages/core/src/http/http.metrics.test.ts
@@ -23,7 +23,7 @@ beforeEach(() => {
registry.resetMetrics();
});
-test('both series exist on the ONE registry, with V1s names and labels', () => {
+test('both series exist on the ONE registry, with the names dashboards query', () => {
const registered = registry.getMetricsAsArray().map((metric) => metric.name);
expect(registered).toContain(HISTOGRAM);
expect(registered).toContain(SUMMARY);
diff --git a/packages/core/src/http/rate-limit.test.ts b/packages/core/src/http/rate-limit.test.ts
index 9ace86843..ce4535097 100644
--- a/packages/core/src/http/rate-limit.test.ts
+++ b/packages/core/src/http/rate-limit.test.ts
@@ -7,7 +7,7 @@ import { HTTP_RATE_LIMITS, limitFor } from './rate-limit';
// The published rate-limits page's numbers, for the first three entries;
// `/mcp` is pinned here only.
-const V1_LIMITS = {
+const PUBLISHED_LIMITS = {
'/manage/clients': { max: 20, windowMs: 10_000 },
'/export/events': { max: 100, windowMs: 10_000 },
'/insights/acme-web/overview': { max: 100, windowMs: 10_000 },
@@ -15,8 +15,8 @@ const V1_LIMITS = {
} as const;
describe('HTTP rate limits', () => {
- test("each documented surface keeps V1's numbers", () => {
- for (const [path, expected] of Object.entries(V1_LIMITS)) {
+ test('each documented surface keeps its published numbers', () => {
+ for (const [path, expected] of Object.entries(PUBLISHED_LIMITS)) {
const limit = limitFor(path);
expect([path, limit?.max, limit?.windowMs]).toEqual([
path,
diff --git a/packages/core/src/jobs.registry.test.ts b/packages/core/src/jobs.registry.test.ts
index 7dafe1e5b..1935773f3 100644
--- a/packages/core/src/jobs.registry.test.ts
+++ b/packages/core/src/jobs.registry.test.ts
@@ -29,7 +29,7 @@ const GOLDEN_SCHEDULER_IDS = [
// Retry and retention values kept as-is, defects included — five queues
// that never retry, four with unbounded failed sets.
-const V1_DEFAULTS = {
+const PINNED_DEFAULTS = {
sessions: { removeOnComplete: true },
cron: { removeOnComplete: 10 },
notification: { removeOnComplete: 10 },
@@ -44,7 +44,7 @@ const V1_DEFAULTS = {
},
} as const;
-const V1_CONCURRENCY = {
+const PINNED_CONCURRENCY = {
sessions: 1,
cron: 1,
notification: 1,
@@ -70,14 +70,14 @@ test('the registry declares the seven queues, keyed by their Redis names', () =>
}
});
-test('every queue carries V1 retry and retention values unchanged', () => {
- for (const [key, defaults] of Object.entries(V1_DEFAULTS)) {
+test('every queue keeps its pinned retry and retention values', () => {
+ for (const [key, defaults] of Object.entries(PINNED_DEFAULTS)) {
expect(queues[key as keyof typeof queues].defaults).toEqual(defaults);
}
});
-test('every queue carries its V1 default concurrency', () => {
- for (const [key, concurrency] of Object.entries(V1_CONCURRENCY)) {
+test('every queue keeps its pinned default concurrency', () => {
+ for (const [key, concurrency] of Object.entries(PINNED_CONCURRENCY)) {
expect(queues[key as keyof typeof queues].worker?.concurrency).toBe(
concurrency
);
diff --git a/packages/core/src/jobs/jobs.metrics.test.ts b/packages/core/src/jobs/jobs.metrics.test.ts
index 7806c13fe..c708dfcb6 100644
--- a/packages/core/src/jobs/jobs.metrics.test.ts
+++ b/packages/core/src/jobs/jobs.metrics.test.ts
@@ -17,7 +17,7 @@ function fakeQueue(name: string, value: number): CountableQueue {
};
}
-test('five gauges per queue, named from the Redis key exactly as V1 named them', () => {
+test('five gauges per queue, named from the Redis key so dashboards keep working', () => {
const register = new client.Registry();
registerQueueMetrics(
Object.values(queues).map((definition) => fakeQueue(definition.name, 0)),
diff --git a/packages/core/src/jobs/jobs.test.ts b/packages/core/src/jobs/jobs.test.ts
index 947727456..75a90311b 100644
--- a/packages/core/src/jobs/jobs.test.ts
+++ b/packages/core/src/jobs/jobs.test.ts
@@ -76,7 +76,7 @@ test('queue defaults carry retention as {age, count}, which cohortCompute needs'
});
});
-test('all three V1 idempotency conventions survive the option mapping', () => {
+test('all three legacy idempotency conventions survive the option mapping', () => {
// sessions and insights key on jobId; cohort keys on deduplication and must
// NOT be normalised onto jobId (cohort.service.ts records the deadlock).
expect(toJobsOptions(undefined, { jobId: 'sessionEnd:v2:ses_1' })).toEqual({
diff --git a/packages/core/src/logger.test.ts b/packages/core/src/logger.test.ts
index e517b6810..bdab28a2c 100644
--- a/packages/core/src/logger.test.ts
+++ b/packages/core/src/logger.test.ts
@@ -33,7 +33,7 @@ describe('Logger structural interface', () => {
});
describe('requestId constants', () => {
- test('the log field is requestId, not V1s reqId', () => {
+ test('the log field is requestId, not reqId', () => {
expect(REQUEST_ID_LOG_FIELD).toBe('requestId');
});
diff --git a/packages/core/src/modules/auth/auth.service.ts b/packages/core/src/modules/auth/auth.service.ts
index 9dffacfe5..5e9f5c242 100644
--- a/packages/core/src/modules/auth/auth.service.ts
+++ b/packages/core/src/modules/auth/auth.service.ts
@@ -799,8 +799,8 @@ export async function requestPasswordReset(
email: input.email,
provider: 'email',
});
- // Deliberately not found-vs-found: V1 always returns `true` here so the
- // endpoint cannot be used to enumerate registered emails.
+ // Deliberately not found-vs-found: always `true`, so the endpoint cannot be
+ // used to enumerate registered emails.
if (!user?.account.id) {
return true;
}
diff --git a/packages/core/src/modules/chart/src/table-filter-where.ts b/packages/core/src/modules/chart/src/table-filter-where.ts
index fb939c919..983f77a1b 100644
--- a/packages/core/src/modules/chart/src/table-filter-where.ts
+++ b/packages/core/src/modules/chart/src/table-filter-where.ts
@@ -84,8 +84,8 @@ const NON_INTEGER_LITERAL_TYPE = 'Float64';
const INTEGER_LITERAL_TEXT = /^-?\d+$/;
/**
- * The integer ClickHouse would parse out of the text V1 emitted, or null when
- * that text is not an integer literal — a fraction, or a magnitude large
+ * The integer ClickHouse would parse out of the number's text form, or null
+ * when that text is not an integer literal — a fraction, or a magnitude large
* enough that `String` switches to exponent notation.
*/
function integerLiteralDigits(value: number): bigint | null {
@@ -94,9 +94,9 @@ function integerLiteralDigits(value: number): bigint | null {
}
/**
- * V1 inlined a numeric filter value and let ClickHouse infer the literal's
- * type; a bound param has to declare one, so declare the one V1's literal
- * had. Declaring `Float64` for every number would bind a *different constant*
+ * An inlined numeric filter value lets ClickHouse infer the literal's type;
+ * a bound param has to declare one, so declare the type that literal would
+ * have had. Declaring `Float64` for every number would bind a *different constant*
* — visible wherever the comparand's type takes part in type resolution, and
* in the `NO_COMMON_TYPE` message when a numeric filter lands on a String
* property (the proof's two error cases).
diff --git a/packages/core/src/modules/cohort/cohort.jobs.test.ts b/packages/core/src/modules/cohort/cohort.jobs.test.ts
index 18b4f5bba..7f53d2840 100644
--- a/packages/core/src/modules/cohort/cohort.jobs.test.ts
+++ b/packages/core/src/modules/cohort/cohort.jobs.test.ts
@@ -134,7 +134,7 @@ test('cohortRefresh fans out one enqueueCompute per non-static cohort', async ()
// Byte-identity with the id/cadence schedulers.test.ts's golden snapshot
// pins. The cadence now lives on the job itself, so this reads it straight
// off the registry.
-test('the cohort cron fragment carries V1 id and cadence unchanged', () => {
+test('the cohort cron fragment keeps its scheduler id and cadence', () => {
expect(queues.cron.jobs.cohortRefresh.cron).toEqual({
pattern: '*/30 * * * *',
});
diff --git a/packages/core/src/modules/event/src/sql.test.ts b/packages/core/src/modules/event/src/sql.test.ts
index 4cd6cfe1d..1480add99 100644
--- a/packages/core/src/modules/event/src/sql.test.ts
+++ b/packages/core/src/modules/event/src/sql.test.ts
@@ -106,7 +106,7 @@ describe('eventListQuery', () => {
expect(Math.abs(anchor.getTime() - before)).toBeLessThan(5000);
});
- test('every scope condition binds in V1 order and none interpolates', () => {
+ test('every scope condition binds in a stable order and none interpolates', () => {
const { query, query_params } = eventListQuery({
...minimal,
profileId: HOSTILE,
@@ -325,7 +325,7 @@ describe('queryEventsQuery', () => {
expect(query.indexOf('ORDER BY')).toBeLessThan(query.indexOf('LIMIT'));
});
- test('equality columns follow V1 order regardless of input order; keys bind too', () => {
+ test('equality columns follow a stable order regardless of input order; keys bind too', () => {
const { query, query_params } = queryEventsQuery({
projectId: PROJECT_ID,
sessionId: 'sess-1',
diff --git a/packages/core/src/modules/export/export.routes.ts b/packages/core/src/modules/export/export.routes.ts
index 8c317bcf3..0d05a3a0b 100644
--- a/packages/core/src/modules/export/export.routes.ts
+++ b/packages/core/src/modules/export/export.routes.ts
@@ -171,8 +171,7 @@ const zExportCharts = zReport
export const exportRoutes = defineRoutes((app) =>
app
- // V1's `preValidation` coercion hook, LOCAL to this surface (see
- // http/query.ts).
+ // Query-string coercion, LOCAL to this surface (see http/query.ts).
.onTransform(parseQueryStringTransform)
.get(
'/export/events',
diff --git a/packages/core/src/modules/gsc/gsc.jobs.test.ts b/packages/core/src/modules/gsc/gsc.jobs.test.ts
index bfe4bc101..a633cbf41 100644
--- a/packages/core/src/modules/gsc/gsc.jobs.test.ts
+++ b/packages/core/src/modules/gsc/gsc.jobs.test.ts
@@ -219,6 +219,6 @@ test('gscSync fans out one gscProjectSync enqueue per connected project', async
// Byte-identity with the id/cadence schedulers.test.ts's golden snapshot
// pins. The cadence now lives on the job itself, so this reads it straight
// off the registry.
-test('the gsc cron fragment carries V1 id and cadence unchanged', () => {
+test('the gsc cron fragment keeps its scheduler id and cadence', () => {
expect(queues.cron.jobs.gscSync.cron).toEqual({ pattern: '0 3 * * *' });
});
diff --git a/packages/core/src/modules/health/src/readiness.test.ts b/packages/core/src/modules/health/src/readiness.test.ts
index 1cb02f89c..c2cbeaa04 100644
--- a/packages/core/src/modules/health/src/readiness.test.ts
+++ b/packages/core/src/modules/health/src/readiness.test.ts
@@ -44,7 +44,7 @@ test('a stale consumer heartbeat is 503 with the numbers that explain it', () =>
});
});
-test('exactly at the threshold is still ready — V1 compared with >', () => {
+test('exactly at the threshold is still ready — the comparison is >', () => {
expect(
evaluateReadiness({
shuttingDown: false,
diff --git a/packages/core/src/modules/insight/insight.jobs.test.ts b/packages/core/src/modules/insight/insight.jobs.test.ts
index a63e45cf2..173f831a9 100644
--- a/packages/core/src/modules/insight/insight.jobs.test.ts
+++ b/packages/core/src/modules/insight/insight.jobs.test.ts
@@ -239,7 +239,7 @@ test('weeklyDigest delegates to sendWeeklyDigests', async () => {
// Byte-identity with the ids/cadences schedulers.test.ts's golden snapshot
// pins. The cadences now live on the jobs themselves, so this reads them
// straight off the registry.
-test('the insight cron fragment carries V1 ids and cadences unchanged', () => {
+test('the insight cron fragment keeps its scheduler ids and cadences', () => {
expect(queues.cron.jobs.insightsDaily.cron).toEqual({
pattern: '0 2 * * *',
});
diff --git a/packages/core/src/modules/onboarding/onboarding.jobs.test.ts b/packages/core/src/modules/onboarding/onboarding.jobs.test.ts
index 4a0aa31a4..30107a6ba 100644
--- a/packages/core/src/modules/onboarding/onboarding.jobs.test.ts
+++ b/packages/core/src/modules/onboarding/onboarding.jobs.test.ts
@@ -125,7 +125,7 @@ test('onboarding does not log when the cron is a self-hosted no-op', async () =>
// The cadence lives on the job itself, so this reads it straight off the
// registry.
-test('the onboarding cron fragment carries V1 id and cadence unchanged', () => {
+test('the onboarding cron fragment keeps its scheduler id and cadence', () => {
expect(queues.cron.jobs.onboarding.cron).toEqual({
pattern: '0 * * * *',
});
diff --git a/packages/core/src/modules/organization/organization.jobs.test.ts b/packages/core/src/modules/organization/organization.jobs.test.ts
index 91506ce0c..3bf71d2f2 100644
--- a/packages/core/src/modules/organization/organization.jobs.test.ts
+++ b/packages/core/src/modules/organization/organization.jobs.test.ts
@@ -112,7 +112,7 @@ test('delete delegates to runDeleteCron', async () => {
// Byte-identity with schedulers.test.ts's golden snapshot pins. The cadences
// now live on the jobs themselves, so this reads them straight off the
// registry.
-test('the organization cron fragment carries V1 id and cadence unchanged', () => {
+test('the organization cron fragment keeps its scheduler id and cadence', () => {
expect(queues.cron.jobs.delete.cron).toEqual({ pattern: '0 * * * *' });
expect(queues.cron.jobs.windDown.cron).toEqual({ pattern: '0 * * * *' });
});
diff --git a/packages/core/src/modules/profile/profile.routes.test.ts b/packages/core/src/modules/profile/profile.routes.test.ts
index ba83f0966..ec002e4b4 100644
--- a/packages/core/src/modules/profile/profile.routes.test.ts
+++ b/packages/core/src/modules/profile/profile.routes.test.ts
@@ -129,7 +129,7 @@ test('POST /profile/increment passes value through; /decrement negates it', asyn
]);
});
-test('adjust results map to V1 status codes and bodies', async () => {
+test('adjust results map to the documented status codes and bodies', async () => {
const body = { profileId: 'prof-1', property: 'visits', value: 1 };
adjustResult = { status: 'not-found' };
diff --git a/packages/core/src/modules/profile/src/sql.test.ts b/packages/core/src/modules/profile/src/sql.test.ts
index 1fa20d3f6..64b35421b 100644
--- a/packages/core/src/modules/profile/src/sql.test.ts
+++ b/packages/core/src/modules/profile/src/sql.test.ts
@@ -162,7 +162,7 @@ describe('profileListQuery', () => {
});
});
- test('search + isExternal + filters + offset all splice in V1 order', () => {
+ test('search + isExternal + filters + offset all splice in a stable order', () => {
const { query, query_params } = profileListQuery({
projectId: PROJECT_ID,
take: 50,
@@ -291,7 +291,7 @@ describe('findProfilesQuery', () => {
});
describe('project-wide vocab', () => {
- test("property keys keeps V1's is_external guard and no FINAL", () => {
+ test('property keys keeps the is_external guard and no FINAL', () => {
const { query, query_params } =
profilePropertyKeysQuery(PROJECT_ID).toStatement();
diff --git a/packages/core/src/modules/session/src/session-end.test.ts b/packages/core/src/modules/session/src/session-end.test.ts
index 39ad0dbb0..e7507c1c9 100644
--- a/packages/core/src/modules/session/src/session-end.test.ts
+++ b/packages/core/src/modules/session/src/session-end.test.ts
@@ -145,7 +145,7 @@ describe('createSessionEnd', () => {
});
describe('enqueue shape', () => {
- test('job id and options match V1 (sessionEnd:v2:<id>, 3 exponential retries)', () => {
+ test('job id and options are pinned (sessionEnd:v2:<id>, 3 exponential retries)', () => {
expect(getSessionEndJobId('sess-1')).toBe('sessionEnd:v2:sess-1');
expect(sessionEndEnqueueOptions('sess-1')).toEqual({
jobId: 'sessionEnd:v2:sess-1',
diff --git a/packages/core/src/modules/session/src/sql.test.ts b/packages/core/src/modules/session/src/sql.test.ts
index 9feedbec4..88bad76d6 100644
--- a/packages/core/src/modules/session/src/sql.test.ts
+++ b/packages/core/src/modules/session/src/sql.test.ts
@@ -111,7 +111,7 @@ describe('sessionListQuery', () => {
});
});
- test('hasSessionListLookback mirrors V1: off only for a date-bounded first page', () => {
+ test('hasSessionListLookback is off only for a date-bounded first page', () => {
const range = { startDate: new Date(), endDate: new Date() };
expect(hasSessionListLookback({})).toBe(true);
expect(hasSessionListLookback({ cursor: new Date(), ...range })).toBe(true);
@@ -159,7 +159,7 @@ describe('replay and byId', () => {
});
});
- test('sessionByIdQuery prewheres the id and keeps sign under FINAL; sessionHasReplayQuery keeps V1 text', () => {
+ test('sessionByIdQuery prewheres the id and keeps sign under FINAL; sessionHasReplayQuery text is pinned', () => {
const byId = sessionByIdQuery({
sessionId: 'sess-1',
projectId: PROJECT_ID,
@@ -205,7 +205,7 @@ describe('sessionDistinctValuesQuery', () => {
});
describe('querySessionsQuery', () => {
- test('equality filters follow V1 clause order, dates bind as Strings', () => {
+ test('equality filters follow a stable clause order, dates bind as Strings', () => {
const { query, query_params } = querySessionsQuery({
projectId: PROJECT_ID,
startDate: '2026-07-01 00:00:00',
diff --git a/packages/core/src/modules/tools/tools.routes.test.ts b/packages/core/src/modules/tools/tools.routes.test.ts
index 5d9f4e174..7744d80bb 100644
--- a/packages/core/src/modules/tools/tools.routes.test.ts
+++ b/packages/core/src/modules/tools/tools.routes.test.ts
@@ -12,7 +12,7 @@ const SOURCE = readFileSync(
'utf8'
);
-describe("tools routes keep V1's public paths", () => {
+describe('tools routes keep their public paths', () => {
test('both routes are registered under /tools', () => {
expect(SOURCE).toContain("'/tools/site-checker'");
expect(SOURCE).toContain("'/tools/ip-lookup'");
diff --git a/packages/core/src/rpc/base.test.ts b/packages/core/src/rpc/base.test.ts
index 8da7936c2..067cd8ab5 100644
--- a/packages/core/src/rpc/base.test.ts
+++ b/packages/core/src/rpc/base.test.ts
@@ -35,7 +35,7 @@ function build(options: Partial<Parameters<typeof makeTrpcContext>[2]> = {}) {
};
}
-test('setCookie writes through resHeaders with V1 option precedence', async () => {
+test('setCookie writes through resHeaders with the documented option precedence', async () => {
const { trpcCtx, resHeaders } = build();
// Only maxAge and signed are caller-controlled; COOKIE_OPTIONS is spread
diff --git a/packages/core/src/rpc/handler.test.ts b/packages/core/src/rpc/handler.test.ts
index c393f57c4..f98528614 100644
--- a/packages/core/src/rpc/handler.test.ts
+++ b/packages/core/src/rpc/handler.test.ts
@@ -89,7 +89,7 @@ test('TOO_MANY_REQUESTS logs at warn as "trpc rate limited"', () => {
expect(logger.lines[0]?.message).toBe('trpc rate limited');
});
-test('everything else logs at error as "trpc error", with the V1 fields', () => {
+test('everything else logs at error as "trpc error", with the expected fields', () => {
const logger = capturingLogger();
const failure = report();
diff --git a/packages/core/src/rpc/rate-limit.test.ts b/packages/core/src/rpc/rate-limit.test.ts
index 792dcb743..556140613 100644
--- a/packages/core/src/rpc/rate-limit.test.ts
+++ b/packages/core/src/rpc/rate-limit.test.ts
@@ -31,7 +31,7 @@ describe('rate limit escalation', () => {
});
});
-const V1_AUTH_LIMITS: Record<string, { max: number; windowMs: number }> = {
+const AUTH_LIMITS: Record<string, { max: number; windowMs: number }> = {
signUpEmail: { max: 5, windowMs: 60_000 },
signInEmail: { max: 3, windowMs: 30_000 },
signInTotp: { max: 5, windowMs: 60_000 },
@@ -43,14 +43,14 @@ const V1_AUTH_LIMITS: Record<string, { max: number; windowMs: number }> = {
signInShare: { max: 3, windowMs: 30_000 },
};
-describe("the auth router mounts V1's limits", () => {
+describe('the auth router mounts the documented limits', () => {
const source = readFileSync(
new URL('../modules/auth/auth.rpc.ts', import.meta.url),
'utf8'
);
- test("every throttled procedure still declares V1's numbers", () => {
- for (const [name, limit] of Object.entries(V1_AUTH_LIMITS)) {
+ test('every throttled procedure still declares those numbers', () => {
+ for (const [name, limit] of Object.entries(AUTH_LIMITS)) {
const declaration = new RegExp(
`${name}: (?:public|protected)Procedure\\s*\\n\\s*\\.use\\(\\s*rateLimit\\(\\{ max: (\\d+), windowMs: ([\\d_]+) \\}\\)\\s*\\)`
).exec(source);