OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.
fix(dashboard): durations no longer show "60s" at a minute boundary (#616)
ayushjhanwar-png59615f061e6b
diff --git a/apps/start/src/hooks/use-numer-formatter.test.ts b/apps/start/src/hooks/use-numer-formatter.test.tsnew file mode 100644index 000000000..88676b919--- /dev/null+++ b/apps/start/src/hooks/use-numer-formatter.test.ts@@ -0,0 +1,15 @@+import { describe, expect, it } from 'vitest';+import { fancyMinutes } from './use-numer-formatter';++describe('fancyMinutes', () => {+ it('carries rounded-up seconds into the minute', () => {+ expect(fancyMinutes(239.854)).toBe('4m 0s');+ expect(fancyMinutes(59.6)).toBe('1m 0s');+ });++ it('keeps whole-second values as they were', () => {+ expect(fancyMinutes(4)).toBe('4s');+ expect(fancyMinutes(76)).toBe('1m 16s');+ expect(fancyMinutes(3 * 3600 + 120)).toBe('3h 2m');+ });+});diff --git a/apps/start/src/hooks/use-numer-formatter.ts b/apps/start/src/hooks/use-numer-formatter.tsindex 19f3d4eeb..cff1a9f9c 100644--- a/apps/start/src/hooks/use-numer-formatter.ts+++ b/apps/start/src/hooks/use-numer-formatter.ts@@ -2,13 +2,15 @@ import { round } from '@openpanel/shared';import { isNil } from 'ramda';export function fancyMinutes(time: number) {- const minutes = Math.floor(time / 60);+ // Round before splitting, or 239.9s reads as "3m 60s".+ const totalSeconds = Math.round(time);+ const minutes = Math.floor(totalSeconds / 60);if (minutes > 60) {const hours = Math.floor(minutes / 60);const remainingMinutes = minutes % 60;return `${hours}h ${remainingMinutes}m`;}- const seconds = round(time - minutes * 60, 0);+ const seconds = totalSeconds - minutes * 60;if (minutes === 0) {return `${seconds}s`;}