Skip to content

OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.

perf(dashboard): improve chart when only one value exists

Carl-Gerhard Lindesvärd92fd30264879
diff --git a/packages/db/src/services/chart.service.ts b/packages/db/src/services/chart.service.ts
index 824c1cbc0..c7123f035 100644
--- a/packages/db/src/services/chart.service.ts
+++ b/packages/db/src/services/chart.service.ts
@@ -176,9 +176,13 @@ export function getEventFiltersWhereClause(filters: IChartEventFilter[]) {
.map((val) => `x = ${escape(String(val).trim())}`)
.join(' OR ')}, ${whereFrom})`;
} else {
- where[id] = `${whereFrom} IN (${value
- .map((val) => escape(String(val).trim()))
- .join(', ')})`;
+ if (value.length === 1) {
+ where[id] = `${whereFrom} = ${escape(String(value[0]).trim())}`;
+ } else {
+ where[id] = `${whereFrom} IN (${value
+ .map((val) => escape(String(val).trim()))
+ .join(', ')})`;
+ }
}
break;
}
@@ -188,9 +192,13 @@ export function getEventFiltersWhereClause(filters: IChartEventFilter[]) {
.map((val) => `x != ${escape(String(val).trim())}`)
.join(' OR ')}, ${whereFrom})`;
} else {
- where[id] = `${whereFrom} NOT IN (${value
- .map((val) => escape(String(val).trim()))
- .join(', ')})`;
+ if (value.length === 1) {
+ where[id] = `${whereFrom} != ${escape(String(value[0]).trim())}`;
+ } else {
+ where[id] = `${whereFrom} NOT IN (${value
+ .map((val) => escape(String(val).trim()))
+ .join(', ')})`;
+ }
}
break;
}
@@ -270,15 +278,23 @@ export function getEventFiltersWhereClause(filters: IChartEventFilter[]) {
} else {
switch (operator) {
case 'is': {
- where[id] = `${name} IN (${value
- .map((val) => escape(String(val).trim()))
- .join(', ')})`;
+ if (value.length === 1) {
+ where[id] = `${name} = ${escape(String(value[0]).trim())}`;
+ } else {
+ where[id] = `${name} IN (${value
+ .map((val) => escape(String(val).trim()))
+ .join(', ')})`;
+ }
break;
}
case 'isNot': {
- where[id] = `${name} NOT IN (${value
- .map((val) => escape(String(val).trim()))
- .join(', ')})`;
+ if (value.length === 1) {
+ where[id] = `${name} != ${escape(String(value[0]).trim())}`;
+ } else {
+ where[id] = `${name} NOT IN (${value
+ .map((val) => escape(String(val).trim()))
+ .join(', ')})`;
+ }
break;
}
case 'contains': {