Skip to content

OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.

fix: allow number as profile id

Carl-Gerhard Lindesvärde8a8a22fe388
diff --git a/apps/api/src/controllers/track.controller.ts b/apps/api/src/controllers/track.controller.ts
index e0d53dd33..5c8f120b5 100644
--- a/apps/api/src/controllers/track.controller.ts
+++ b/apps/api/src/controllers/track.controller.ts
@@ -273,7 +273,7 @@ async function adjustProfileProperty(
direction: 1 | -1
): Promise<void> {
const { profileId, property, value } = payload;
- const profile = await getProfileById(profileId, projectId);
+ const profile = await getProfileById(String(profileId), projectId);
if (!profile) {
throw new HttpError('Profile not found', { status: 404 });
}
diff --git a/packages/db/src/services/profile.service.ts b/packages/db/src/services/profile.service.ts
index ec4ed02bc..7464b0bfc 100644
--- a/packages/db/src/services/profile.service.ts
+++ b/packages/db/src/services/profile.service.ts
@@ -270,7 +270,7 @@ export interface IClickhouseProfile {
export interface IServiceUpsertProfile {
projectId: string;
- id: string;
+ id: string | number;
firstName?: string;
lastName?: string;
email?: string;
@@ -315,7 +315,7 @@ export function upsertProfile(
isFromEvent = false
) {
const profile: IClickhouseProfile = {
- id,
+ id: String(id),
first_name: firstName || '',
last_name: lastName || '',
email: email || '',
diff --git a/packages/sdks/sdk/src/index.ts b/packages/sdks/sdk/src/index.ts
index dfbfbc63c..23db874c7 100644
--- a/packages/sdks/sdk/src/index.ts
+++ b/packages/sdks/sdk/src/index.ts
@@ -51,7 +51,7 @@ export interface OpenPanelOptions {
export class OpenPanel {
api: Api;
options: OpenPanelOptions;
- profileId?: string;
+ profileId?: string | number;
groups: string[] = [];
deviceId?: string;
sessionId?: string;
@@ -171,7 +171,7 @@ export class OpenPanel {
identify(payload: IdentifyPayload) {
this.log('identify user', payload);
if (payload.profileId) {
- this.profileId = payload.profileId;
+ this.profileId = payload.profileId
this.flush();
}
diff --git a/packages/validation/src/track.validation.ts b/packages/validation/src/track.validation.ts
index 7ea8c1fd8..96b0b6875 100644
--- a/packages/validation/src/track.validation.ts
+++ b/packages/validation/src/track.validation.ts
@@ -9,16 +9,18 @@ export const zGroupPayload = z.object({
properties: z.record(z.string(), z.unknown()).optional(),
});
+export const zProfileId = z.union([z.string().min(1), z.number()]);
+
export const zAssignGroupPayload = z.object({
groupIds: z.array(z.string().min(1)),
- profileId: z.union([z.string().min(1), z.number()]).optional(),
+ profileId: zProfileId.optional(),
});
export const zTrackPayload = z
.object({
name: z.string().min(1),
properties: z.record(z.string(), z.unknown()).optional(),
- profileId: z.union([z.string().min(1), z.number()]).optional(),
+ profileId: zProfileId.optional(),
groups: z.array(z.string().min(1)).optional(),
})
.refine((data) => !RESERVED_EVENT_NAMES.includes(data.name as any), {
@@ -51,7 +53,7 @@ export const zTrackPayload = z
);
export const zIdentifyPayload = z.object({
- profileId: z.string().min(1),
+ profileId: zProfileId,
firstName: z.string().optional(),
lastName: z.string().optional(),
email: z.string().email().optional(),
@@ -60,19 +62,19 @@ export const zIdentifyPayload = z.object({
});
export const zIncrementPayload = z.object({
- profileId: z.string().min(1),
+ profileId: zProfileId,
property: z.string().min(1),
value: z.number().positive().optional(),
});
export const zDecrementPayload = z.object({
- profileId: z.string().min(1),
+ profileId: zProfileId,
property: z.string().min(1),
value: z.number().positive().optional(),
});
export const zAliasPayload = z.object({
- profileId: z.string().min(1),
+ profileId: zProfileId,
alias: z.string().min(1),
});