Skip to content

OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.

fix(dashboard): fix issues where info can accidentally be removed by a save

Carl-Gerhard Lindesvärdf0b0f27a8fc9
diff --git a/apps/dashboard/src/app/(app)/[organizationSlug]/[projectId]/settings/projects/edit-project-details.tsx b/apps/dashboard/src/app/(app)/[organizationSlug]/[projectId]/settings/projects/edit-project-details.tsx
index 89de3e4aa..c8c638982 100644
--- a/apps/dashboard/src/app/(app)/[organizationSlug]/[projectId]/settings/projects/edit-project-details.tsx
+++ b/apps/dashboard/src/app/(app)/[organizationSlug]/[projectId]/settings/projects/edit-project-details.tsx
@@ -32,7 +32,7 @@ const validator = zProject.pick({
type IForm = z.infer<typeof validator>;
export default function EditProjectDetails({ project }: Props) {
- const [hasDomain, setHasDomain] = useState(true);
+ const [hasDomain, setHasDomain] = useState(project.domain !== null);
const form = useForm<IForm>({
resolver: zodResolver(validator),
defaultValues: {
@@ -101,7 +101,7 @@ export default function EditProjectDetails({ project }: Props) {
</div>
<AnimateHeight open={hasDomain}>
<Input
- placeholder="Domain"
+ placeholder="https://example.com"
{...form.register('domain')}
className="mb-4"
error={form.formState.errors.domain?.message}
@@ -112,7 +112,10 @@ export default function EditProjectDetails({ project }: Props) {
name="cors"
control={form.control}
render={({ field }) => (
- <WithLabel label="Cors">
+ <WithLabel
+ label="Cors"
+ error={form.formState.errors.cors?.message}
+ >
<TagInput
{...field}
id="Cors"
diff --git a/packages/trpc/src/routers/project.ts b/packages/trpc/src/routers/project.ts
index ac710a8b7..10c49a1c2 100644
--- a/packages/trpc/src/routers/project.ts
+++ b/packages/trpc/src/routers/project.ts
@@ -51,9 +51,18 @@ export const projectRouter = createTRPCRouter({
data: {
name: input.name,
crossDomain: input.crossDomain,
- filters: input.filters,
- domain: input.domain ? stripTrailingSlash(input.domain) : null,
- cors: input.cors?.map((c) => stripTrailingSlash(c)) || [],
+ filters:
+ input.filters === undefined ? undefined : input.filters || [],
+ domain:
+ input.domain === undefined
+ ? undefined
+ : input.domain
+ ? stripTrailingSlash(input.domain)
+ : null,
+ cors:
+ input.cors === undefined
+ ? undefined
+ : input.cors.map((c) => stripTrailingSlash(c)) || [],
},
include: {
clients: {