OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.
fix(funnel): fallback to 0 if nan for funnel
Carl-Gerhard Lindesvärdf31335609655
diff --git a/packages/common/src/math.ts b/packages/common/src/math.tsindex 56d3781b6..096ff2c76 100644--- a/packages/common/src/math.ts+++ b/packages/common/src/math.ts@@ -27,3 +27,8 @@ export const max = (arr: (number | null | undefined)[]): number =>Math.max(...arr.filter(isNumber));export const isFloat = (n: number) => n % 1 !== 0;++export const ifNaN = <T extends number>(+ n: number | null | undefined,+ defaultValue: T,+): T => (Number.isNaN(n) ? defaultValue : (n as T));diff --git a/packages/db/src/services/funnel.service.ts b/packages/db/src/services/funnel.service.tsindex 5067929bf..101463f07 100644--- a/packages/db/src/services/funnel.service.ts+++ b/packages/db/src/services/funnel.service.ts@@ -1,3 +1,4 @@+import { ifNaN } from '@openpanel/common';import type { IChartEvent, IChartInput } from '@openpanel/validation';import { last, reverse } from 'ramda';import { escape } from 'sqlstring';@@ -222,9 +223,10 @@ export class FunnelService {}[],).map((step, index, list) => {- const next = list[index + 1];return {...step,+ percent: ifNaN(step.percent, 0),+ dropoffPercent: ifNaN(step.dropoffPercent, 0),isHighestDropoff: (() => {// Skip if current step has no dropoffif (!step?.dropoffCount) return false;