OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.
comments: remove the last references to documents that never shipped
Carl-Gerhard Lindesvärdf52fe4f2fc16
diff --git a/ISSUES.md b/ISSUES.mdindex ca1894da7..e6cf13f21 100644--- a/ISSUES.md+++ b/ISSUES.md@@ -80,6 +80,17 @@ gone). These are what was left, each re-checked against the tree on 2026-09-28:`apps/public/`". Widening the scan changes what that gate asserts, so it is adecision, not a fix.+### Pre-existing, found while verifying (2026-09-28)++- **The Bun pin has drifted.** `.bun-version` says `1.4.0` and+ `apps/api/Dockerfile`'s `ARG BUN_VERSION` agrees, but this machine runs Bun+ 1.4.2, so `scripts/doctor.sh` reports a failure and+ `apps/api/src/config/bun-version.test.ts`'s "doctor.sh passes" case is red.+ Confirmed pre-existing by stashing the comment-cleanup diff and re-running:+ same single failure. Either install 1.4.0 or bump `.bun-version` and the+ Dockerfile `ARG` together — the test exists to stop those two drifting, and+ right now it is the installed toolchain that has moved.+### Found while cleaning comments (2026-09-28)- **`notification.constants.ts` duplicates three schemas fromdiff --git a/apps/api/src/config/env.test.ts b/apps/api/src/config/env.test.tsindex 5fdc6f16c..52b963812 100644--- a/apps/api/src/config/env.test.ts+++ b/apps/api/src/config/env.test.ts@@ -42,7 +42,7 @@ describe('ENABLED_QUEUES', () => {]);});- it('parses the cloud split (docs/ANSWERS.md 1.3)', () => {+ it('parses the cloud split', () => {expect(loadConfig({ ...base, ENABLED_QUEUES: 'events' }).ENABLED_QUEUES).toEqual(['events']);diff --git a/apps/api/src/config/env.ts b/apps/api/src/config/env.tsindex 76b442e24..4fc322501 100644--- a/apps/api/src/config/env.ts+++ b/apps/api/src/config/env.ts@@ -312,8 +312,7 @@ const roleSchema = z.preprocess(/*** Same doctrine as ROLE: an unknown token fails boot loudly rather than leaving- * a worker silently idle (V1 ignored it — boot-workers.ts:78-87 — which- * docs/ANSWERS.md §1.3 rules must change). Unset means all of them.+ * a worker silently idle. Unset means all of them.*/const enabledQueuesSchema = z.preprocess(blankToUndefined,diff --git a/apps/api/src/main.ts b/apps/api/src/main.tsindex aec7e24d6..bdfc9b010 100644--- a/apps/api/src/main.ts+++ b/apps/api/src/main.ts@@ -161,8 +161,8 @@ function buildProducerHandle(): QueueProducerHandle {/*** A named child of the boot logger per buffer, plus the buffers' one direct* BullMQ read — ADR-005's `bullQueues` escape hatch. Pausing `cron` from- * bull-board halts ALL buffer flushing, preserved deliberately (docs/ANSWERS.md- * §3: "known!").+ * bull-board halts ALL buffer flushing, preserved deliberately as an+ * accepted trade-off.*/function bufferDeps(producers: QueueProducerHandle): BufferDeps {const cron = findBullQueue(producers, CRON_QUEUE_NAME);diff --git a/packages/core/src/buffers/base-buffer.ts b/packages/core/src/buffers/base-buffer.tsindex 50eff7f99..eec6508ca 100644--- a/packages/core/src/buffers/base-buffer.ts+++ b/packages/core/src/buffers/base-buffer.ts@@ -34,7 +34,7 @@ export interface BufferDeps {* Asked before every flush. ADR-005's `ProducerHandle.bullQueues` escape* hatch, narrowed to the one thing the buffers ask BullMQ directly: pausing* `cron` from bull-board halts ALL buffer flushing, preserved deliberately- * (docs/ANSWERS.md §3: "known!").+ * as an accepted trade-off.*/isCronPaused(): Promise<boolean>;/**diff --git a/packages/core/src/http/auth.ts b/packages/core/src/http/auth.tsindex 12d06e183..1bb21dd6a 100644--- a/packages/core/src/http/auth.ts+++ b/packages/core/src/http/auth.ts@@ -20,7 +20,7 @@// exceptions swallowed => null (fail-closed). 6. `canWriteProject` = level in// {write, admin}; admin stays a superset. 7. 5-minute Redis cache + 60s// in-process LRU on both access lookups; removeMember/updateMemberAccess do not-// clear them. Sessions survive revocation (docs/ANSWERS.md §3: acceptable). 8.+// clear them. Sessions survive revocation, which is accepted. 8.// The nine cross-object binding checks in DISC-011 §4.4. 9. chartProcedure's// share branch overwrites the caller's projectId with the report's — explicit// in the builder, not an accident of spread order. 10.diff --git a/packages/core/src/jobs.registry.ts b/packages/core/src/jobs.registry.tsindex f22a93805..400a74078 100644--- a/packages/core/src/jobs.registry.ts+++ b/packages/core/src/jobs.registry.ts@@ -67,7 +67,7 @@ const sessions = defineQueue('sessions', {// One queue, one worker at concurrency 1, every scheduled job in the system.// Pausing it from bull-board halts all buffer flushing — preserved deliberately-// (docs/ANSWERS.md §3: "known!").+// — an accepted trade-off.const cron = defineQueue('cron', {defaults: { removeOnComplete: 10 },worker: { concurrency: CONCURRENCY.cron },diff --git a/packages/core/src/modules/chart/chart.service.ts b/packages/core/src/modules/chart/chart.service.tsindex 193e186e0..daadade7c 100644--- a/packages/core/src/modules/chart/chart.service.ts+++ b/packages/core/src/modules/chart/chart.service.ts@@ -146,7 +146,7 @@ const BUCKET_PROFILES_FETCH_CONCURRENCY = 4;/*** Cap on the ids one chart data point hands the drill-down modal. The bucket* query used to be unbounded, so a busy project's point returned a 31,447-id- * tail (`docs/ANALYTICS_PERFORMANCE.md` section 6.7) that the modal renders+ * tail that the modal renders* through a virtualizer and nobody scrolls to, after paying for every one of* them in `profiles FINAL` batches. Same number as FUNNEL_PROFILES_LIMIT: both* feed the same modal, so the two drill-downs should not disagree on depth.diff --git a/packages/core/src/modules/chart/src/sankey.sql.ts b/packages/core/src/modules/chart/src/sankey.sql.tsindex b554939e9..47d61c8ac 100644--- a/packages/core/src/modules/chart/src/sankey.sql.ts+++ b/packages/core/src/modules/chart/src/sankey.sql.ts@@ -23,7 +23,7 @@ export const TOP_ENTRY_EVENTS = 3;* `arrayFilter` whose lambda indexed its own captured `groupArray`, which* ClickHouse re-materialises once per element: Theta(n^2) in the longest single* session's event count, fatal on a tenant with one very long session- * (docs/ANALYTICS_PERFORMANCE.md section 6.1). `arrayCompact` is the built-in+ * `arrayCompact` is the built-in* for exactly this and is linear; the result is byte-identical.*/const DEDUPE_CONSECUTIVE = compiledText(diff --git a/packages/core/src/modules/misc/misc.routes.ts b/packages/core/src/modules/misc/misc.routes.tsindex b6129888a..781a0ea63 100644--- a/packages/core/src/modules/misc/misc.routes.ts+++ b/packages/core/src/modules/misc/misc.routes.ts@@ -3,9 +3,8 @@// LIVE route (DELEGATE PATTERN) and calls the same misc.service.ts functions// this file does.//-// `GET /misc/og/clear` and `GET /misc/favicon/clear` are dropped, not ported-// (ADR-015 entry #6: RULED + DEAD — `docs/ANSWERS.md` §1.4 confirms nothing-// depends on them).+// `GET /misc/og/clear` and `GET /misc/favicon/clear` are deliberately absent:+// nothing depends on them.import { z } from 'zod';import { defineRoutes } from '../../http/define';diff --git a/packages/core/src/modules/misc/misc.service.ts b/packages/core/src/modules/misc/misc.service.tsindex 34494dd64..b8358194f 100644--- a/packages/core/src/modules/misc/misc.service.ts+++ b/packages/core/src/modules/misc/misc.service.ts@@ -2,9 +2,8 @@// paths (DELEGATE PATTERN) and call the functions below verbatim — no new// behaviour.//-// `GET/POST /misc/og/clear` and `/misc/favicon/clear` are NOT ported: ADR-015-// entry #6 grades them RULED + DEAD (`docs/ANSWERS.md` §1.4 confirms no proxy-// depends on them), so this wave is where V1 drops them too.+// `GET/POST /misc/og/clear` and `/misc/favicon/clear` are deliberately absent:+// nothing proxies them.//// The ClickHouse CLIENT is `deps.ch` — reads through ch-query.ts, the one write// through `deps.ch.insert` — so the `loadCh` lazy import of `@openpanel/db` isdiff --git a/packages/core/src/modules/profile/profile.rpc.ts b/packages/core/src/modules/profile/profile.rpc.tsindex c767953fb..14554ab55 100644--- a/packages/core/src/modules/profile/profile.rpc.ts+++ b/packages/core/src/modules/profile/profile.rpc.ts@@ -26,7 +26,7 @@ const DEFAULT_LIST_TAKE = 50;/*** `list` and `powerUsers` had no date filter at all, so their cost grew with* the tenant's lifetime rather than with anything the caller chose- * (`docs/ANALYTICS_PERFORMANCE.md` §6.8: 44.2 M rows read for one page of 50).+ * (44.2 M rows read for one page of 50, measured).* Both now take the report vocabulary's window; this is the default when the* caller names none, and it is the range §6.8 itself uses to describe the* change ("a power user over 90 days is not the same set as over all time").