Skip to content

OpenPanel is an open-source web and product analytics platform, an open-source alternative to Mixpanel with optional self-hosting.

ralph(M15-116): Per-module fixes: packages/core/src/modules/misc - R16 and the findings no rule covers

ralphf64e7f83a2d2
diff --git a/packages/core/src/modules/misc/misc.routes.ts b/packages/core/src/modules/misc/misc.routes.ts
index 80ee7dd93..749f17803 100644
--- a/packages/core/src/modules/misc/misc.routes.ts
+++ b/packages/core/src/modules/misc/misc.routes.ts
@@ -6,9 +6,6 @@
// `GET /misc/og/clear` and `GET /misc/favicon/clear` are dropped, not ported
// (ADR-015 entry #6: RULED + DEAD — `docs/ANSWERS.md` §1.4 confirms nothing
// depends on them).
-//
-// NAMED GAP, same as every other module here: not yet reachable — main.ts
-// does not mount `dashboardRoutes` until a real `AppDeps` exists (P3/P4/P8).
import { z } from 'zod';
import { defineRoutes } from '../../http/define';
diff --git a/packages/core/src/modules/misc/misc.service.ts b/packages/core/src/modules/misc/misc.service.ts
index e780ffe82..977f3cb51 100644
--- a/packages/core/src/modules/misc/misc.service.ts
+++ b/packages/core/src/modules/misc/misc.service.ts
@@ -103,6 +103,9 @@ function validateUrl(raw?: string): URL | null {
}
}
+// Unlike `loadCache` above, this reaches the redis singleton directly rather
+// than through `deps`/`ctx` — a known R6 gap (docs/review/misc.md), left as
+// nothing calling these two functions today holds a `deps`/`ctx` to thread.
async function getFromCacheBinary(
key: string
): Promise<{ buffer: Buffer; contentType: string } | null> {
diff --git a/packages/core/src/modules/misc/src/parse-url-meta.ts b/packages/core/src/modules/misc/src/parse-url-meta.ts
index 475e91bf8..894f4eb0f 100644
--- a/packages/core/src/modules/misc/src/parse-url-meta.ts
+++ b/packages/core/src/modules/misc/src/parse-url-meta.ts
@@ -69,6 +69,9 @@ function transform(data: UrlMetaData, url: string) {
};
}
+// This fetch is guarded by url-metadata's own bundled `request-filtering-agent`,
+// not by this module's `assertPublicUrl`/`safeFetch` (used for the image fetch
+// that follows) — a different SSRF implementation for this hop, not the same one.
export async function parseUrlMeta(url: string) {
try {
const metadata = (await urlMetadata(url, {