Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Remove workaround for template compiler bug

Alexander Brandon Coles0416e6ccdd9f
diff --git a/frontend/src/app/features/work-packages/components/wp-table/configuration-modal/tabs/sort-by-tab.component.html b/frontend/src/app/features/work-packages/components/wp-table/configuration-modal/tabs/sort-by-tab.component.html
index b6579eadd66..f5185958e88 100644
--- a/frontend/src/app/features/work-packages/components/wp-table/configuration-modal/tabs/sort-by-tab.component.html
+++ b/frontend/src/app/features/work-packages/components/wp-table/configuration-modal/tabs/sort-by-tab.component.html
@@ -54,18 +54,9 @@
[value]="sort.column.href"
selected></option>
}
- <!--
- TODO:
- The option element below used this code:
- [selected]="sort.column.href === null"
- However, the Angular template compiler wrongly complains about the comparison.
- https://github.com/angular/angular/issues/18754
- Since the explicit null comparison is safer than `!sort.column.href` the code
- should be reverted to the old version once the bug is fixed.
- -->
<option [textContent]="emptyColumn.name"
[value]="emptyColumn.href"
- [selected]="!sort.column.href"></option>
+ [selected]="sort.column.href === null"></option>
@for (column of availableColumns; track column) {
<option
[textContent]="column.name"