Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Tidy up function calls including guard clauses

Kabiru Mwenja05c20e440191
diff --git a/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/infinite-scroll.controller.ts b/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/infinite-scroll.controller.ts
index 9ebaa44ad63..fcd4f28641d 100644
--- a/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/infinite-scroll.controller.ts
+++ b/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/infinite-scroll.controller.ts
@@ -62,7 +62,6 @@ export default class extends BaseController {
super.connect();
void this.initializeTurboRequestService();
-
this.setupScrollPreservation();
}
@@ -103,8 +102,9 @@ export default class extends BaseController {
event.preventDefault();
const stream = event.detail.newStream;
+ const insertTargetId = this.insertTargetIdValue;
- if (stream.target.includes(this.insertTargetIdValue)) {
+ if (insertTargetId && stream.target.includes(insertTargetId)) {
const isPrepend = stream.action === 'prepend';
void DomHelpers.keepScroll(scrollContainer, isPrepend, () => {
event.detail.render(stream);