OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
[#64348] add formula_referenced_custom_field_ids method
Ivan Kuchin0a345aff63ec
diff --git a/app/models/custom_field/calculated_value.rb b/app/models/custom_field/calculated_value.rbindex 2534eff9e58..935dda30861 100644--- a/app/models/custom_field/calculated_value.rb+++ b/app/models/custom_field/calculated_value.rb@@ -67,6 +67,10 @@ module CustomField::CalculatedValueformula ? formula.fetch("formula", "") : ""end+ def formula_referenced_custom_field_ids+ formula ? formula.fetch("referenced_custom_fields", []) : []+ end+def usable_custom_field_references_for_formulavisible_cfs = ProjectCustomField.where(field_format: FIELD_FORMATS_FOR_FORMULA)diff --git a/spec/models/custom_field/calculated_value_spec.rb b/spec/models/custom_field/calculated_value_spec.rbindex a10744cf223..8e777b122a2 100644--- a/spec/models/custom_field/calculated_value_spec.rb+++ b/spec/models/custom_field/calculated_value_spec.rb@@ -156,6 +156,26 @@ RSpec.describe CustomField::CalculatedValue, with_flag: { calculated_value_projeendend+ describe "#formula_referenced_custom_field_ids" do+ it "returns an empty array if no formula is set" do+ subject.formula = nil++ expect(subject.formula_referenced_custom_field_ids).to eq([])+ end++ it "returns an empty array if formula doesn't reference custom fields" do+ subject.formula = "2 + 2"++ expect(subject.formula_referenced_custom_field_ids).to eq([])+ end++ it "returns ids if formula references custom fields" do+ subject.formula = "1 * {{cf_7}} + {{cf_42}}"++ expect(subject.formula_referenced_custom_field_ids).to eq([7, 42])+ end+ end+describe "#has_circular_reference?" dolet!(:int_field) { create(:project_custom_field, :integer, default_value: 10, is_for_all: true) }let!(:float_field) { create(:project_custom_field, :float, default_value: 5.5, is_for_all: true) }