Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Add error handling for deliver_now

Oliver Günther0b74f3f65cb4
diff --git a/modules/meeting/app/services/meetings/delete_service.rb b/modules/meeting/app/services/meetings/delete_service.rb
index 14ac391db18..e74194900c6 100644
--- a/modules/meeting/app/services/meetings/delete_service.rb
+++ b/modules/meeting/app/services/meetings/delete_service.rb
@@ -44,6 +44,10 @@ module Meetings
MeetingMailer
.cancelled(meeting, participant.user, User.current)
.deliver_now
+ rescue StandardError => e
+ Rails.logger.error do
+ "Failed to deliver meeting cancellation for meeting #{meeting.id} to #{participant.user.mail}: #{e.message}"
+ end
end
end
diff --git a/modules/meeting/app/services/recurring_meetings/delete_service.rb b/modules/meeting/app/services/recurring_meetings/delete_service.rb
index 6430a052951..3dad8ed5a56 100644
--- a/modules/meeting/app/services/recurring_meetings/delete_service.rb
+++ b/modules/meeting/app/services/recurring_meetings/delete_service.rb
@@ -47,6 +47,10 @@ module RecurringMeetings
MeetingMailer
.cancelled_series(meeting, participant.user, User.current)
.deliver_now
+ rescue StandardError => e
+ Rails.logger.error do
+ "Failed to deliver recurring meeting cancellation for series #{meeting.id} to #{participant.user.mail}: #{e.message}"
+ end
end
end
end