Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#66093] Project overview calculation error spec

Tobias Dillmann0ca710ca8cd0
diff --git a/modules/overviews/app/components/overviews/project_custom_fields/item_component.rb b/modules/overviews/app/components/overviews/project_custom_fields/item_component.rb
index c16026a462d..8b503cb1144 100644
--- a/modules/overviews/app/components/overviews/project_custom_fields/item_component.rb
+++ b/modules/overviews/app/components/overviews/project_custom_fields/item_component.rb
@@ -58,7 +58,10 @@ module Overviews
errors = @project_custom_field.calculated_value_errors.where(project: @project)
# FIXME: this is a copy from the project list row component. Reuse it here.
- render(Primer::OpenProject::FlexLayout.new(align_items: :center)) do |container|
+ render(Primer::OpenProject::FlexLayout.new(align_items: :center,
+ data: {
+ test_selector: "error-cf-#{@project_custom_field.id}"
+ })) do |container|
container.with_column do
render Primer::Beta::Octicon.new(icon: :"alert-fill", color: :danger)
end
diff --git a/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb b/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb
index e26ff82becc..0dff5fb910f 100644
--- a/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb
+++ b/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb
@@ -594,6 +594,25 @@ RSpec.describe "Show project custom fields on project overview page", :js do
end
end
+ describe "with an error present" do
+ before do
+ calculated_from_int_and_float_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+
+ calculated_from_int_and_float_project_custom_field
+ .calculated_value_errors.create!(project_id: project.id, error_code: "ERROR_MATHEMATICAL")
+ end
+
+ it "shows the error message for the project custom field" do
+ overview_page.visit_page
+
+ overview_page.within_project_attributes_sidebar do
+ overview_page.within_custom_field_container(calculated_from_int_and_float_project_custom_field) do
+ expect(page).to have_text I18n.t("calculated_values.errors.mathematical")
+ end
+ end
+ end
+ end
+
describe "with value unset by user" do
before do
calculated_from_int_project_custom_field.custom_values.where(customized: project).first.update!(value: "")